Add support for Wintertide Brand average DOT calculation#6868
Merged
Conversation
|
Any word on this being merged into PoB? |
Wires77
approved these changes
Jun 12, 2025
Wires77
left a comment
Wires77
left a comment
Member
There was a problem hiding this comment.
Looks good, sorry we didn't merge this at the time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2044
I've added support for the average effective DOT DPS for Wintertide Brand. It uses the calculator from this thread:
https://www.reddit.com/r/pathofexile/comments/hb868n/summary_of_wintertide_mechanics_and_dps/
https://docs.google.com/spreadsheets/d/1AetMLe1lwIVgURok2lZtvBoNZ4irrev57ThHrdYxYn0/edit#gid=0
I checked it against the calculator for various inputs to see that it matches.
It's useful because the default calculation ignores cast speed & duration, which makes it harder to figure out the relative value of those stats.