Fix many unique staves with Attack block instead of Spell block implicit#8580
Merged
LocalIdentity merged 2 commits intoJun 6, 2025
Merged
Conversation
Contributor
|
Stumbled upon another staff implicit issue and it seems like uniques with certain bases had their implicit set to attack block instead of spell block. Patch notes read: "Imperial Staff, Lathi, and Primordial Staff now have +25% Chance to Block Spell Damage while wielding a Staff (previously +18%)." However, in the merged commit we can see that the uniques from the above listed bases got their values all set to Attack block rather than Spell block. Maybe this PR can be changed to apply to all of the affected uniques? |
LocalIdentity
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8579
Description of the problem being solved:
The base type "Quarterstaff" for annihilating light was changed from 18% attack block to 22% spell block, but the current variant for the unique was using 22% attack block. Quick fix.
Steps taken to verify a working solution:
After screenshot: