Add support for self cast Hydrosphere DPS#8598
Merged
LocalIdentity merged 3 commits intoJun 6, 2025
Merged
Conversation
…continuously recast. Adjusted skill part names for Frozen, Shocked and Frozen & Shocked for clarity.
…rts since the damage pulse from casting actually also converts depending on the ailment of the sphere.
LocalIdentity
approved these changes
Jun 6, 2025
LocalIdentity
changed the title
LocalIdentity
merged commit 291ab00
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1968
Description of the problem being solved:
"There is no way of calculating Hydrosphere damage when casting it. Currently, only "auto" pulses are accounted."
Solution:
Added skill part "Cast" for Hydrosphere, for when the Hydrosphere is continuously recast. Adjusted skill part names for Frozen, Shocked and Frozen & Shocked for clarity. Split "Cast" further into Frozen, Shocked and Frozen Shocked skill parts since the damage pulse from casting actually also converts depending on the ailment of the sphere.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/ClnxZZVGiH5d
Before screenshot:
After screenshot: