Fix Relic Flask's combining effect with unique flask of the same name#8610
Merged
Conversation
Relic flasks were not being checked to also be unique when we merge the buff effects so they were duplicating Fixed for Tinctures too
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
May 27, 2025
Same fix from PoB 1 PathOfBuildingCommunity/PathOfBuilding#8610 Also applies to charms for PoE 2 and the Lich jewel socket in-case PoE 2 ever adds relic items
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
May 27, 2025
Same fix from PoB 1 PathOfBuildingCommunity/PathOfBuilding#8610 Also applies to charms for PoE 2 and the Lich jewel socket in-case PoE 2 ever adds relic items Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
…1143) Same fix from PoB 1 PathOfBuildingCommunity/PathOfBuilding#8610 Also applies to charms for PoE 2 and the Lich jewel socket in-case PoE 2 ever adds relic items Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relic flasks were not being checked to also be unique when we merge the buff effects so they were duplicating
Fixed for Tinctures too