Add mod parsing support for 3.26 Vile Bastion#8643
Merged
Conversation
Wires77
reviewed
Jun 10, 2025
Wires77
left a comment
Member
There was a problem hiding this comment.
Thanks for adding the tests, this is great! Let's also change the wording to remove "Maximum" and better match the other mods like it.
Contributor
Author
|
Thanks for the quick feedback! Moved/renamed 😃 I'm assuming the inital modcache update is okay by the way? I thought it was surprising that some mods were removed when I refreshed with a fresh checkout of dev, so I've kept that change split out in 4074bb7 just in case I've messed with it somehow. |
Member
|
Yeah, someone likely didn't regenerate the ModCache and the PR was merged. It's a recent change to our process so I'm not totally surprised. It definitely didn't come from your changes though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Implements support for the upcoming custom mod on the new version of Vile Bastion in 3.26:

ESRegen/sec was already supported, but es per spell block was not (at least that I found)
Hope the flag name is okay, could also be changed from
MaximumEnergyShieldIncreasedByChanceToBlockSpellDamage->EnergyShieldIncreasedByChanceToBlockSpellDamageif preferred!
Name changed 👍
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/MbdcjsAu3trY
Before screenshot:
With 50% spell block staff and 100 ES boots (as per linked build)


After screenshot:
With 50% spell block staff and 100 ES boots (as per linked build)

