Skip to content

Update parsing for Vile Bastion#8650

Merged
Wires77 merged 3 commits into
PathOfBuildingCommunity:devfrom
Ariacell:fix/VileBastionWordingFlexibility
Jun 12, 2025
Merged

Update parsing for Vile Bastion#8650
Wires77 merged 3 commits into
PathOfBuildingCommunity:devfrom
Ariacell:fix/VileBastionWordingFlexibility

Conversation

@Ariacell

Copy link
Copy Markdown
Contributor

Increase flexibility in parsing for energy shield being increased by spell block on 3.26 Vile Bastion

Description of the problem being solved:

The wording on the Ascendency Node is slightly different to what I expected (because I can't read patch notes, sorry for the quick double PR for this 😶‍🌫️)

Steps taken to verify a working solution:

  • Validated with the same build as Add mod parsing support for 3.26 Vile Bastion #8643 (comment) , and then a new build using the Occultist node as well
  • Additional validation done by actually selecting the Vile Bastion node on the new tree, and confirming calcs work as expected.
  • Added tests for both variants to ensure parsing is working as expected.

Before screenshot:

image
image

After screenshot:

Confirmed the new ascendency node is also getting parsed correctly and calculations are impacted appropriately in preview/calcs breakdown
image
image

Comment thread src/Modules/ModParser.lua
@Wires77 Wires77 merged commit e8c1691 into PathOfBuildingCommunity:dev Jun 12, 2025
2 checks passed
@Wires77 Wires77 changed the title Improve flexibility in Vile Bastion keystone parsing for 3.26 Update parsing for Vile Bastion Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants