Skip to content

Generalize parsing of some minion mods#8655

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
Paliak:issue-8638
Jun 13, 2025
Merged

Generalize parsing of some minion mods#8655
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
Paliak:issue-8638

Conversation

@Paliak

@Paliak Paliak commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Closes #8638

Description of the problem being solved:

Parsing for some minion mods was separated for each dmg type which caused lack of parsing for mod from issue.

Steps taken to verify a working solution:

  • Test the touched mods
  • Check ModCache

Link to a build that showcases this PR:

eNqtHGlv27jyc_0rCAP7sIttEh22E-clu3CuNkDSZu20fe_TgpFoW6-06EpUjl3sf3_DQ4dtHZTtFmhtcS7OcIYzQ8pnv78uKHomURyw8LxrH1pdREKP-UE4O-9-ebw5OOn-_lvn7AHz-efpRRJQMfJb592Z_IwoeSYU8LqI42hG-NeUkvsnUFrikM8JC-_x_1j0gfnn3U8sJF30hEM_4Ok3j-I4_oQX5Lw78QC5i3DskdC_zJ9rwDmOsMdJdCe4jhLO7pkPozxKYHSBg3DCvO-Ef4hYspRCPQfkRcHc3j98Hj8WRArCokgwo3dnDxS_kWjCMUcx_HPeHXk8eCYAClLdBYuAA0VMEyDndI8qUECXeEY-FmCtBtiLJIr5FV7Ax2acyZIQPwOzq8Auo4DfJ5QHSxqQKIc_7FdhgMSXcxx6uQy2VSnFI-OYXj1MmuVVkMxAG98CPr-gMDsjugL6dhYGnBiDP7AgZmErqY2ALxNKwSmMYMckJtEz5oGhIJds8RSEhjq5xyG-ZDE3g3wgEXgZb4UwIR4Dx2zLoyXmXTAl5pCt5qER2kqz3TyuJ6ZwrQlvJ9AYQowZ5IQl1BCS5-HFqVn3P4qAw5MqwCvyakauCNgbVAHehtyMXBFwUCPdM-NyizKKINcfH_Jo2js-PB70B1bfsd2hW4X3MH-LAw_Te_waLJIFROVH_J3kDB2nX71QZ3MeQiSqwrXdyondBBHZAu2SUX8btDlmcSVez65zxQzupF-zR3qnAvY29Mz8-0sYycBc2FpP-nUIY_A6sXs_UWKIkbPQvmuyzypWMxJqfm9m07kjxJt_gHxojDkxi9QZVN-qVauANVKrACxRa98QoYWSBGKFkg6HdUgt1XQdkmj2NpkHhPrtoFPBLvHSKMPzTovYRupeZddqxRRRW6rkG44KyWivduNpK9UzjouR1h7UK0yBmy1NAmkmIPhkLeOtxHiI2P8IFAO0HdooWrAkMjS5AjaaQLpJqKJhTPzEM9uVrqdTImuaCwqVkuk0MiyQk9JWqCPOsff9ivkzY6VJJq0wVuWbJMslRBGxGkwJiN0PMvOgkO8cDAygP8NSNvJpsU-aM8ihjRlke785lzUU87mIzbvFZHJwYxaZQe8hWCxgG5BVLxTyhUK2Og-6gXrMqF6SgIZF3gN7AeHnoskRt4OGPCdDqEz7biIS_vVmTH8F3IjBdegnkfAGYx7rGEZsmjsmamyzC7LWAOn3rcPjoeUeW8MqxPJWyLZgGy0NAwkqmxsbkKXNDQMOmy0O1z3sW1BInJzU8drE65_0Dp3hieUMj6sQNxsktj08bAJftZvjDg97dZJtMhk4wGTomCh6VTYHNDGs00RNZ2YDtqEzs0m7pDMzGLiHrmXV6XilhLGtYd-ug6zPmUpR6jO4DZTapLYWuqVs5lnmY7CABC2OrzDHyNcV91ccBTjkjmzrxgRH3vwOtpQbTOkTZBjn3eJT-U22gm8Cykl0Bc9EJBM81inaaUw4O5ItbfHpdrFkEUfkVfz3gCP-dt6dYhoTBSifAJ2YB6FcMBDEKO2iyZy9jPxnwemRMRqnSAgvlyT0V2g8RoQgnGYtnhBCTl58QQscg9RvahuMxWwKHfFbX04jZCCAcOsT1xVzF10gHL2NVgHDAOTiwKvQmHcGuueuKAm2786-jO_kh3dzzpfx6dHRy8vL4RLzOZuSV8h7Dz22OFoCEgh8EH8PKD0QZI9G8OdiNpJ_JKGjlNKZasbHR-qb2PyjAGRWRj4SE5VaF5oQHz4xTmIxJh6mX84mglUM1oz4B7KIL97A327EGlrzQK1KAT0hXK2SIk56SuCTKU6oeP5HgmkgLGsVn96pA42QRYusCQOkwLIir1QUH9-WQvWjuzs1MqJcExPsUjMrc2qBUOCnJtYP5XnFKJf6ElMvlnIHoUcTn9yGOpHRVqT4SUgm5pVEYi3fcrI4dU6_Mtil8b_wksX_jtG98IH3aJyEgYcm-AlzFsbiTEe0KvxUCzFloKMLxnjcXRckk_PdGUxHY36g7AlTR4si7a89fFX2woh-OEkWCwZWGkVAAPwQGOpDI8fS8GIdKrAC0DoPSf5HwWZFwex0Ymvz9FgSci10iBfa1RQvVM6sTGK9hI-kIM02lOyarLgm6YYRBHS1GbQZK-1QUPGMLISC7wnHPkTUI7Fs4iOxUtV84JOa8Q0FDX1glCxESJbBMbdMcXDNaBtDdVbTnwX2lXK6Vpa0S-wo-aNNAXJLFiTcMKX-CD4qo5GKN-KjVKaEuA2XCZd8z7vC3xX5LnqCIE9wqEU82oQVtP4Mk8WTOIJT_-cZaBFyEcTen0_JdCoOK2ESPJLnr9c3N9eXj7dfrzXKhMg6H8XJU6w-nne_BuRFCn0FBg5oLFRFKV7GJNtwZPDRs6SAV0NNQn0MsuPIclo5QDWl61cSwf44-wYBKQpIpVzZeINQiqFINkR-UEVNJOPVhFQ34hJ2V5V4VGhKFgzVVMTZauV0xGANLmQWmFZy1qMNmuBi-wEHCKaBJxKsepOLzUpB1ejF86DU895q7K1bKdU0ZHVTRUANViOroqAKW4_WaFVWO5VaVaPV6FfEw5VzV4PVyFkuy0J56F9OJYOqofRJF1PgNKOAirZHpWWvKclAqgl-5nMS6SSyitI9RJ4UpNZxouAp4dVuXICo0ZUsfio0JMaqUdUZRcUcxFhNJFopcSoUWoSpJqX63ZWBrA5VtcAq9acbajUm0L3kCvWr0RolpO30ivnr4RonkfF39MwCXzVVK9xlDawuYEB9sDsZ2Snencx663h3ipB0xN8r7a1Hq9G_8EAkSiVUVEJkREQ41W4UhG_tRuERMmGeRGRrAuP1TCTHHdfnIFmvsxQ5Ha2LHLoFujUF1ajdGl32kbfGlvEfsmwCM6jdADKYGv_gSXgFyuA1vmFISopVHkjy2bWipbbC0pm2pqgcXF9JqIsBCqSBEOzlH2uyRTNK2XHIR4Kp6KAyuhvBjasXuxATLcBkiUM_Jfe5LEfP7WCoPcZjoClbclei07irDkOyeCshVC3X2VFaAcpmnaizdItxwiNRwf_F2OK_sqgVn3TjyNXNIsi4rwKwWyTXW8pHAP4n7XSeyUpcd67E56xxVU0giYm68PWN4CXU2AKj0G4SVIqtpjGU8fztFI1H4-vOJ5iAAOhAJeyTEF1Ayk-iuHMZ4Skn_ikSLDoPEZkGr6dIXIut-TKBYtXgi-6LnSLH6uh-IEhzIP92pMrG5Mcpsp0O1D408AIxbnf-5ngWn8KeIVtd7ylsY__8DZF4Rk6tw_4_v_7sWAeu9QviDC3UWkZiq-uoyjwGA4ewCDmyrZ8QmyJxYouUfQWKPJJEvvq-JBGKiK_7xbI5AEX4WPBCkqO4RtLvaq3q9kElRHrKJbssuUl0OwXGe1lvZUSFta0Ur_DYFZenig9E13vNol8-3f7x5bpT0vzrrPb-OiIvBZ32LPnpAsfpbcaAEqHrO4JnCXy6fl0SPxDe0tGtcW3D7Jsqn5Gsj_OnoM0A2GTfZa1XGI6SeI4-hwjCQ_70CiIZumLJE00Nk4-peg3B1kn-IqKp7n0vDIZTWCYciTNyITKLIbVga9RTIGn3FGhDhhQqOwivA-XBAvYrXhDzHgeL_JuqUfPvX8JQ3GMqKM9XyoV557dJCmrLuo1oRCls-wUVTsAzeAFUXP9IlzOQRaNYqqMWQKiiFiDTQjnUpfaoR1bDqwBUza8AVMYz1w26YVHB8g-BWLYd1cICh80GnF7nIxZq4_kzGcoy0JUh21oHR48vrAZFDdv2JtoclmgtogKw3ZU4mIe9wbAY9pRcIUM6UHYeo2A2gwiNJAagovXONXqZQyC__pEES3DejtP_SfSdIwJO7qP08oR22L91PDl1iqE0bZEWaM7xM0E_u9ZBz_qlSG_F_TNqbgkJFY9WbCmjBPrVQeBIsOwz9F69MJqSYp2K1rMOBkI0T_akREQPtCvL2CPWU0a_bzRZ2zpwVimqsKUDS0ZtYETN6R-4_RVq_ma4y2gem0nYP3BWaar4-F4FyPcIkiUdOXPSJ1tOPigLshvKGO5IfTU6r1O3rR3Jl4T1DR62mT1lslHkke8HaMoi1NPnr_EmB2dLDmJ3aaLtGtHe9Ba9V-WEelsKqTe5JjmbfHAqFsLPzkHvF4TLd8mc1uCfX23BWp2miORuk2AB_NgsOskdFlYOEHYL2E3-MxMxLYuUIEt6MTPd6yCeX7_yCCtPWvd8oF-lbMdq74_2cG_iFhLmFfrtxK13cMfam7i5q6_LDEzayWwQNRy7jOZlVnJYpcJyVr4IHHvLOKfif4GQs6VYpcZ2nC3FWt-DHHdLsWqM6m4pm6olcjo9s-gg89Acq2-UshQJqNR1M8Q9yndm4z0VnTUQbiNErxGi3wgxaIQ4boQ4aYQYNkLYVjNIs1btZrXazXq1mxVrN2vWblat3axbu1m5TrPqHIMF2aw6p1l1TrPqnGbVOc2qc5pV5xiornlhus3adZu16xr4u1vahxIX0ao7iKt31CiDhAhwHp6-jO9Eu1PdVPlAoaqMu3LothidqhAUG2TnKFYTiryXhkZPb3EMQVJVw6jfhgCBInwN32mBL4-kkNsCI50lmrzg5Trr3jaEdpi-puHsgUb5hAZ7mNBgDxPaikbZhHZene4eNOLsazZt1ttHQheE76SPEmcb7CyB05rCzizdfem_v4fFYO_BPew9yNFruRL2FWKcXT2ytwcFtt8z9hZi3V3n7-zowu0E8N-QuoK0yxpUucUuFModu78zhcG-zGrvK8a0X5q767G3sy37-1lUbSY_WiSU8D1EQncPAcXd0Sl7O-Lb-9H_1jtl60Xba42xTRa1o1b7u8bqPZmlt6_gsre8eusSqgXeWLQInZ1Dk7MfG-xtp9hHwdfbbk5tlb_7Hr-nZKO_syC7b3GDtsEgh3e2Ch6bDFXXR73RJC6vYZ9M5MW1b0T01GN1u03ePpMvOrFwGsz0PTT1Rd9Ek_jZE8QDTknhva1iv6j4NpOXxJwt7pkf568yxWmfHK926eUBwOYxjDwSJIUTmHnAOyU0vLVzhGV6juBn5wiSlF94XUn-bIFH5uIWXKRFJuJ6oP6lgPRFrWPLakBY-SmMFM1twsoONtKXrFJMx-nZTRyj_GcaU7R-A07x100ynMapwZMt5BO8tkCTF1xyjJNeNfwi-1VL8WsCJCL-RL7UJd4PnBA6Lbxo1zeYY2vFZNZ7EBdnM6ObYrU3hFhj6yo9GQ4a0LL3PTJtWHbPNVhd66xck5ViqouJx-T9WXGZZ-ONyEoO-meOGKWy21300AbMdD9LEQb28GRYjRMHs4B-nspb9yCkfHXAVMjV32Rq7TTGGhRHmBUKPDvKYrW6vyy__dY5O1r_-d7_A3yDQjo=

@Paliak Paliak added the enhancement New feature, calculation, or mod label Jun 12, 2025
@LocalIdentity LocalIdentity merged commit 6b3e2ae into PathOfBuildingCommunity:dev Jun 13, 2025
2 checks passed
LocalIdentity pushed a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Aug 29, 2025
Generalize parsing of some minion mods
9eafb16 
Copy of PR PathOfBuildingCommunity/PathOfBuilding#8655
@LocalIdentity LocalIdentity mentioned this pull request Aug 29, 2025
Merged
@LocalIdentity LocalIdentity added the pob2 Label for features that should be ported over to PoB-PoE2 label Aug 29, 2025
LocalIdentity added a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Aug 29, 2025
@LocalIdentity
Generalize parsing of some minion mods (#1212)
aaa6b66 
Copy of PR PathOfBuildingCommunity/PathOfBuilding#8655

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Tonkat pushed a commit to Tonkat/PathOfBuilding-PoE2 that referenced this pull request Sep 1, 2025
@LocalIdentity @Tonkat
Generalize parsing of some minion mods (PathOfBuildingCommunity#1212)
54b817e 
Copy of PR PathOfBuildingCommunity/PathOfBuilding#8655

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minions convert 100% of ELEMENTAL Damage to Chaos damage not parsing

2 participants

@Paliak @LocalIdentity