Fix Nebulis and similar mods being treated as uncapped#8666
Merged
LocalIdentity merged 3 commits intoJun 13, 2025
Conversation
Member
|
Would you want to add some tests so this doesn't get missed again? |
LocalIdentity
approved these changes
Jun 13, 2025
LocalIdentity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8664 and #2735 (comment)
Description of the problem being solved:
#8652 attempted to fix a problem with globalLimits where ordering of tags in the mod table caused the limit to not apply by moving the limit check into ModStore. This caused the limit to apply only to "Multiplier" type mods that do not actually multiply the mod value. This pr fixes the issue by moving the limit check into a separate loop after applying mod tags.
Ideally, looping over the tags again wouldn't be needed if there was a good way to either move the global limit variables into the main mod body or ensure ordering of mod tags inside the mod table.
Steps taken to verify a working solution: