Fix issue with converted damage showing no poison stacks#8991
Merged
Conversation
Wires77
changed the title
|
While to poison chance is now calculated correctly, I don't think it's working for Full DPS yet? Poison DPS doesn't appear when a skill is toggled for Full DPS, forcing 100% Chance to Poison in Custom Modifiers makes the calculation correct. |
added 3 commits
April 17, 2026 05:08
LocalIdentity
approved these changes
Apr 16, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I vastly simplified the code as it does not need new conversion code as we correctly handle that already. All we needed was support for chaosPoisonChance to be included
mauriceco2424
added a commit
to mauriceco2424/PathOfBuilding
that referenced
this pull request
Jun 16, 2026
Key changes: - Imbued Supports system (PathOfBuildingCommunity#9670) — replaces alternate quality code (PathOfBuildingCommunity#9758), with follow-up fixes for gem list visibility (PathOfBuildingCommunity#9782, PathOfBuildingCommunity#9796), trigger supports (PathOfBuildingCommunity#9793), and indexing bugs (PathOfBuildingCommunity#9763). This is the in-league replacement for Awakened gems and changes how transfigured supports scale. - Calc fixes wave: skills that can repeat (PathOfBuildingCommunity#9723), Vaal Flameblast base AoE (PathOfBuildingCommunity#9704), Generals Cry clones restricted by attack time, Maven Memory Game damage (PathOfBuildingCommunity#9757), Hextoad breakdown (PathOfBuildingCommunity#9683), CwC crash with multiple link groups (PathOfBuildingCommunity#9682), Searing Bond of Detonation power charges (PathOfBuildingCommunity#9695), Tinctures applying without Mana (PathOfBuildingCommunity#9769), Ghost Reaver leech with Life Leech sources (PathOfBuildingCommunity#9774), Poisonous Concoction added damage from disabled life flasks (PathOfBuildingCommunity#9339), Blade Blast of Dagger Detonation Varunastra counting (PathOfBuildingCommunity#9733), converted damage with poison stacks (PathOfBuildingCommunity#8991), Chieftain resist nodes Foulborn Choir double-apply (PathOfBuildingCommunity#9643), Turbulent catalyst flat lightning scaling (PathOfBuildingCommunity#9775), some buffs applying to player and minions wrongly (PathOfBuildingCommunity#9789), negative eHP and NaN Max hit (PathOfBuildingCommunity#9772), Dual Wield mastery thrusting+non-thrusting (PathOfBuildingCommunity#9761). - Ring slot 3 fixes (PathOfBuildingCommunity#9686, PathOfBuildingCommunity#9730) — mods applying when Unseen Hand isn't allocated. - Build comparison tab (PathOfBuildingCommunity#9543) — pure UI, headless mode unaffected. - New spectres: Conjuror of Rot (PathOfBuildingCommunity#9702), Unholy Aberration (PathOfBuildingCommunity#9731). - Trader improvements (PathOfBuildingCommunity#9691), Watcher's eye trade search (PathOfBuildingCommunity#9649), duplicate-search fix (PathOfBuildingCommunity#9767), stale state guard (PathOfBuildingCommunity#9742). - Lesson of Seasons spell barkskin mod (PathOfBuildingCommunity#9820). - Lingering Blades extends to Animate Weapon of Ranged Arms. - Runtime DLLs bumped to SimpleGraphic v2.5.3 (PathOfBuildingCommunity#9395) — affects desktop PoB UI only; headless API runtime is the bundled LuaJIT. - Releases 2.64.0 and 2.65.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8990.
Description of the problem being solved:
Fixed poison stacks showing 0 despite 100% poison chance when using multi-step damage conversion chains (e.g., Cold→Fire→Chaos→Poison). The issue occurred because Path of Building's ailment calculations only considered unconverted damage portions and didn't account for damage that becomes eligible for ailments through conversion chains.
Root causes addressed:
calcAilmentSourceDamage()only used unconverted damage, ignoring conversion contributionsChaosPoisonChancefor both hit and crit scenariosCanPoisonflags for damage types that convert to ChaosSteps taken to verify a working solution:
Link to a build that showcases this PR:
Path of Building test build:
Before fix:
Poison DPS: 0, Poison Stacks: 0, despite showing 100% poison chance
After fix:
Poison DPS: 1,178.9, Poison Stacks: 0.67, Poison Chance: 100% (working correctly)
Technical Changes:
calcAilmentConversionMultiplier()function for multi-step conversion trackingcalcAilmentSourceDamage()to use conversion chains instead of just unconverted portionsCanPoison/CanIgniteflag enabling for converted damage typesChaosPoisonChancefor both hits and crits