Skip to content

Commit ba009a4

Browse files
committed
remove support of Snakemake v7
the minimum version for pathvars is 9.12
1 parent 7ed14e7 commit ba009a4

6 files changed

Lines changed: 9 additions & 59 deletions

File tree

.github/workflows/install.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
with:
1515
channel-priority: strict
1616
activate-environment: snakemake
17-
environment-file: .test/environment_v7.yaml
17+
environment-file: .test/environment_v9.yaml
1818
- name: Create environments
1919
shell: bash -el {0}
2020
run: snakemake --snakefile .test/Snakefile --configfile config/config.yaml .test/targets.yaml --conda-create-envs-only --use-conda -c1 --conda-frontend conda
@@ -29,7 +29,7 @@ jobs:
2929
with:
3030
channel-priority: strict
3131
activate-environment: snakemake
32-
environment-file: .test/environment_v7.yaml
32+
environment-file: .test/environment_v9.yaml
3333
- name: Dry run
3434
shell: bash -el {0}
3535
run: snakemake --snakefile .test/Snakefile --configfile config/config.yaml .test/targets.yaml --dry-run

.github/workflows/test_v7.yml

Lines changed: 0 additions & 39 deletions
This file was deleted.

.test/Snakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ from snakemake.utils import min_version
55
import subprocess
66

77

8-
min_version("7.19")
8+
min_version("9.12")
99

1010
# Workflow version
1111
__version__ = "test"

.test/environment_v7.yaml

Lines changed: 0 additions & 10 deletions
This file was deleted.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
[![Zenodo DOI](https://zenodo.org/badge/627797162.svg)](https://doi.org/10.5281/zenodo.15771867)
1111

1212
![Install workflow](https://github.com/PathoGenOmics-Lab/VIPERA/actions/workflows/install.yml/badge.svg)
13-
![Test workflow with Snakemake v7](https://github.com/PathoGenOmics-Lab/VIPERA/actions/workflows/test_v7.yml/badge.svg)
1413
![Test workflow with Snakemake v9](https://github.com/PathoGenOmics-Lab/VIPERA/actions/workflows/test_v9.yml/badge.svg)
1514
![Test workflow with Snakemake v9 and Apptainer](https://github.com/PathoGenOmics-Lab/VIPERA/actions/workflows/test_apptainer.yml/badge.svg)
1615

@@ -24,7 +23,7 @@ configuring [the inputs and outputs](config/README.md#inputs-and-outputs) and
2423
[the context dataset](config/README.md#automated-construction-of-a-context-dataset):
2524

2625
```shell
27-
snakemake --use-conda --cores 4 # command for Snakemake v7
26+
snakemake --sdm conda --cores 4
2827
```
2928

3029
We provide a simple script that downloads the [data](https://doi.org/10.20350/digitalCSIC/15648) from [our study](https://doi.org/10.1093/ve/veae018)
@@ -40,8 +39,9 @@ It supports dependency management through either conda or Apptainer/Singularity,
4039
[run modes documentation](config/README.md#run-modes).
4140

4241
We use continuous integration (CI) to automatically verify that all dependencies install correctly
43-
with Snakemake v7.32.4 (see GitHub Action `Install`), and to test that VIPERA runs
44-
successfully with Snakemake v7.32.4 and v9.15.0 using conda (Actions `Test Sm v(7|9)`).
42+
(see GitHub Action `Install`), and to test that VIPERA runs
43+
successfully using conda (Actions `Test Sm v(7|9)`).
44+
We run Snakemake v9.15.0 for these.
4545
We also test a containerized workflow with Snakemake v9.15.0 and Apptainer using a
4646
[remote image](https://hub.docker.com/r/ahmig/vipera) (Action `Test Sm v9 Apptainer`).
4747
This image is automatically updated in every version (Action `Deploy`).

config/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,10 @@ should be modified to fit your needs. Read more about Snakemake profiles
255255
[here](https://snakemake.readthedocs.io/en/stable/executing/cli.html#executing-profiles).
256256
To use the profile, install the
257257
[Snakemake executor plugin for SLURM](https://snakemake.github.io/snakemake-plugin-catalog/plugins/executor/slurm.html)
258-
and run one of the following commands:
258+
and run the following command:
259259

260260
```shell
261-
snakemake --slurm --profile profile/slurm # Snakemake v7
262-
snakemake --profile profile/slurm # Snakemake v8+
261+
snakemake --profile profile/slurm
263262
```
264263

265264
Additionally, we offer the option of running the workflow within a containerized

0 commit comments

Comments
 (0)