Commit 9fb8dd8
committed
Fix 4 bugs found in deep audit
BamViewer:
- B1: Count cards showed truncated read counts (max 80) instead of real
totals. Now uses view.counts from backend (all reads).
- B2: BamCell variant site coloring was case-sensitive — lowercase BAM
bases didn't match uppercase VCF alleles. Now uses toUpperCase().
Backend:
- B3: ensure_fasta_index silently wrote corrupt .fai for gzipped FASTA
(byte offsets meaningless in compressed files). Now returns error
asking user to decompress first.
App.tsx:
- B4: Ctrl/Cmd+Enter shortcut bypassed overwrite conflict check, going
directly to handleRunAll. Extracted shared triggerRun() function used
by both the button onClick and keyboard shortcut. Both now check for
existing files before running.1 parent 6a092ee commit 9fb8dd8
3 files changed
Lines changed: 49 additions & 41 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
609 | 609 | | |
610 | 610 | | |
611 | 611 | | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
612 | 639 | | |
613 | | - | |
614 | | - | |
615 | | - | |
| 640 | + | |
| 641 | + | |
616 | 642 | | |
617 | 643 | | |
618 | 644 | | |
619 | 645 | | |
620 | 646 | | |
621 | 647 | | |
622 | 648 | | |
623 | | - | |
624 | | - | |
625 | | - | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
626 | 652 | | |
627 | 653 | | |
628 | 654 | | |
| |||
834 | 860 | | |
835 | 861 | | |
836 | 862 | | |
837 | | - | |
838 | | - | |
839 | | - | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | | - | |
844 | | - | |
845 | | - | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
850 | | - | |
851 | | - | |
852 | | - | |
853 | | - | |
854 | | - | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
| 863 | + | |
863 | 864 | | |
864 | 865 | | |
865 | 866 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
| 236 | + | |
236 | 237 | | |
237 | 238 | | |
238 | 239 | | |
239 | 240 | | |
240 | | - | |
241 | | - | |
| 241 | + | |
| 242 | + | |
242 | 243 | | |
243 | 244 | | |
244 | 245 | | |
245 | 246 | | |
246 | | - | |
| 247 | + | |
247 | 248 | | |
248 | 249 | | |
249 | 250 | | |
| |||
507 | 508 | | |
508 | 509 | | |
509 | 510 | | |
510 | | - | |
| 511 | + | |
511 | 512 | | |
512 | 513 | | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
518 | 520 | | |
519 | 521 | | |
520 | 522 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
201 | 206 | | |
202 | 207 | | |
203 | 208 | | |
| |||
0 commit comments