Merge pull request #981 from SinZ163/optimization/mapedit-texturecopy

Pathoschild · web-flow · commit e2c780304b01 · 2025-07-12T22:41:04.000-04:00
Optimize map edits by skipping expensive tile index property copies
diff --git a/src/SMAPI/Framework/Content/AssetDataForMap.cs b/src/SMAPI/Framework/Content/AssetDataForMap.cs
@@ -90,8 +90,7 @@ public void PatchMap(Map source, Rectangle? sourceArea = null, Rectangle? target
 
                 // add tilesheet
                 targetSheet = new TileSheet(id, target, sourceSheet.ImageSource, sourceSheet.SheetSize, sourceSheet.TileSize);
-                for (int i = 0, tileCount = sourceSheet.TileCount; i < tileCount; ++i)
-                    targetSheet.TileIndexProperties[i].CopyFrom(sourceSheet.TileIndexProperties[i]);
+                targetSheet.Properties.CopyFrom(sourceSheet.Properties);
                 target.AddTileSheet(targetSheet);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,7 @@ public void PatchMap(Map source, Rectangle? sourceArea = null, Rectangle? target`
`90`	`90`
`91`	`91`	`// add tilesheet`
`92`	`92`	`targetSheet = new TileSheet(id, target, sourceSheet.ImageSource, sourceSheet.SheetSize, sourceSheet.TileSize);`
`93`		`- for (int i = 0, tileCount = sourceSheet.TileCount; i < tileCount; ++i)`
`94`		`- targetSheet.TileIndexProperties[i].CopyFrom(sourceSheet.TileIndexProperties[i]);`
	`93`	`+ targetSheet.Properties.CopyFrom(sourceSheet.Properties);`
`95`	`94`	`target.AddTileSheet(targetSheet);`
`96`	`95`	`}`
`97`	`96`