Fix truncated state variables and warped box issues#89
Open
SIDDHARTH1-1CHAUHAN wants to merge 1 commit into
Open
Fix truncated state variables and warped box issues#89SIDDHARTH1-1CHAUHAN wants to merge 1 commit into
SIDDHARTH1-1CHAUHAN wants to merge 1 commit into
Conversation
This commit addresses two visual rendering bugs: Issue PathwayCommons#88: State variables were getting truncated when labels were long. The stadium shape was using max(width, height) * 0.24 for corner radius, which caused issues when width became much larger than height. Changed to use height/2 for proper semicircular ends. Issue PathwayCommons#80: Long node labels were causing boxes to appear warped. Added text-wrap property to enable multi-line labels within fixed node boundaries, maintaining proper SBGN glyph dimensions. Fixes PathwayCommons#88 Fixes PathwayCommons#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two visual rendering bugs:
Issue #88: State variables were getting truncated when labels were long. The stadium shape was using max(width, height) * 0.24 for corner radius, which caused issues when width became much larger than height. Changed to use height/2 for proper semicircular ends.
Issue #80: Long node labels were causing boxes to appear warped. Added text-wrap property to enable multi-line labels within fixed node boundaries, maintaining proper SBGN glyph dimensions.
Fixes #88
Fixes #80
By: Siddharth Chauhan