Skip to content

Commit 170758f

Browse files
committed
fix(embeddings): address code review feedback - remove eager export, fix OLLAMA_HOST, add embeddinggemma
1 parent 7659c02 commit 170758f

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/embeddings/index.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ export function getConfiguredDimensions(config: Partial<EmbeddingConfig> = {}):
3434
const ollamaDimensions: Record<string, number> = {
3535
'nomic-embed-text': 768,
3636
'nomic-embed-text:latest': 768,
37+
embeddinggemma: 768,
38+
'embeddinggemma:latest': 768,
3739
'mxbai-embed-large': 1024,
3840
'mxbai-embed-large:latest': 1024,
3941
'all-minilm': 384,
@@ -73,9 +75,11 @@ export async function getEmbeddingProvider(
7375

7476
if (mergedConfig.provider === 'ollama') {
7577
const { OllamaEmbeddingProvider } = await import('./ollama.js');
78+
const endpoint =
79+
mergedConfig.apiEndpoint || process.env.OLLAMA_HOST || 'http://localhost:11434';
7680
const provider = new OllamaEmbeddingProvider(
7781
mergedConfig.model || 'nomic-embed-text',
78-
mergedConfig.apiEndpoint || 'http://localhost:11434'
82+
endpoint
7983
);
8084
await provider.initialize();
8185
cachedProvider = provider;
@@ -93,6 +97,6 @@ export async function getEmbeddingProvider(
9397
return provider;
9498
}
9599

96-
// Re-export TransformersEmbeddingProvider and MODEL_CONFIGS for consumers who need them
97-
// These will trigger transformers loading, but only when explicitly imported
98-
export { TransformersEmbeddingProvider, MODEL_CONFIGS } from './transformers.js';
100+
// Note: transformers provider is lazy-loaded in getEmbeddingProvider to avoid
101+
// eager heavy dependency loading. Consumers should import from './transformers'
102+
// directly if they need access to provider implementation or MODEL_CONFIGS.

src/embeddings/ollama.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ interface OllamaEmbeddingResponse {
88
const MODEL_CONTEXT_WINDOWS: Record<string, number> = {
99
'nomic-embed-text': 2048,
1010
'nomic-embed-text:latest': 2048,
11+
embeddinggemma: 2048,
12+
'embeddinggemma:latest': 2048,
1113
'mxbai-embed-large': 512,
1214
'mxbai-embed-large:latest': 512,
1315
'all-minilm': 512,
@@ -37,6 +39,8 @@ export class OllamaEmbeddingProvider implements EmbeddingProvider {
3739
const modelDimensions: Record<string, number> = {
3840
'nomic-embed-text': 768,
3941
'nomic-embed-text:latest': 768,
42+
embeddinggemma: 768,
43+
'embeddinggemma:latest': 768,
4044
'mxbai-embed-large': 1024,
4145
'mxbai-embed-large:latest': 1024,
4246
'all-minilm': 384,

0 commit comments

Comments
 (0)