fix(watcher-tests): await ready + harden Windows cleanup

Author: PatrickSys

src/core/file-watcher.ts

@@ -6,6 +6,8 @@ export interface FileWatcherOptions {
   rootPath: string;
   /** ms after last change before triggering. Default: 2000 */
   debounceMs?: number;
+  /** Called once chokidar finishes initial scan and starts emitting change events */
+  onReady?: () => void;
   /** Called once the debounce window expires after the last detected change */
   onChanged: () => void;
 }
@@ -28,7 +30,7 @@ function isTrackedSourcePath(filePath: string): boolean {
  * Returns a stop() function that cancels the debounce timer and closes the watcher.
  */
 export function startFileWatcher(opts: FileWatcherOptions): () => void {
-  const { rootPath, debounceMs = 2000, onChanged } = opts;
+  const { rootPath, debounceMs = 2000, onReady, onChanged } = opts;
   let debounceTimer: ReturnType<typeof setTimeout> | undefined;
 
   const trigger = (filePath: string) => {
@@ -59,6 +61,7 @@ export function startFileWatcher(opts: FileWatcherOptions): () => void {
   });
 
   watcher
+    .on('ready', () => onReady?.())
     .on('add', trigger)
     .on('change', trigger)
     .on('unlink', trigger)

tests/auto-refresh-e2e.test.ts

@@ -111,9 +111,15 @@ describe('Auto-refresh E2E', () => {
       }
     };
 
+    let resolveReady!: () => void;
+    const watcherReady = new Promise<void>((resolve) => {
+      resolveReady = resolve;
+    });
+
     const stopWatcher = startFileWatcher({
       rootPath: tempDir,
       debounceMs: 200,
+      onReady: () => resolveReady(),
       onChanged: () => {
         const shouldRunNow = autoRefresh.onFileChange(indexStatus === 'indexing');
         if (!shouldRunNow) return;
@@ -123,7 +129,7 @@ describe('Auto-refresh E2E', () => {
     });
 
     try {
-      await sleep(250);
+      await watcherReady;
       await fs.writeFile(path.join(tempDir, 'src', 'app.ts'), 'export const token = "UPDATED_TOKEN";\n');
 
       await waitFor(

tests/file-watcher.test.ts

@@ -19,15 +19,20 @@ describe('FileWatcher', () => {
     const debounceMs = 400;
     let callCount = 0;
 
+    let resolveReady!: () => void;
+    const ready = new Promise<void>((resolve) => {
+      resolveReady = resolve;
+    });
+
     const stop = startFileWatcher({
       rootPath: tempDir,
       debounceMs,
+      onReady: () => resolveReady(),
       onChanged: () => { callCount++; },
     });
 
     try {
-      // Give chokidar a moment to finish initializing before the first write
-      await new Promise((resolve) => setTimeout(resolve, 100));
+      await ready;
       await fs.writeFile(path.join(tempDir, 'test.ts'), 'export const x = 1;');
       // Wait for chokidar to pick up the event (including awaitWriteFinish stabilityThreshold)
       // + debounce window + OS scheduling slack
@@ -39,25 +44,31 @@ describe('FileWatcher', () => {
   }, 8000);
 
   it('debounces rapid changes into a single callback', async () => {
-    const debounceMs = 300;
+    const debounceMs = 800;
     let callCount = 0;
 
+    let resolveReady!: () => void;
+    const ready = new Promise<void>((resolve) => {
+      resolveReady = resolve;
+    });
+
     const stop = startFileWatcher({
       rootPath: tempDir,
       debounceMs,
+      onReady: () => resolveReady(),
       onChanged: () => { callCount++; },
     });
 
     try {
       // Give chokidar a moment to finish initializing before the first write
-      await new Promise((resolve) => setTimeout(resolve, 100));
+      await ready;
       // Write 5 files in quick succession — all within the debounce window
       for (let i = 0; i < 5; i++) {
         await fs.writeFile(path.join(tempDir, `file${i}.ts`), `export const x${i} = ${i};`);
-        await new Promise((resolve) => setTimeout(resolve, 50));
+        await new Promise((resolve) => setTimeout(resolve, 20));
       }
       // Wait for debounce to settle
-      await new Promise((resolve) => setTimeout(resolve, debounceMs + 400));
+      await new Promise((resolve) => setTimeout(resolve, debounceMs + 1200));
       expect(callCount).toBe(1);
     } finally {
       stop();
@@ -68,14 +79,20 @@ describe('FileWatcher', () => {
     const debounceMs = 500;
     let callCount = 0;
 
+    let resolveReady!: () => void;
+    const ready = new Promise<void>((resolve) => {
+      resolveReady = resolve;
+    });
+
     const stop = startFileWatcher({
       rootPath: tempDir,
       debounceMs,
+      onReady: () => resolveReady(),
       onChanged: () => { callCount++; },
     });
 
     // Give chokidar a moment to finish initializing before the first write
-    await new Promise((resolve) => setTimeout(resolve, 100));
+    await ready;
     await fs.writeFile(path.join(tempDir, 'cancel.ts'), 'export const y = 99;');
     // Let chokidar detect the event (including awaitWriteFinish stabilityThreshold)
     // but stop before the debounce window expires.
@@ -90,16 +107,22 @@ describe('FileWatcher', () => {
     const debounceMs = 250;
     let callCount = 0;
 
+    let resolveReady!: () => void;
+    const ready = new Promise<void>((resolve) => {
+      resolveReady = resolve;
+    });
+
     const stop = startFileWatcher({
       rootPath: tempDir,
       debounceMs,
+      onReady: () => resolveReady(),
       onChanged: () => {
         callCount++;
       }
     });
 
     try {
-      await new Promise((resolve) => setTimeout(resolve, 100));
+      await ready;
       await fs.writeFile(path.join(tempDir, 'notes.txt'), 'this should be ignored');
       await new Promise((resolve) => setTimeout(resolve, debounceMs + 700));
       expect(callCount).toBe(0);
@@ -112,16 +135,22 @@ describe('FileWatcher', () => {
     const debounceMs = 250;
     let callCount = 0;
 
+    let resolveReady!: () => void;
+    const ready = new Promise<void>((resolve) => {
+      resolveReady = resolve;
+    });
+
     const stop = startFileWatcher({
       rootPath: tempDir,
       debounceMs,
+      onReady: () => resolveReady(),
       onChanged: () => {
         callCount++;
       }
     });
 
     try {
-      await new Promise((resolve) => setTimeout(resolve, 100));
+      await ready;
       await fs.writeFile(path.join(tempDir, '.gitignore'), 'dist/\n');
       await new Promise((resolve) => setTimeout(resolve, debounceMs + 700));
       expect(callCount).toBe(1);

tests/impact-2hop.test.ts

@@ -1,5 +1,6 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
+import os from 'os';
 import path from 'path';
 import { CodebaseIndexer } from '../src/core/indexer.js';
 import { dispatchTool } from '../src/tools/index.js';
@@ -17,9 +18,26 @@ describe('Impact candidates (2-hop)', () => {
   let tempRoot: string | null = null;
   const token = 'UNIQUETOKEN123';
 
+  async function rmWithRetries(targetPath: string): Promise<void> {
+    const maxAttempts = 8;
+    let delayMs = 25;
+
+    for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+      try {
+        await fs.rm(targetPath, { recursive: true, force: true });
+        return;
+      } catch (error) {
+        const code = (error as { code?: string }).code;
+        const retryable = code === 'ENOTEMPTY' || code === 'EPERM' || code === 'EBUSY';
+        if (!retryable || attempt === maxAttempts) throw error;
+        await new Promise((r) => setTimeout(r, delayMs));
+        delayMs *= 2;
+      }
+    }
+  }
+
   beforeEach(async () => {
-    // Keep test artifacts under CWD (mirrors other indexer tests and avoids OS tmp quirks)
-    tempRoot = await fs.mkdtemp(path.join(process.cwd(), '.tmp-impact-2hop-'));
+    tempRoot = await fs.mkdtemp(path.join(os.tmpdir(), 'impact-2hop-'));
     const srcDir = path.join(tempRoot, 'src');
     await fs.mkdir(srcDir, { recursive: true });
     await fs.writeFile(path.join(tempRoot, 'package.json'), JSON.stringify({ name: 'impact-2hop' }));
@@ -40,7 +58,7 @@ describe('Impact candidates (2-hop)', () => {
 
   afterEach(async () => {
     if (tempRoot) {
-      await fs.rm(tempRoot, { recursive: true, force: true });
+      await rmWithRetries(tempRoot);
       tempRoot = null;
     }
   });

tests/search-snippets.test.ts

@@ -7,6 +7,24 @@ import { CodebaseIndexer } from '../src/core/indexer.js';
 describe('Search Snippets with Scope Headers', () => {
   let tempRoot: string | null = null;
 
+  async function rmWithRetries(targetPath: string): Promise<void> {
+    const maxAttempts = 8;
+    let delayMs = 25;
+
+    for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+      try {
+        await fs.rm(targetPath, { recursive: true, force: true });
+        return;
+      } catch (error) {
+        const code = (error as { code?: string }).code;
+        const retryable = code === 'ENOTEMPTY' || code === 'EPERM' || code === 'EBUSY';
+        if (!retryable || attempt === maxAttempts) throw error;
+        await new Promise((r) => setTimeout(r, delayMs));
+        delayMs *= 2;
+      }
+    }
+  }
+
   beforeEach(async () => {
     vi.resetModules();
     tempRoot = await fs.mkdtemp(path.join(os.tmpdir(), 'search-snippets-test-'));
@@ -91,15 +109,15 @@ export const VERSION = '1.0.0';
       config: { skipEmbedding: true }
     });
     await indexer.index();
-  });
+  }, 30000);
 
   afterEach(async () => {
     if (tempRoot) {
-      await fs.rm(tempRoot, { recursive: true, force: true });
+      await rmWithRetries(tempRoot);
       tempRoot = null;
     }
     delete process.env.CODEBASE_ROOT;
-  });
+  }, 30000);
 
   it('returns snippets when includeSnippets=true', async () => {
     if (!tempRoot) throw new Error('tempRoot not initialized');