fix: address analyzer hint review feedback

Author: PatrickSys

src/core/indexer.ts

@@ -21,7 +21,11 @@ import {
 } from '../types/index.js';
 import { analyzerRegistry } from './analyzer-registry.js';
 import type { AnalyzerSelectionOptions } from './analyzer-registry.js';
-import { isCodeFile, isBinaryFile } from '../utils/language-detection.js';
+import {
+  getSupportedExtensions,
+  isBinaryFile,
+  isCodeFile
+} from '../utils/language-detection.js';
 import {
   getEmbeddingProvider,
   getConfiguredDimensions,
@@ -227,6 +231,7 @@ export class CodebaseIndexer {
   private rootPath: string;
   private config: CodebaseConfig;
   private projectOptions: AnalyzerSelectionOptions;
+  private supportedCodeExtensions: Set<string>;
   private progress: IndexingProgress;
   private onProgressCallback?: (progress: IndexingProgress) => void;
   private incrementalOnly: boolean;
@@ -238,6 +243,11 @@ export class CodebaseIndexer {
       preferredAnalyzer: options.projectOptions?.preferredAnalyzer,
       extraFileExtensions: options.projectOptions?.extraFileExtensions
     };
+    this.supportedCodeExtensions = new Set(
+      getSupportedExtensions(this.projectOptions.extraFileExtensions).map((extension) =>
+        extension.toLowerCase()
+      )
+    );
     this.onProgressCallback = options.onProgress;
     this.incrementalOnly = options.incrementalOnly ?? false;
 
@@ -1101,7 +1111,7 @@ export class CodebaseIndexer {
         }
 
         // Check if it's a code file
-        if (!isCodeFile(file, this.projectOptions.extraFileExtensions) || isBinaryFile(file)) {
+        if (!isCodeFile(file, this.supportedCodeExtensions) || isBinaryFile(file)) {
           continue;
         }
 

src/utils/language-detection.ts

@@ -187,9 +187,14 @@ export function detectLanguage(filePath: string): string {
 /**
  * Check if a file is a code file
  */
-export function isCodeFile(filePath: string, extraExtensions?: Iterable<string>): boolean {
+export function isCodeFile(
+  filePath: string,
+  extensions?: Iterable<string> | ReadonlySet<string>
+): boolean {
   const ext = path.extname(filePath).toLowerCase();
-  return buildCodeExtensions(extraExtensions).has(ext);
+  const supportedExtensions =
+    extensions instanceof Set ? extensions : buildCodeExtensions(extensions);
+  return supportedExtensions.has(ext);
 }
 
 /**

tests/mcp-client-templates.test.ts

@@ -60,6 +60,8 @@ describe('templates/mcp/http/.mcp.json', () => {
       mcpServers: Record<string, unknown>;
     };
     expect(config.mcpServers).toHaveProperty('codebase-context');
+  });
+
   it('server entry points to the local HTTP endpoint', () => {
     const config = readJson('templates/mcp/http/.mcp.json') as {
       mcpServers: Record<string, { url?: string; type?: string }>;
@@ -68,9 +70,6 @@ describe('templates/mcp/http/.mcp.json', () => {
     expect(entry.url).toBe('http://127.0.0.1:3100/mcp');
     expect(entry.type).toBe('http');
   });
-    const entry = config.mcpServers['codebase-context'];
-    expect(entry.url).toBe('http://127.0.0.1:3100/mcp');
-  });
 });
 
 // ---------------------------------------------------------------------------