-
Notifications
You must be signed in to change notification settings - Fork 10
fix: close v1.8 post-merge integration gaps #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -439,12 +439,18 @@ export async function handle( | |
| // Compose preflight card for edit/refactor/migrate intents | ||
| let preflight: any = undefined; | ||
| const preflightIntents = ['edit', 'refactor', 'migrate']; | ||
| if (intent && preflightIntents.includes(intent) && intelligence) { | ||
| try { | ||
| // --- Avoid / Prefer patterns --- | ||
| const avoidPatternsList: any[] = []; | ||
| const preferredPatternsList: any[] = []; | ||
| const patterns = intelligence.patterns || {}; | ||
| if (intent && preflightIntents.includes(intent)) { | ||
| if (!intelligence) { | ||
| preflight = { | ||
| ready: false, | ||
| nextAction: 'Run a full index rebuild to generate pattern intelligence before editing.' | ||
| }; | ||
| } else { | ||
|
Comment on lines
+442
to
+448
|
||
| try { | ||
| // --- Avoid / Prefer patterns --- | ||
| const avoidPatternsList: any[] = []; | ||
| const preferredPatternsList: any[] = []; | ||
| const patterns = intelligence.patterns || {}; | ||
| for (const [category, data] of Object.entries<any>(patterns)) { | ||
| // Primary pattern = preferred if Rising or Stable | ||
| if (data.primary) { | ||
|
|
@@ -658,8 +664,9 @@ export async function handle( | |
| } | ||
|
|
||
| preflight = decisionCard; | ||
| } catch { | ||
| // Preflight construction failed — skip preflight, don't fail the search | ||
| } catch { | ||
| // Preflight construction failed — skip preflight, don't fail the search | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new fallback
preflightobject appears to be a different shape than the normaldecisionCardassigned later (preflight = decisionCard). If downstream consumers/UI expect a consistent preflight card schema, this can cause rendering/handling inconsistencies. Consider returning a fallback object that matches the same card/schema (e.g., same top-level fields asdecisionCard) while still conveyingready: falseand the rebuild guidance.