Merge pull request #235 from PaulJPhilp/codex/pr-3-remove-tier-references

Remove tier references and enforcement from MCP server

Author: PaulJPhilp

packages/mcp-server/ENV_VARS.md

@@ -16,7 +16,6 @@ Complete reference for all environment variables used across different test conf
 | `EFFECT_PATTERNS_API_URL` | ❌ | ❌ | Optional | Optional | Optional | ❌ | ❌ | http://localhost:3000 | API server URL |
 | `KV_REST_API_URL` | ❌ | Optional | ❌ | Optional | Optional | ❌ | ❌ | (disabled) | Vercel KV endpoint |
 | `KV_REST_API_TOKEN` | ❌ | Optional | ❌ | Optional | Optional | ❌ | ❌ | (disabled) | Vercel KV token |
-| `TIER_MODE` | ❌ | Optional | ❌ | Optional | Optional | ❌ | ❌ | "free" | User tier for testing |
 | `MCP_DEBUG` | ❌ | ❌ | Optional | ❌ | ❌ | ❌ | ❌ | false | Enable MCP debug logs |
 | `MCP_ENV` | ❌ | ❌ | Optional | ❌ | ❌ | ❌ | ❌ | "production" | MCP environment |
 | `DEBUG_TESTS` | Optional | ❌ | ❌ | ❌ | ❌ | ❌ | ❌ | false | Enable test debugging |
@@ -198,33 +197,6 @@ KV_REST_API_TOKEN=""
 
 ---
 
-### Tier/Feature Configuration
-
-#### `TIER_MODE`
-**Type:** Enum ("free" | "pro")
-**Required for:** None (optional)
-**Default:** "free"
-**Used by:** Routes, Integration, Workflow tests
-**Purpose:** Test different tier-based functionality
-
-**Usage:**
-```bash
-# Test free tier features (default)
-bun run test:routes
-
-# Test pro tier features
-TIER_MODE=pro bun run test:routes
-
-# Test both
-TIER_MODE=free bun run test:routes && TIER_MODE=pro bun run test:routes
-```
-
-**What's tested:**
-- Free tier: Limited to 3 recommendations, search-only
-- Pro tier: Full feature access, code generation
-
----
-
 ### Debug Configuration
 
 #### `MCP_DEBUG`
@@ -321,7 +293,6 @@ Sets up common test environment variables.
 - `DATABASE_URL` - PostgreSQL connection
 - `KV_REST_API_URL` - Vercel KV (disabled if not set)
 - `KV_REST_API_TOKEN` - Vercel KV (disabled if not set)
-- `TIER_MODE` - Default to "free"
 - `PATTERN_API_KEY` - Optional, from environment
 
 **Used by:**

packages/mcp-server/MCP-README.md

@@ -62,7 +62,6 @@ A Model Context Protocol (MCP) server that provides Effect-TS patterns, code ana
 | `PATTERN_API_KEY` | Authentication key | Required |
 | `PRODUCTION_API_KEY` | Production API key (for `mcp:production`) | Use `PATTERN_API_KEY` if unset |
 | `DATABASE_URL` | PostgreSQL connection | Auto-configured |
-| `TIER_MODE` | Service tier (`free`/`paid`) | `free` |
 | `NODE_ENV` | Environment mode | `development` |
 
 ### Claude Code Configuration
@@ -88,14 +87,14 @@ Set `PRODUCTION_API_KEY` via your environment or secrets.
 
 ### Available Tools
 
-The MCP server exposes the free-tier tool surface only:
+The MCP server exposes the MCP tool surface only:
 - `search_patterns`
 - `get_pattern`
 - `list_analysis_rules`
 - `analyze_code`
 - `review_code`
 
-Paid-tier features are available via the HTTP API only (not exposed as MCP tools).
+Additional analysis/refactoring endpoints are available via the HTTP API only (not exposed as MCP tools).
 
 #### 🔍 `search_patterns`
 
@@ -339,25 +338,14 @@ Create `.env.local`:
 ```env
 PATTERN_API_KEY=dev-key
 DATABASE_URL=postgresql://postgres:postgres@127.0.0.1:5432/effect_patterns
-TIER_MODE=free
 NODE_ENV=development
 ```
 
-## 📊 Service Tiers
+## 📊 Capability Model
 
-### Free Tier (Default)
-
-- **Code Review**: Top 3 architectural recommendations
-- **Pattern Search**: Full access to pattern library
-- **Analysis**: Basic rule-based analysis
-- **Rate Limit**: 100 requests per 15 minutes
-
-### Pro Tier (Coming Soon)
-
-- **Code Review**: Unlimited recommendations
-- **Enhanced Analysis**: AI-powered insights
-- **Custom Patterns**: Organization-specific patterns
-- **Priority Support**: Dedicated assistance
+- **MCP tool surface**: Pattern search, pattern retrieval, and analysis-rule catalog.
+- **HTTP API / CLI surface**: Analysis, review, refactoring, and generation endpoints.
+- **Operational limits**: Standard rate limits apply per API key.
 
 ## 🐛 Troubleshooting
 
@@ -387,9 +375,9 @@ curl -H "x-api-key: YOUR_KEY" https://effect-patterns-mcp.vercel.app/api/pattern
 
 #### Performance Issues
 
-- Use free tier within rate limits
+- Use the standard rate limits for your API key
 - Optimize search queries with specific filters
-- Consider Pro tier for higher limits
+- Use direct HTTP API endpoints for non-MCP features
 
 ### Debug Mode
 

packages/mcp-server/README-END-USER.md

@@ -128,7 +128,7 @@ Never commit API keys; use environment variables or your IDE's secret storage.
 
 ---
 
-## MCP Tools (Free Tier)
+## MCP Tools
 
 The MCP server exposes **exactly five tools** in production and staging. No other tools (including code analysis or review) are available via MCP.
 
@@ -178,6 +178,27 @@ No parameters.
 - "List all analysis rules."
 - "What rules does the analyzer use?"
 
+---
+
+### 4. `list_skills`
+
+Search Effect-TS skills by query and optional category.
+
+| Parameter | Type | Required | Description |
+|-----------|------|----------|-------------|
+| `q` | string | No | Search query string. |
+| `category` | string | No | Skill category filter. |
+| `limit` | number | No | Maximum results (1–100). |
+| `format` | string | No | `markdown`, `json`, or `both`. |
+
+### 5. `get_skill`
+
+Get full details for one skill by slug.
+
+| Parameter | Type | Required | Description |
+|-----------|------|----------|-------------|
+| `slug` | string | Yes | Skill slug identifier. |
+
 **Debug / local only:** The tool `get_mcp_config` is not part of the default production/staging surface; it only appears when `MCP_DEBUG=true` or `MCP_ENV=local`.
 
 ---
@@ -216,23 +237,25 @@ Get full details for a specific skill by slug, including full guidance content.
 
 ## HTTP API
 
-When you use the **hosted** server, the MCP server forwards tool calls to the HTTP API for patterns and rules only. You can also call the API directly (e.g. from scripts or CI) with the same API key. **MCP tools do not call paid endpoints** — analysis, review, refactoring, and generation are available only when using the HTTP API or paid CLI directly.
+When you use the **hosted** server, the MCP server forwards tool calls to the HTTP API for patterns and rules only. You can also call the API directly (e.g. from scripts or CI) with the same API key. **MCP tools do not call analysis/refactoring/generation endpoints** — those are available only when using the HTTP API or CLI directly.
 
 - **Auth:** `x-api-key: <PATTERN_API_KEY>` on requests (or query param in some setups).
 - **Base URLs:** Production: `https://effect-patterns-mcp.vercel.app`; Staging: `https://effect-patterns-mcp-staging.vercel.app`.
 
 ### Endpoints (summary)
 
-**Free (used by MCP tools):**
+**Used by MCP tools:**
 
 | Method | Path | Purpose |
 |--------|------|---------|
 | GET | `/api/health` | Health check (no auth). |
 | GET | `/api/patterns` | Search patterns (query params: `q`, `category`, `difficulty`, `limit`). |
 | GET | `/api/patterns/[id]` | Get pattern by ID. |
+| GET | `/api/skills` | List/search skills (`q`, `category`, `limit`). |
+| GET | `/api/skills/[slug]` | Get skill by slug. |
 | POST | `/api/list-rules` | List rules metadata (read-only catalog). |
 
-**Paid (HTTP API / CLI only — not exposed via MCP):**
+**HTTP API / CLI only (not exposed via MCP):**
 
 | Method | Path | Purpose |
 |--------|------|---------|
@@ -248,10 +271,15 @@ Full request/response shapes: see [MCP Server API Reference](../../docs/mcp-serv
 
 ---
 
-## Service Tiers
+## Capability Boundaries
 
+<<<<<<< codex/pr-3-remove-tier-references
+- **MCP surface:** Patterns and rule catalog only — `search_patterns`, `get_pattern`, `list_analysis_rules`. Rate limits apply (e.g. 100 requests per 15 minutes per key). MCP does not call analysis/refactoring/generation endpoints.
+- **HTTP API / CLI surface:** Code analysis, code review, consistency analysis, apply refactoring, and generate pattern code.
+=======
 - **MCP (free):** Patterns, skills, and rule catalog — `search_patterns`, `get_pattern`, `list_analysis_rules`, `list_skills`, `get_skill`. Rate limits apply (e.g. 100 requests per 15 minutes per key). MCP cannot call paid endpoints.
 - **Paid (HTTP API / CLI only):** Code analysis, code review, consistency analysis, apply refactoring, generate pattern code, and higher limits. Use the HTTP API or paid CLI; these capabilities are not available via MCP.
+>>>>>>> main
 
 ---
 
@@ -278,7 +306,7 @@ Full request/response shapes: see [MCP Server API Reference](../../docs/mcp-serv
 
 - **Backend not running:** If using local API, ensure `bun run dev` is running in `packages/mcp-server` and the API is at `http://localhost:3000`.
 - **Wrong URL:** If using hosted, set `EFFECT_PATTERNS_API_URL` to `https://effect-patterns-mcp.vercel.app` (or staging).
-- **Auth:** 401/402 usually mean invalid or missing API key. Check the key and that it's passed to the process that runs the MCP server.
+- **Auth:** 401/403 usually mean invalid or missing API key. Check the key and that it's passed to the process that runs the MCP server.
 
 ### Debugging
 

packages/mcp-server/README-LOCAL.md

@@ -43,9 +43,6 @@ Edit `.env` with your settings:
 # API Security - Generate a secure key
 PATTERN_API_KEY=your-secret-api-key-here
 
-# Tier Configuration
-TIER_MODE=free  # or "paid" for full features
-
 # Database Connection
 DATABASE_URL=postgresql://postgres:postgres@127.0.0.1:5432/effect_patterns
 
@@ -105,49 +102,28 @@ The MCP server has two components:
 
 ### 1. HTTP API Server (port 3000)
 
-Test tier validation:
+Test key endpoints:
 
 ```bash
-# Free tier - should return 402 for paid features
+# Generate code from a pattern
 curl -X POST http://localhost:3000/api/generate \
   -H "x-api-key: your-api-key" \
   -H "Content-Type: application/json" \
   -d '{"patternId": "use-pipe-for-composition", "name": "myFunction"}'
 
-# Free tier features - should work
+# Pattern search
 curl http://localhost:3000/api/patterns \
   -H "x-api-key: your-api-key"
 ```
 
-## Tier Configuration
-
-### Free Tier (Default)
-- **Available**: Pattern search, pattern retrieval
-- **Blocked**: Code generation, refactoring, advanced analysis
-- **MCP Tools**: `search_patterns`, `get_pattern`, `list_analysis_rules`, `analyze_code`, `review_code`
-
-### Paid Tier
-- **Available**: All features
-- **MCP Tools**: Free-tier surface only (paid tools are HTTP API only)
-
-Switch tiers by setting `TIER_MODE`:
-
-```bash
-# Free tier
-TIER_MODE=free bun run dev
-
-# Paid tier
-TIER_MODE=paid bun run dev
-```
-
 ## API Endpoints
 
-### Free Tier Available
+### Core Endpoints
 - `GET /api/patterns` - List all patterns
 - `GET /api/patterns/[id]` - Get specific pattern
 - `GET /api/health` - Health check
 
-### Paid Tier Only
+### Extended Endpoints
 - `POST /api/generate` - Generate code from pattern
 - `POST /api/generate-pattern` - Generate custom pattern
 - `POST /api/analyze-consistency` - Analyze code consistency
@@ -209,7 +185,6 @@ bun run build
 
 | Variable | Default | Description |
 |----------|---------|-------------|
-| `TIER_MODE` | `free` | Server tier: `free` or `paid` |
 | `PORT` | `3000` | Server port |
 | `NODE_ENV` | `development` | Environment mode |
 | `DATABASE_URL` | - | PostgreSQL connection string |
@@ -221,11 +196,9 @@ bun run build
 1. **Start**: `bun run dev`
 2. **Test**: Use curl or API client to test endpoints
 3. **Debug**: Check server logs and error responses
-4. **Switch Tiers**: Change `TIER_MODE` and restart
 
 ## Next Steps
 
 - Configure your IDE to use the MCP server
-- Test with different tier modes
 - Explore the API documentation
 - Contribute to the project!

packages/mcp-server/README.md

@@ -28,8 +28,8 @@ A comprehensive MCP 2.0 server and HTTP API for the Effect Patterns ecosystem, p
 - **Consistency Analysis**: Cross-file pattern consistency checking
 - **Enterprise Features**: Rate limiting, caching, metrics, tracing, and comprehensive logging
 
-**Free Tier Features**: Pattern search, basic code analysis, and MCP tools
-**Paid Tier Features**: Advanced code generation, consistency analysis, and automated refactoring (HTTP API only)
+**MCP Tool Surface**: Pattern search and rule catalog
+**HTTP API / CLI Surface**: Code analysis, generation, consistency analysis, and automated refactoring
 
 ## 📋 MCP Tools Available
 
@@ -413,7 +413,7 @@ guidance (low severity).
 }
 ```
 
-#### Review Code (Free Tier)
+#### Review Code
 
 ```http
 POST /api/review-code
@@ -428,7 +428,7 @@ Content-Type: application/json
 Get high-fidelity architectural recommendations for Effect codebases.
 Returns the top 3 highest-priority issues with actionable guidance.
 
-**Free Tier Features:**
+**Response Characteristics:**
 
 - Top 3 recommendations per request (sorted by severity, then line number)
 - Unlimited queries
@@ -482,7 +482,7 @@ Returns the top 3 highest-priority issues with actionable guidance.
 }
 ```
 
-#### Analyze Consistency (Pro Tier)
+#### Analyze Consistency
 
 ```http
 POST /api/analyze-consistency
@@ -521,7 +521,7 @@ Detect code inconsistencies across multiple files.
 }
 ```
 
-#### Apply Refactoring (Pro Tier)
+#### Apply Refactoring
 
 ```http
 POST /api/apply-refactoring
@@ -860,7 +860,7 @@ sequenceDiagram
     MCP->>Response: Build rich response
     Response->>API: Formatted findings
     API->>Client: Analysis report
-    %% Code Review Flow (Pro Tier)
+    %% Code Review Flow
     Client->>API: POST /api/review-code
     Note over API: API Key Auth
     API->>Services: ReviewCodeService.review()
@@ -869,7 +869,7 @@ sequenceDiagram
     Services->>DB: Store review metrics
     Services->>API: Top 3 issues + capability message
     API->>Client: Review results
-    %% Refactoring Flow (Pro Tier)
+    %% Refactoring Flow
     Client->>API: POST /api/apply-refactoring
     API->>Services: RefactoringEngineService.apply()
     Services->>Analysis: AST transformation

packages/mcp-server/TESTING_GUIDE.md

@@ -184,9 +184,6 @@ DATABASE_URL="postgres://user:password@localhost:5432/test_db"
 # Optional - disables Vercel KV
 KV_REST_API_URL=""
 KV_REST_API_TOKEN=""
-
-# Optional - test tier mode
-TIER_MODE=free  # or 'pro'
 ```
 
 #### MCP Tests (vitest.mcp.config.ts)