refactor: Code quality remediation for ep-cli and ep-admin

ep-cli fixes:
- Fix version mismatch (constants.ts VERSION synced to package.json)
- Migrate Install service from Context.GenericTag to Effect.Service pattern
- Fix addFinalizer scope issue with Effect.scoped in pattern-repo-commands
- Add Schema.decodeUnknown validation for JSON parsing in Install service
- Remove dead require("effect-cli-tui") code and getTUISpinner from execution helpers
- Create src/errors.ts with tagged error types (LintFailedError, etc.)
- Consolidate colorize into utils.ts with NO_COLOR support
- Convert skills-commands.ts from tabs to 2-space indentation
- Replace forEach with for...of in linter service
- Add readonly to linter types, fix TUIModule type, remove unused exports
- Fix mutating .sort() in skill-generator.ts
- Remove no-op validate-env.ts and unused TUI adapter files

ep-admin fixes:
- Fix version mismatch (constants.ts VERSION synced to package.json)
- Remove dead require("effect-cli-tui") and getTUISpinner from execution helpers
- Rewire Execution service to use TUIService instead of dead getTUISpinner
- Add NO_COLOR support to colorize in utils.ts
- Replace deprecated colors/levelColors re-exports with direct ANSI_COLORS imports
- Fix forEach in display service, TUIModule type, @ts-ignore in autofix service
- Remove unused EpAdminTUIAdapter and EpAdminExecutionTUIAdapter exports
- Fix mutating .sort() in skill-generator.ts
- Update tests and production runtime for TUIService dependency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: PaulJPhilp

packages/ep-admin/src/constants.ts

@@ -11,7 +11,7 @@
 
 export const CLI = {
 	NAME: "ep-admin",
-	VERSION: "0.4.1",
+	VERSION: "0.2.0",
 	DESCRIPTION: "Administrative CLI for Effect Patterns maintainers",
 	RUNNER_NAME: "EffectPatterns Admin CLI",
 } as const;

packages/ep-admin/src/runtime/production.ts

@@ -21,6 +21,7 @@ import { Execution } from "../services/execution/index.js";
 import { EnhancedFileSystem } from "../services/filesystem/index.js";
 import { Logger } from "../services/logger/index.js";
 import { McpService } from "../services/mcp/service.js";
+import { TUIService } from "../services/tui/service.js";
 import { ValidationService } from "../services/validation/index.js";
 
 /**
@@ -45,7 +46,8 @@ export const ProductionLayer = Layer.mergeAll(
         NodeFileSystemLayer,
         Logger.Default,
         Layer.provide(Display.Default, Logger.Default),
-        Layer.provide(Execution.Default, Logger.Default),
+        TUIService.Default,
+        Layer.provide(Execution.Default, Layer.mergeAll(Logger.Default, TUIService.Default)),
         Layer.provide(EnhancedFileSystem.Default, NodeFileSystemLayer),
         Layer.provide(ValidationService.Default, NodeFileSystemLayer),
         McpLayer,

packages/ep-admin/src/services/autofix/service.ts

@@ -44,9 +44,10 @@ const callGemini = (
         }
 
         const json = yield* response.json;
-        // @ts-ignore
-        const text = json.candidates?.[0]?.content?.parts?.[0]?.text;
-        return text as string | undefined;
+        const candidates = (json as Record<string, unknown>).candidates as Array<Record<string, unknown>> | undefined;
+        const content = candidates?.[0]?.content as Record<string, unknown> | undefined;
+        const parts = content?.parts as Array<Record<string, unknown>> | undefined;
+        return parts?.[0]?.text as string | undefined;
     });
 
 export const DefaultAutofixService = Layer.effect(
@@ -83,20 +84,20 @@ export const DefaultAutofixService = Layer.effect(
 
                     // Handle report structure (adapt as needed)
                     // Assumes prepublish-check output format
-                    // @ts-ignore
-                    const diagnostics = report.diagnostics || [];
+                    const diagnostics = ((report as Record<string, unknown>).diagnostics ?? []) as Array<Record<string, unknown>>;
                     if (diagnostics.length === 0) {
                         yield* display.showInfo("No errors found in report.");
                         return;
                     }
 
                     // Group by file
-                    const filesMap = new Map<string, any[]>();
+                    const filesMap = new Map<string, Array<Record<string, unknown>>>();
                     for (const d of diagnostics) {
                         if (!d.file) continue;
-                        const existing = filesMap.get(d.file) || [];
+                        const filePath = String(d.file);
+                        const existing = filesMap.get(filePath) || [];
                         existing.push(d);
-                        filesMap.set(d.file, existing);
+                        filesMap.set(filePath, existing);
                     }
 
                     let processed = 0;

packages/ep-admin/src/services/display/__tests__/helpers.test.ts

@@ -6,7 +6,7 @@ import { Effect, Layer } from "effect";
 import { describe, expect, it, vi, beforeEach } from "vitest";
 import { colorizeWithConfig, getLoggerConfig } from "../helpers.js";
 import { Logger, LoggerDefault } from "../../logger/index.js";
-import { colors } from "../../../utils.js";
+import { ANSI_COLORS } from "../../../constants.js";
 
 describe("Display Helpers", () => {
 	describe("colorizeWithConfig", () => {
@@ -19,8 +19,8 @@ describe("Display Helpers", () => {
 			};
 
 			const result = colorizeWithConfig("text", "GREEN", config);
-			expect(result).toContain(colors.GREEN);
-			expect(result).toContain(colors.RESET);
+			expect(result).toContain(ANSI_COLORS.GREEN);
+			expect(result).toContain(ANSI_COLORS.RESET);
 		});
 
 		it("should not apply color when colors disabled", () => {
@@ -33,7 +33,7 @@ describe("Display Helpers", () => {
 
 			const result = colorizeWithConfig("text", "GREEN", config);
 			expect(result).toBe("text");
-			expect(result).not.toContain(colors.GREEN);
+			expect(result).not.toContain(ANSI_COLORS.GREEN);
 		});
 
 		it("should handle different color keys", () => {
@@ -48,9 +48,9 @@ describe("Display Helpers", () => {
 			const blueResult = colorizeWithConfig("text", "BLUE", config);
 			const yellowResult = colorizeWithConfig("text", "YELLOW", config);
 
-			expect(redResult).toContain(colors.RED);
-			expect(blueResult).toContain(colors.BLUE);
-			expect(yellowResult).toContain(colors.YELLOW);
+			expect(redResult).toContain(ANSI_COLORS.RED);
+			expect(blueResult).toContain(ANSI_COLORS.BLUE);
+			expect(yellowResult).toContain(ANSI_COLORS.YELLOW);
 		});
 	});
 

packages/ep-admin/src/services/display/helpers.ts

@@ -3,19 +3,10 @@
  */
 
 import { Effect } from "effect";
-import { colors } from "../../utils.js";
+import { ANSI_COLORS } from "../../constants.js";
 import type { LoggerConfig } from "../logger/index.js";
 import { Logger } from "../logger/index.js";
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-type TUIModule = any;
-
-// TUI module state - loaded lazily on first use
-// TUI module state - loaded lazily on first use
-// Stores: null (not attempted), false (attempted but failed), or the module
-// let tuiModuleCache: TUIModule | false | null = null;
-
-
 /**
  * Get logger config from Logger service
  */
@@ -31,9 +22,9 @@ export const getLoggerConfig = (): Effect.Effect<LoggerConfig, never, Logger> =>
  */
 export const colorizeWithConfig = (
 	text: string,
-	color: keyof typeof colors,
+	color: keyof typeof ANSI_COLORS,
 	config: LoggerConfig
 ): string => {
 	if (!config.useColors) return text;
-	return `${colors[color]}${text}${colors.RESET}`;
+	return `${ANSI_COLORS[color]}${text}${ANSI_COLORS.RESET}`;
 };

packages/ep-admin/src/services/display/index.ts

@@ -1,12 +1,8 @@
 /**
  * Display service barrel exports
- * 
- * Re-exporting shared Display service with ep-admin specific TUI adapter
+ *
+ * Re-exporting shared Display service
  */
 
 // Re-export everything from shared services
 export * from "@effect-patterns/ep-shared-services/display";
-
-// Export ep-admin specific TUI adapter
-export { EpAdminTUIAdapter } from "./tui-adapter.js";
-

packages/ep-admin/src/services/display/service.ts

@@ -153,7 +153,9 @@ export const Display = Effect.Service<DisplayService>()("Display", {
 
 				yield* Console.log(headers);
 				yield* Console.log("─".repeat(headers.length));
-				rows.forEach((row) => Console.log(row));
+				for (const row of rows) {
+					yield* Console.log(row);
+				}
 			}).pipe(
 				Effect.mapError((error) => DisplayError.make(`Failed to show table`, error))
 			) as Effect.Effect<void, DisplayServiceError>;

packages/ep-admin/src/services/display/tui-loader.ts

@@ -3,9 +3,8 @@
  */
 import { Context, Effect, Layer } from "effect";
 
-// Define the shape of the TUI module
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export type TUIModule = any;
+// biome-ignore lint/suspicious/noExplicitAny: Dynamic TUI module shape is unknown at compile time
+export type TUIModule = Record<string, unknown>;
 
 export class TUILoader extends Context.Tag("TUILoader")<
 	TUILoader,

packages/ep-admin/src/services/execution/__tests__/execution.test.ts

@@ -8,6 +8,26 @@ import { Logger } from "../../logger/index.js";
 import { TUIService } from "../../tui/service.js";
 import { Execution } from "../service.js";
 
+const MockTUIService = Layer.succeed(
+	TUIService,
+	TUIService.of({
+		load: () => Effect.succeed(null),
+		isAvailable: () => Effect.succeed(false),
+		clearCache: () => Effect.void,
+	})
+);
+
+const ExecutionTest = Execution.Default.pipe(
+	Layer.provide(MockTUIService),
+	Layer.provide(Logger.Default)
+);
+
+const TestLayer = Layer.mergeAll(
+	ExecutionTest,
+	Logger.Default,
+	MockTUIService
+);
+
 describe("Execution Service", () => {
 	describe("Service Methods", () => {
 		it("should provide all execution methods", () =>
@@ -19,13 +39,7 @@ describe("Execution Service", () => {
 				expect(execution.executeScriptStream).toBeDefined();
 				expect(execution.withSpinner).toBeDefined();
 			}).pipe(
-				Effect.provide(
-					Layer.mergeAll(
-						Execution.Default,
-						Logger.Default,
-						TUIService.Default
-					)
-				),
+				Effect.provide(TestLayer),
 				Effect.runPromise
 			));
 	});
@@ -40,13 +54,7 @@ describe("Execution Service", () => {
 				);
 				expect(result).toBe("test result");
 			}).pipe(
-				Effect.provide(
-					Layer.mergeAll(
-						Execution.Default,
-						Logger.Default,
-						TUIService.Default
-					)
-				),
+				Effect.provide(TestLayer),
 				Effect.runPromise
 			));
 
@@ -61,15 +69,7 @@ describe("Execution Service", () => {
 
 			await expect(
 				Effect.runPromise(
-					program.pipe(
-						Effect.provide(
-							Layer.mergeAll(
-								Execution.Default,
-								Logger.Default,
-								TUIService.Default
-							)
-						)
-					)
+					program.pipe(Effect.provide(TestLayer))
 				)
 			).rejects.toThrow("Task failed");
 		});

packages/ep-admin/src/services/execution/__tests__/helpers.test.ts

@@ -4,7 +4,7 @@
 
 import { Effect } from "effect";
 import { describe, expect, it } from "vitest";
-import { getTUISpinner, withSpinner } from "../helpers.js";
+import { withSpinner } from "../helpers.js";
 
 describe("Execution Helpers", () => {
 	describe("withSpinner", () => {
@@ -25,11 +25,4 @@ describe("Execution Helpers", () => {
 		});
 	});
 
-	describe("getTUISpinner", () => {
-		it("should return TUI spinner info", () => {
-			const result = getTUISpinner();
-			expect(result).toHaveProperty("spinnerEffectTUI");
-			expect(result).toHaveProperty("InkService");
-		});
-	});
 });