Analyzer for named params (TTRESG046) should not trigger on default values

Author: PawelGerr

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs

@@ -343,7 +343,7 @@ private static void AnalyzeSwitchMap(
       {
          var argument = args[argIndex];
 
-         if (argument.Syntax is not ArgumentSyntax argSyntax)
+         if (argument.ArgumentKind == ArgumentKind.DefaultValue || argument.Syntax is not ArgumentSyntax argSyntax)
             continue;
 
          if (argSyntax.NameColon is not null)

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG046_IndexBasedSwitchAndMapMustUseNamedParameters.cs

@@ -1955,6 +1955,66 @@ public void Do()
 
             await Verifier.VerifyAnalyzerAsync(code, [typeof(UnionAttribute).Assembly, typeof(TestUnion).Assembly]);
          }
+
+         [Fact]
+         public async Task Should_not_trigger_when_all_args_are_named_but_not_all_are_present()
+         {
+            var code = """
+
+               using System;
+               using System.Collections.Generic;
+               using Thinktecture;
+               using Thinktecture.Runtime.Tests.TestRegularUnions;
+
+               namespace TestNamespace
+               {
+                  public class Test
+                  {
+                     public void Do()
+                     {
+                        var value = new PlaceId.RegionId.InnerRegionId();
+                        var res = value.SwitchPartially(
+                           @default: _ => "default",
+                           regionId: _ => "RegionId" ,
+                           regionIdInnerRegionId: _ => "InnerRegionId");
+                     }
+                  }
+               }
+               """;
+
+            await Verifier.VerifyAnalyzerAsync(code, [typeof(UnionAttribute).Assembly, typeof(TestUnion).Assembly]);
+         }
+
+         [Fact]
+         public async Task Should_not_trigger_when_all_args_are_named_and_result_is_inlined_as_method_arg()
+         {
+            var code = """
+
+               using System;
+               using System.Collections.Generic;
+               using Thinktecture;
+               using Thinktecture.Runtime.Tests.TestRegularUnions;
+
+               namespace TestNamespace
+               {
+                  public class Test
+                  {
+                     public void Do()
+                     {
+                        var value = new PlaceId.RegionId.InnerRegionId();
+                        List<string> res = [];
+
+                        res.Add(value.SwitchPartially(
+                           @default: _ => "default",
+                           regionId: _ => "RegionId" ,
+                           regionIdInnerRegionId: _ => "InnerRegionId"));
+                     }
+                  }
+               }
+               """;
+
+            await Verifier.VerifyAnalyzerAsync(code, [typeof(UnionAttribute).Assembly, typeof(TestUnion).Assembly]);
+         }
       }
 
       public class SwitchWithFuncAndContext