NotNullIfNotNull is not necessary when key member is struct

Author: PawelGerr

samples/Basic.Samples/SmartEnums/SmartEnumDemos.cs

@@ -36,6 +36,9 @@ private static void DemoForSmartEnum(ILogger logger)
       var productType = ProductType.Get("Groceries");
       logger.Information("Product type: {Type}", productType);
 
+      var productGroup = ProductGroup.Get(1);
+      productGroup = (ProductGroup)1;
+
       try
       {
          // Throws if the provided value is invalid/unknown

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs

@@ -917,9 +917,16 @@ private void GenerateConversionFromKeyType(KeyMemberState keyProperty)
       /// ").Append(_state.Settings.ConversionFromKeyMemberType == ConversionOperatorsGeneration.Implicit ? "Implicit" : "Explicit").Append(" conversion from the type ").AppendTypeForXmlComment(keyProperty).Append(@".
       /// </summary>
       /// <param name=""").AppendArgumentName(keyProperty.ArgumentName).Append(@""">Value to covert.</param>
-      /// <returns>An instance of ").AppendTypeForXmlComment(_state).Append(@" if the <paramref name=""").AppendArgumentName(keyProperty.ArgumentName).Append(@"""/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull(""").AppendArgumentName(keyProperty.ArgumentName).Append(@""")]
-      public static ").AppendConversionOperator(_state.Settings.ConversionFromKeyMemberType).Append(" operator ").AppendTypeFullyQualifiedNullAnnotated(_state).Append("(").AppendTypeFullyQualifiedNullAnnotated(keyProperty).Append(" ").AppendEscaped(keyProperty.ArgumentName).Append(@")
+      /// <returns>An instance of ").AppendTypeForXmlComment(_state).Append(@" if the <paramref name=""").AppendArgumentName(keyProperty.ArgumentName).Append(@"""/> is a known item.</returns>");
+
+      if (keyProperty.IsReferenceType)
+      {
+         _sb.Append(@"
+      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull(""").AppendArgumentName(keyProperty.ArgumentName).Append(@""")]");
+      }
+
+      _sb.Append(@"
+      public static ").AppendConversionOperator(_state.Settings.ConversionFromKeyMemberType).Append(" operator ").AppendTypeFullyQualified(_state, nullable: keyProperty.IsReferenceType).Append("(").AppendTypeFullyQualifiedNullAnnotated(keyProperty).Append(" ").AppendEscaped(keyProperty.ArgumentName).Append(@")
       {
          return ").AppendTypeFullyQualified(_state).Append(".").Append(Constants.Methods.GET).Append("(").AppendEscaped(keyProperty.ArgumentName).Append(@");
       }");

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/SmartEnumSourceGeneratorTests.Should_generate_int_based_class_0.verified.txt

@@ -159,8 +159,7 @@ namespace Thinktecture.Tests
       /// </summary>
       /// <param name="key">Value to covert.</param>
       /// <returns>An instance of <see cref="TestEnum"/> if the <paramref name="key"/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull("key")]
-      public static explicit operator global::Thinktecture.Tests.TestEnum?(int @key)
+      public static explicit operator global::Thinktecture.Tests.TestEnum(int @key)
       {
          return global::Thinktecture.Tests.TestEnum.Get(@key);
       }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/SmartEnumSourceGeneratorTests.Should_generate_int_based_class_with_ComparisonOperators_DefaultWithKeyTypeOverloads_0.verified.txt

@@ -159,8 +159,7 @@ namespace Thinktecture.Tests
       /// </summary>
       /// <param name="key">Value to covert.</param>
       /// <returns>An instance of <see cref="TestEnum"/> if the <paramref name="key"/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull("key")]
-      public static explicit operator global::Thinktecture.Tests.TestEnum?(int @key)
+      public static explicit operator global::Thinktecture.Tests.TestEnum(int @key)
       {
          return global::Thinktecture.Tests.TestEnum.Get(@key);
       }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/SmartEnumSourceGeneratorTests.Should_generate_int_based_class_with_ObjectFactoryAttribute_0.verified.txt

@@ -159,8 +159,7 @@ namespace Thinktecture.Tests
       /// </summary>
       /// <param name="key">Value to covert.</param>
       /// <returns>An instance of <see cref="TestEnum"/> if the <paramref name="key"/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull("key")]
-      public static explicit operator global::Thinktecture.Tests.TestEnum?(int @key)
+      public static explicit operator global::Thinktecture.Tests.TestEnum(int @key)
       {
          return global::Thinktecture.Tests.TestEnum.Get(@key);
       }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/SmartEnumSourceGeneratorTests.Should_generate_int_based_class_with_ObjectFactoryAttribute_and_UseForSerialization_0.verified.txt

@@ -159,8 +159,7 @@ namespace Thinktecture.Tests
       /// </summary>
       /// <param name="key">Value to covert.</param>
       /// <returns>An instance of <see cref="TestEnum"/> if the <paramref name="key"/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull("key")]
-      public static explicit operator global::Thinktecture.Tests.TestEnum?(int @key)
+      public static explicit operator global::Thinktecture.Tests.TestEnum(int @key)
       {
          return global::Thinktecture.Tests.TestEnum.Get(@key);
       }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/SmartEnumSourceGeneratorTests.Should_handle_special_chars_0.verified.txt

@@ -158,8 +158,7 @@ namespace Thinktecture.Tests
       /// </summary>
       /// <param name="_1Key">Value to covert.</param>
       /// <returns>An instance of <see cref="_1TestEnum"/> if the <paramref name="_1Key"/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull("_1Key")]
-      public static explicit operator global::Thinktecture.Tests._1TestEnum?(int @_1Key)
+      public static explicit operator global::Thinktecture.Tests._1TestEnum(int @_1Key)
       {
          return global::Thinktecture.Tests._1TestEnum.Get(@_1Key);
       }

test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/SourceGeneratorTests/SmartEnumSourceGeneratorTests.Should_use_custom_SwitchMapStateParameterName_0.verified.txt

@@ -158,8 +158,7 @@ namespace Thinktecture.Tests
       /// </summary>
       /// <param name="key">Value to covert.</param>
       /// <returns>An instance of <see cref="TestEnum"/> if the <paramref name="key"/> is a known item.</returns>
-      [return: global::System.Diagnostics.CodeAnalysis.NotNullIfNotNull("key")]
-      public static explicit operator global::Thinktecture.Tests.TestEnum?(int @key)
+      public static explicit operator global::Thinktecture.Tests.TestEnum(int @key)
       {
          return global::Thinktecture.Tests.TestEnum.Get(@key);
       }