fix code generation for operators without corresponding static abstract interface

Author: PawelGerr

Directory.Build.props

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <Copyright>(c) $([System.DateTime]::Now.Year), Pawel Gerr. All rights reserved.</Copyright>
-    <VersionPrefix>10.1.1</VersionPrefix>
+    <VersionPrefix>10.1.2</VersionPrefix>
     <Authors>Pawel Gerr</Authors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageProjectUrl>https://github.com/PawelGerr/Thinktecture.Runtime.Extensions</PackageProjectUrl>

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/AdditionOperatorsCodeGenerator.cs

@@ -56,7 +56,7 @@ private AdditionOperatorsCodeGenerator(
 
    public void GenerateBaseTypes(StringBuilder sb, InterfaceCodeGeneratorState state)
    {
-      if (!_keyMemberOperators.HasOperator(ImplementedOperators.All))
+      if (!_keyMemberOperators.HasOperator(ImplementedOperators.Default))
          return;
 
       sb.Append(@"

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/DivisionOperatorsCodeGenerator.cs

@@ -54,7 +54,7 @@ private DivisionOperatorsCodeGenerator(ImplementedOperators keyMemberOperators,
 
    public void GenerateBaseTypes(StringBuilder sb, InterfaceCodeGeneratorState state)
    {
-      if (!_keyMemberOperators.HasOperator(ImplementedOperators.All))
+      if (!_keyMemberOperators.HasOperator(ImplementedOperators.Default))
          return;
 
       sb.Append(@"

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/MultiplyOperatorsCodeGenerator.cs

@@ -54,7 +54,7 @@ private MultiplyOperatorsCodeGenerator(ImplementedOperators keyMemberOperators,
 
    public void GenerateBaseTypes(StringBuilder sb, InterfaceCodeGeneratorState state)
    {
-      if (!_keyMemberOperators.HasOperator(ImplementedOperators.All))
+      if (!_keyMemberOperators.HasOperator(ImplementedOperators.Default))
          return;
 
       sb.Append(@"

src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/SubtractionOperatorsCodeGenerator.cs

@@ -54,7 +54,7 @@ private SubtractionOperatorsCodeGenerator(ImplementedOperators keyMemberOperator
 
    public void GenerateBaseTypes(StringBuilder sb, InterfaceCodeGeneratorState state)
    {
-      if (!_keyMemberOperators.HasOperator(ImplementedOperators.All))
+      if (!_keyMemberOperators.HasOperator(ImplementedOperators.Default))
          return;
 
       sb.Append(@"

test/Thinktecture.Runtime.Extensions.AspNetCore.Tests/AspNetCore/ModelBinding/ThinktectureModelBinderTests/BindModelAsync.cs

@@ -285,6 +285,36 @@ public async Task Should_bind_simple_value_object_having_custom_factory_name()
       ctx.Result.Model.Should().Be(IntBasedReferenceValueObjectWithCustomFactoryNames.Get(1));
    }
 
+   [Fact]
+   public async Task Should_bind_timespan_reference_value_object()
+   {
+      var ctx = await BindAsync<TimeSpanBasedReferenceValueObject>("01:30:00");
+
+      ctx.ModelState.ErrorCount.Should().Be(0);
+      ctx.Result.IsModelSet.Should().BeTrue();
+      ctx.Result.Model.Should().Be(TimeSpanBasedReferenceValueObject.Create(TimeSpan.FromMinutes(90)));
+   }
+
+   [Fact]
+   public async Task Should_bind_timespan_struct_value_object()
+   {
+      var ctx = await BindAsync<TimeSpanBasedStructValueObject>("01:30:00");
+
+      ctx.ModelState.ErrorCount.Should().Be(0);
+      ctx.Result.IsModelSet.Should().BeTrue();
+      ctx.Result.Model.Should().Be(TimeSpanBasedStructValueObject.Create(TimeSpan.FromMinutes(90)));
+   }
+
+   [Fact]
+   public async Task Should_not_bind_timespan_when_null()
+   {
+      var ctx = await BindAsync<TimeSpanBasedReferenceValueObject>(null);
+
+      ctx.ModelState.ErrorCount.Should().Be(0);
+      ctx.Result.IsModelSet.Should().BeFalse();
+      ctx.Result.Model.Should().BeNull();
+   }
+
    private static T Bind<T>(string value)
    {
       var context = BindAsync<T>(value).GetAwaiter().GetResult();

test/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Tests.Sources/EntityFrameworkCore/ValueConversion/ValueObjectValueConverterFactoryTests.cs

@@ -49,6 +49,8 @@ public async Task Should_write_and_read_enums_and_value_types()
                          IntBasedReferenceValueObject.Create(1),
                          IntBasedReferenceValueObject.Create(2)
                       ],
+                      TimeSpanBasedReferenceValueObject = TimeSpanBasedReferenceValueObject.Create(TimeSpan.FromHours(1.5)),
+                      TimeSpanBasedStructValueObject = TimeSpanBasedStructValueObject.Create(TimeSpan.FromMinutes(30)),
                    };
       _ctx.Add(entity);
       await _ctx.SaveChangesAsync(TestContext.Current.CancellationToken);

test/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Tests.Sources/Extensions/DbContextOptionsBuilderExtensionsTests/UseThinktectureValueConverters.cs

@@ -39,6 +39,8 @@ public void Should_add_converters_for_structs_and_classes()
 
       ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.SmartEnum_IntBased), _converterType.MakeGenericType(typeof(SmartEnum_IntBased), typeof(int), typeof(ValidationError)));
       ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.SmartEnum_StringBased));
+      ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.TimeSpanBasedReferenceValueObject), _converterType.MakeGenericType(typeof(TimeSpanBasedReferenceValueObject), typeof(TimeSpan), typeof(ValidationError)));
+      ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.TimeSpanBasedStructValueObject), _converterType.MakeGenericType(typeof(TimeSpanBasedStructValueObject), typeof(TimeSpan), typeof(ValidationError)));
    }
 
    [Fact]

test/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Tests.Sources/Extensions/EntityTypeBuilderExtensionsTests/AddThinktectureValueConverters.cs

@@ -32,6 +32,8 @@ public void Should_add_converters_for_structs_and_classes()
 
          ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.SmartEnum_IntBased), _converterType.MakeGenericType(typeof(SmartEnum_IntBased), typeof(int), typeof(ValidationError)));
          ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.SmartEnum_StringBased));
+         ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.TimeSpanBasedReferenceValueObject), _converterType.MakeGenericType(typeof(TimeSpanBasedReferenceValueObject), typeof(TimeSpan), typeof(ValidationError)));
+         ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.TimeSpanBasedStructValueObject), _converterType.MakeGenericType(typeof(TimeSpanBasedStructValueObject), typeof(TimeSpan), typeof(ValidationError)));
       }
 
       [Fact]

test/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Tests.Sources/Extensions/ModelBuilderExtensionsTests/AddThinktectureValueConverters.cs

@@ -31,6 +31,8 @@ public void Should_add_converters_for_structs_and_classes()
 
          ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.SmartEnum_IntBased), _converterType.MakeGenericType(typeof(SmartEnum_IntBased), typeof(int), typeof(ValidationError)));
          ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.SmartEnum_StringBased));
+         ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.TimeSpanBasedReferenceValueObject), _converterType.MakeGenericType(typeof(TimeSpanBasedReferenceValueObject), typeof(TimeSpan), typeof(ValidationError)));
+         ValidateConverter(entityType, nameof(TestEntity_with_Enum_and_ValueObjects.TimeSpanBasedStructValueObject), _converterType.MakeGenericType(typeof(TimeSpanBasedStructValueObject), typeof(TimeSpan), typeof(ValidationError)));
       }
 
       [Fact]