Struct-based smart enums and value objects with reference key types, as well as ad hoc unions must be required.

PawelGerr · PawelGerr · commit 442e754856e5 · 2025-04-15T23:32:44.000+02:00
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <Copyright>(c) $([System.DateTime]::Now.Year), Pawel Gerr. All rights reserved.</Copyright>
-    <VersionPrefix>8.6.1</VersionPrefix>
+    <VersionPrefix>8.7.0</VersionPrefix>
     <Authors>Pawel Gerr</Authors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageProjectUrl>https://github.com/PawelGerr/Thinktecture.Runtime.Extensions</PackageProjectUrl>
diff --git a/samples/Thinktecture.Runtime.Extensions.Benchmarking/Benchmarks/LoadingSmartEnums.cs b/samples/Thinktecture.Runtime.Extensions.Benchmarking/Benchmarks/LoadingSmartEnums.cs
@@ -10,18 +10,19 @@ namespace Thinktecture.Benchmarks;
 
 /*
 
-22.01.2025
+15.04.2025
 
-.NET 9.0.1
+.NET 9.0.4
+
+| Method                       | Mean     | Error    | StdDev    | Median    | Allocated |
+|----------------------------- |---------:|---------:|----------:|----------:|----------:|
+| Real_Enum_StringConverter    | 11.34 ms | 1.382 ms |  3.876 ms |  9.640 ms |   7.16 MB |
+| SmartEnum_Struct_StringBased | 11.63 ms | 1.485 ms |  4.214 ms | 10.541 ms |   8.51 MB |
+| SmartEnum_Class_StringBased  | 15.93 ms | 2.599 ms |  7.416 ms | 13.270 ms |   8.21 MB |
+| Real_Enum_IntBased           | 15.07 ms | 2.923 ms |  8.574 ms | 11.595 ms |   6.67 MB |
+| SmartEnum_Struct_IntBased    | 16.91 ms | 4.670 ms | 13.399 ms | 10.216 ms |   8.02 MB |
+| SmartEnum_Class_IntBased     | 20.11 ms | 5.255 ms | 15.078 ms | 12.856 ms |   7.72 MB |
 
-| Method                       | Mean      | Error     | StdDev    | Median    | Allocated |
-|----------------------------- |----------:|----------:|----------:|----------:|----------:|
-| Real_Enum_StringConverter    | 15.722 ms | 3.4459 ms | 10.106 ms | 10.545 ms |   7.16 MB |
-| SmartEnum_Struct_StringBased | 12.430 ms | 2.6370 ms |  7.307 ms | 10.046 ms |   8.51 MB |
-| SmartEnum_Class_StringBased  |  9.328 ms | 1.1271 ms |  3.008 ms |  8.682 ms |   8.21 MB |
-| Real_Enum_IntBased           |  6.801 ms | 1.0520 ms |  2.826 ms |  5.830 ms |   6.67 MB |
-| SmartEnum_Struct_IntBased    |  7.341 ms | 0.8959 ms |  2.482 ms |  6.327 ms |   8.03 MB |
-| SmartEnum_Class_IntBased     |  7.453 ms | 0.8701 ms |  2.352 ms |  6.643 ms |   7.72 MB |
 
  */
 
@@ -35,12 +36,18 @@ public class LoadingSmartEnums
    private const int _NUMBER_OF_ENTITIES = 10_000;
    private static readonly RealEnum[] _enums = Enum.GetValues<RealEnum>();
 
-   private readonly Entity_Enum_StringConverter[] _Entity_Enum_StringConverter = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_Enum_StringConverter(i, _enums[i % _enums.Length])).ToArray();
-   private readonly Entity_Enum_IntBased[] _Entity_Enum_IntBased = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_Enum_IntBased(i, _enums[i % _enums.Length])).ToArray();
-   private readonly Entity_SmartEnum_Class_StringBased[] _Entity_SmartEnum_Class_StringBased = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Class_StringBased(i, TestSmartEnum_Class_StringBased.Items[i % _enums.Length])).ToArray();
-   private readonly Entity_SmartEnum_Struct_StringBased[] _Entity_SmartEnum_Struct_StringBased = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Struct_StringBased(i, TestSmartEnum_Struct_StringBased.Items[i % _enums.Length])).ToArray();
-   private readonly Entity_SmartEnum_Class_IntBased[] _Entity_SmartEnum_Class_IntBased = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Class_IntBased(i, TestSmartEnum_Class_IntBased.Items[i % _enums.Length])).ToArray();
-   private readonly Entity_SmartEnum_Struct_IntBased[] _Entity_SmartEnum_Struct_IntBased = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Struct_IntBased(i, TestSmartEnum_Struct_IntBased.Items[i % _enums.Length])).ToArray();
+   private readonly Entity_Enum_StringConverter[] _Entity_Enum_StringConverter
+      = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_Enum_StringConverter(i, _enums[i % _enums.Length]) { Enum = RealEnum.Value1 }).ToArray();
+   private readonly Entity_Enum_IntBased[] _Entity_Enum_IntBased
+      = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_Enum_IntBased(i, _enums[i % _enums.Length]) { Enum = RealEnum.Value1 }).ToArray();
+   private readonly Entity_SmartEnum_Class_StringBased[] _Entity_SmartEnum_Class_StringBased
+      = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Class_StringBased(i, TestSmartEnum_Class_StringBased.Items[i % _enums.Length]) { Enum = TestSmartEnum_Class_StringBased.Value1 }).ToArray();
+   private readonly Entity_SmartEnum_Struct_StringBased[] _Entity_SmartEnum_Struct_StringBased
+      = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Struct_StringBased(i, TestSmartEnum_Struct_StringBased.Items[i % _enums.Length]) { Enum = TestSmartEnum_Struct_StringBased.Value1 }).ToArray();
+   private readonly Entity_SmartEnum_Class_IntBased[] _Entity_SmartEnum_Class_IntBased
+      = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Class_IntBased(i, TestSmartEnum_Class_IntBased.Items[i % _enums.Length]) { Enum = TestSmartEnum_Class_IntBased.Value1 }).ToArray();
+   private readonly Entity_SmartEnum_Struct_IntBased[] _Entity_SmartEnum_Struct_IntBased
+      = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_SmartEnum_Struct_IntBased(i, TestSmartEnum_Struct_IntBased.Items[i % _enums.Length]) { Enum = TestSmartEnum_Struct_IntBased.Value1 }).ToArray();
 
    [GlobalSetup]
    public void Initialize()
diff --git a/samples/Thinktecture.Runtime.Extensions.Benchmarking/Benchmarks/LoadingValueObjects.cs b/samples/Thinktecture.Runtime.Extensions.Benchmarking/Benchmarks/LoadingValueObjects.cs
@@ -9,15 +9,15 @@ namespace Thinktecture.Benchmarks;
 
 /*
 
-22.01.2025
+15.04.2025
 
-.NET 9.0.1
+.NET 9.0.4
 
-| Method                         | Mean     | Error   | StdDev   | Median   | Gen0      | Gen1      | Allocated |
-|------------------------------- |---------:|--------:|---------:|---------:|----------:|----------:|----------:|
-| Entity_with_ValueObjects       | 178.4 ms | 7.83 ms | 22.73 ms | 172.4 ms | 4000.0000 | 3000.0000 |  89.13 MB |
-| Entity_without_ValueObjects    | 175.6 ms | 8.77 ms | 25.84 ms | 166.2 ms | 4000.0000 | 3000.0000 |  84.55 MB |
-| Entity_with_StructValueObjects | 164.7 ms | 8.33 ms | 24.30 ms | 157.5 ms | 4000.0000 | 3000.0000 |  92.61 MB |
+| Method                         | Mean     | Error   | StdDev   | Gen0      | Gen1      | Allocated |
+|------------------------------- |---------:|--------:|---------:|----------:|----------:|----------:|
+| Entity_with_ValueObjects       | 180.7 ms | 6.46 ms | 18.53 ms | 4000.0000 | 3000.0000 |  84.38 MB |
+| Entity_without_ValueObjects    | 143.0 ms | 5.76 ms | 16.97 ms | 3000.0000 | 2000.0000 |   79.8 MB |
+| Entity_with_StructValueObjects | 134.2 ms | 4.16 ms | 12.26 ms | 3000.0000 | 2000.0000 |  87.86 MB |
 
  */
 
@@ -30,9 +30,21 @@ public class LoadingValueObjects
 
    private const int _NUMBER_OF_ENTITIES = 100_000;
 
-   private readonly Entity_with_ValueObjects[] _Entity_with_ValueObjects = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_with_ValueObjects(i)).ToArray();
-   private readonly Entity_without_ValueObjects[] _Entity_without_ValueObjects = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_without_ValueObjects(i)).ToArray();
-   private readonly Entity_with_StructValueObjects[] _Entity_with_StructValueObjects = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_with_StructValueObjects(i)).ToArray();
+   private readonly Entity_with_ValueObjects[] _Entity_with_ValueObjects = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_with_ValueObjects(i)
+                                                                                                                                {
+                                                                                                                                   Name = Name.Create("Name"),
+                                                                                                                                   Description = Description.Create("Description"),
+                                                                                                                                }).ToArray();
+   private readonly Entity_without_ValueObjects[] _Entity_without_ValueObjects = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_without_ValueObjects(i)
+                                                                                                                                      {
+                                                                                                                                         Name = "Name",
+                                                                                                                                         Description = "Description",
+                                                                                                                                      }).ToArray();
+   private readonly Entity_with_StructValueObjects[] _Entity_with_StructValueObjects = Enumerable.Range(1, _NUMBER_OF_ENTITIES).Select(i => new Entity_with_StructValueObjects(i)
+                                                                                                                                            {
+                                                                                                                                               Name = NameStruct.Create("Name"),
+                                                                                                                                               Description = DescriptionStruct.Create("Description"),
+                                                                                                                                            }).ToArray();
 
    [GlobalSetup]
    public void Initialize()
diff --git a/samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/Entity_SmartEnum_Struct_StringBased.cs b/samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/Entity_SmartEnum_Struct_StringBased.cs
@@ -4,7 +4,7 @@ namespace Thinktecture.Database;
 public class Entity_SmartEnum_Struct_StringBased
 {
    public int Id { get; set; }
-   public TestSmartEnum_Struct_StringBased Enum { get; set; }
+   public required TestSmartEnum_Struct_StringBased Enum { get; set; }
 
    public Entity_SmartEnum_Struct_StringBased(int id, TestSmartEnum_Struct_StringBased @enum)
    {
diff --git a/samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/Entity_with_StructValueObjects.cs b/samples/Thinktecture.Runtime.Extensions.Benchmarking/Database/Entity_with_StructValueObjects.cs
@@ -4,8 +4,8 @@ namespace Thinktecture.Database;
 public class Entity_with_StructValueObjects
 {
    public int Id { get; set; }
-   public NameStruct Name { get; set; }
-   public DescriptionStruct Description { get; set; }
+   public required NameStruct Name { get; set; }
+   public required DescriptionStruct Description { get; set; }
 
    // ReSharper disable once UnusedMember.Local
    private Entity_with_StructValueObjects(int id, NameStruct name, DescriptionStruct description)
diff --git a/samples/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Samples/Product.cs b/samples/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Samples/Product.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Diagnostics.CodeAnalysis;
 using Thinktecture.SmartEnums;
 using Thinktecture.ValueObjects;
 
@@ -11,11 +12,12 @@ public class Product
    public ProductCategory Category { get; private set; }
    public ProductType ProductType { get; private set; }
    public OpenEndDate EndDate { get; set; }
-   public DayMonth ScheduledDeliveryDate { get; set; }
+   public required DayMonth ScheduledDeliveryDate { get; set; }
 
    private Boundary? _boundary;
    public Boundary Boundary => _boundary ?? throw new InvalidOperationException("Boundary is not loaded.");
 
+   [SetsRequiredMembers]
    private Product(
       Guid id,
       ProductName name,
@@ -32,6 +34,7 @@ private Product(
       ScheduledDeliveryDate = scheduledDeliveryDate;
    }
 
+   [SetsRequiredMembers]
    public Product(
       Guid id,
       ProductName name,
diff --git a/samples/Thinktecture.Runtime.Extensions.Samples/ValueObjects/ProductNameStruct.cs b/samples/Thinktecture.Runtime.Extensions.Samples/ValueObjects/ProductNameStruct.cs
@@ -2,7 +2,7 @@
 
 namespace Thinktecture.ValueObjects;
 
-[ValueObject<string>(DefaultInstancePropertyName = "None")]
+[ValueObject<string>]
 [ValueObjectKeyMemberEqualityComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
 [ValueObjectKeyMemberComparer<ComparerAccessors.StringOrdinalIgnoreCase, string>]
 public partial struct ProductNameStruct
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/CodeFixes/ThinktectureRuntimeExtensionsCodeFixProvider.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/CodeFixes/ThinktectureRuntimeExtensionsCodeFixProvider.cs
@@ -11,6 +11,7 @@ public sealed class ThinktectureRuntimeExtensionsCodeFixProvider : CodeFixProvid
    private const string _MAKE_PARTIAL = "Make the type partial";
    private const string _MAKE_METHOD_PARTIAL = "Make the method partial";
    private const string _MAKE_MEMBER_PUBLIC = "Make the member public";
+   private const string _MAKE_MEMBER_REQUIRED = "Make the member required";
    private const string _MAKE_FIELD_READONLY = "Make the field read-only";
    private const string _REMOVE_PROPERTY_SETTER = "Remove property setter";
    private const string _MAKE_INIT_PRIVATE = "Make init private";
@@ -39,6 +40,7 @@ public sealed class ThinktectureRuntimeExtensionsCodeFixProvider : CodeFixProvid
       DiagnosticsDescriptors.ExplicitEqualityComparerWithoutComparer.Id,
       DiagnosticsDescriptors.MethodWithUseDelegateFromConstructorMustBePartial.Id,
       DiagnosticsDescriptors.UnionRecordMustBeSealed.Id,
+      DiagnosticsDescriptors.MembersDisallowingDefaultValuesMustBeRequired.Id,
    ];
 
    /// <inheritdoc />
@@ -120,6 +122,10 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
          {
             context.RegisterCodeFix(CodeAction.Create(_SEAL_CLASS, _ => ReplaceOrAddTypeModifierAsync(context.Document, root, GetCodeFixesContext().TypeDeclaration, SyntaxKind.AbstractKeyword, SyntaxKind.SealedKeyword), _SEAL_CLASS), diagnostic);
          }
+         else if (diagnostic.Id == DiagnosticsDescriptors.MembersDisallowingDefaultValuesMustBeRequired.Id)
+         {
+            context.RegisterCodeFix(CodeAction.Create(_MAKE_MEMBER_REQUIRED, _ => AddTypeModifierAsync(context.Document, root, GetCodeFixesContext().MemberDeclaration, SyntaxKind.RequiredKeyword), _MAKE_MEMBER_REQUIRED), diagnostic);
+         }
       }
    }
 
@@ -452,6 +458,9 @@ private sealed class CodeFixesContext
       private FieldDeclarationSyntax? _fieldDeclaration;
       public FieldDeclarationSyntax? FieldDeclaration => _fieldDeclaration ??= GetDeclaration<FieldDeclarationSyntax>();
 
+      private MemberDeclarationSyntax? _memberDeclaration;
+      public MemberDeclarationSyntax? MemberDeclaration => _memberDeclaration ??= GetDeclaration<MemberDeclarationSyntax>();
+
       private PropertyDeclarationSyntax? _propertyDeclaration;
       public PropertyDeclarationSyntax? PropertyDeclaration => _propertyDeclaration ??= GetDeclaration<PropertyDeclarationSyntax>();
 
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs
@@ -1,3 +1,4 @@
+using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Operations;
@@ -57,6 +58,7 @@ public sealed class ThinktectureRuntimeExtensionsAnalyzer : DiagnosticAnalyzer
       DiagnosticsDescriptors.NonAbstractDerivedUnionIsLessAccessibleThanBaseUnion,
       DiagnosticsDescriptors.AllowDefaultStructsCannotBeTrueIfValueObjectIsStructButKeyTypeIsClass,
       DiagnosticsDescriptors.AllowDefaultStructsCannotBeTrueIfSomeMembersDisallowDefaultValues,
+      DiagnosticsDescriptors.MembersDisallowingDefaultValuesMustBeRequired,
    ];
 
    /// <inheritdoc />
@@ -74,6 +76,59 @@ public override void Initialize(AnalysisContext context)
       context.RegisterOperationAction(AnalyzeMethodCall, OperationKind.Invocation);
       context.RegisterOperationAction(AnalyzeDefaultValueAssignment, OperationKind.DefaultValue);
       context.RegisterOperationAction(AnalyzeObjectCreation, OperationKind.ObjectCreation);
+
+      context.RegisterSyntaxNodeAction(AnalyzeFieldDisallowingDefaultValues, SyntaxKind.FieldDeclaration);
+      context.RegisterSyntaxNodeAction(AnalyzePropertyDisallowingDefaultValues, SyntaxKind.PropertyDeclaration);
+   }
+
+   private static void AnalyzePropertyDisallowingDefaultValues(SyntaxNodeAnalysisContext context)
+   {
+      if (context.Node is not PropertyDeclarationSyntax propertyDeclarationSyntax
+          || propertyDeclarationSyntax.ExpressionBody is not null // public MyStruct Member => ...;
+          || propertyDeclarationSyntax.Initializer is not null    // public MyStruct Member { get; } = ...;
+          || context.ContainingSymbol is not IPropertySymbol propertySymbol
+          || propertySymbol.SetMethod is null // public MyStruct Member { get; }
+          || propertySymbol.IsStatic
+          || propertySymbol.DeclaredAccessibility < propertySymbol.ContainingType.DeclaredAccessibility            // required members must not be less visible than the containing type
+          || propertySymbol.SetMethod.DeclaredAccessibility < propertySymbol.ContainingType.DeclaredAccessibility) // setter of required members must not be less visible than the containing type
+         return;
+
+      MemberDisallowingDefaultValuesMustBeRequired(context, propertyDeclarationSyntax, propertySymbol.Type, "property", propertySymbol.Name);
+   }
+
+   private static void AnalyzeFieldDisallowingDefaultValues(SyntaxNodeAnalysisContext context)
+   {
+      if (context.Node is not FieldDeclarationSyntax fieldDeclarationSyntax
+          || (fieldDeclarationSyntax.Declaration.Variables.Count == 1 && fieldDeclarationSyntax.Declaration.Variables[0].Initializer is not null) // public MyStruct Member = ...;
+          || context.ContainingSymbol is not IFieldSymbol fieldSymbol
+          || fieldSymbol.IsStatic
+          || fieldSymbol.DeclaredAccessibility < fieldSymbol.ContainingType.DeclaredAccessibility) // required members must not be less visible than the containing type
+         return;
+
+      MemberDisallowingDefaultValuesMustBeRequired(context, fieldDeclarationSyntax, fieldSymbol.Type, "field", fieldSymbol.Name);
+   }
+
+   private static void MemberDisallowingDefaultValuesMustBeRequired(
+      SyntaxNodeAnalysisContext context,
+      MemberDeclarationSyntax memberDeclarationSyntax,
+      ITypeSymbol memberType,
+      string memberKind,
+      string memberName)
+   {
+      if (memberDeclarationSyntax.Modifiers.Any(SyntaxKind.RequiredKeyword))
+         return;
+
+      if (memberType.SpecialType != SpecialType.None || !memberType.IsValueType)
+         return;
+
+      if (!memberType.Interfaces.Any(i => i.IsIDisallowDefaultValue()))
+         return;
+
+      context.ReportDiagnostic(Diagnostic.Create(
+                                  DiagnosticsDescriptors.MembersDisallowingDefaultValuesMustBeRequired,
+                                  context.Node.GetLocation(),
+                                  memberKind,
+                                  memberName));
    }
 
    private static void AnalyzeMethodWithUseDelegateFromConstructor(OperationAnalysisContext context)
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/DiagnosticsDescriptors.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/DiagnosticsDescriptors.cs
@@ -48,4 +48,5 @@ internal static class DiagnosticsDescriptors
    public static readonly DiagnosticDescriptor StaticPropertiesAreNotConsideredItems = new("TTRESG101", "Static properties are not considered enumeration items, use a field instead", "The static property '{0}' is not considered a enumeration item, use a field instead", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
    public static readonly DiagnosticDescriptor ExplicitComparerWithoutEqualityComparer = new("TTRESG102", "The type has a comparer defined but no equality comparer", "The type '{0}' has a comparer defined but no equality comparer", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
    public static readonly DiagnosticDescriptor ExplicitEqualityComparerWithoutComparer = new("TTRESG103", "The type has an equality comparer defined but no comparer", "The type '{0}' has an equality comparer defined but no comparer", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
+   public static readonly DiagnosticDescriptor MembersDisallowingDefaultValuesMustBeRequired = new("TTRESG104", "The member must be marked as 'required' to ensure proper initialization", "The {0} '{1}' must be marked as 'required' to ensure proper initialization", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);
 }
diff --git a/test/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Tests.Sources/TestEntities/TestEntity_with_Enum_and_ValueObjects.cs b/test/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Tests.Sources/TestEntities/TestEntity_with_Enum_and_ValueObjects.cs
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG047_VariableMustBeInitializedWithNonDefaultValue.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG047_VariableMustBeInitializedWithNonDefaultValue.cs
diff --git a/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG104_MembersDisallowingDefaultValuesMustBeRequired.cs b/test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG104_MembersDisallowingDefaultValuesMustBeRequired.cs

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ namespace Thinktecture.Database;`
`4`	`4`	`public class Entity_SmartEnum_Struct_StringBased`
`5`	`5`	`{`
`6`	`6`	`public int Id { get; set; }`
`7`		`- public TestSmartEnum_Struct_StringBased Enum { get; set; }`
	`7`	`+ public required TestSmartEnum_Struct_StringBased Enum { get; set; }`
`8`	`8`
`9`	`9`	`public Entity_SmartEnum_Struct_StringBased(int id, TestSmartEnum_Struct_StringBased @enum)`
`10`	`10`	`{`
Original file line number	Diff line number	Diff line change
`@@ -48,4 +48,5 @@ internal static class DiagnosticsDescriptors`
`48`	`48`	`public static readonly DiagnosticDescriptor StaticPropertiesAreNotConsideredItems = new("TTRESG101", "Static properties are not considered enumeration items, use a field instead", "The static property '{0}' is not considered a enumeration item, use a field instead", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);`
`49`	`49`	`public static readonly DiagnosticDescriptor ExplicitComparerWithoutEqualityComparer = new("TTRESG102", "The type has a comparer defined but no equality comparer", "The type '{0}' has a comparer defined but no equality comparer", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);`
`50`	`50`	`public static readonly DiagnosticDescriptor ExplicitEqualityComparerWithoutComparer = new("TTRESG103", "The type has an equality comparer defined but no comparer", "The type '{0}' has an equality comparer defined but no comparer", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);`
	`51`	`+ public static readonly DiagnosticDescriptor MembersDisallowingDefaultValuesMustBeRequired = new("TTRESG104", "The member must be marked as 'required' to ensure proper initialization", "The {0} '{1}' must be marked as 'required' to ensure proper initialization", nameof(ThinktectureRuntimeExtensionsAnalyzer), DiagnosticSeverity.Warning, true);`
`51`	`52`	`}`