BREAKING: delete types and members flagged with ObsoleteAttribute

Author: PawelGerr

.clinerules

@@ -23,14 +23,14 @@ This is a .NET library providing **Smart Enums**, **Value Objects**, and **Discr
 - **`src/Thinktecture.Runtime.Extensions`**: Core library with base interfaces, attributes, and runtime helpers
     - Attributes: `SmartEnumAttribute<TKey>`, `SmartEnumAttribute`, `ValueObjectAttribute<TKey>`, `ComplexValueObjectAttribute`, `UnionAttribute<T1,T2,...>` (up to 5 type parameters), `AdHocUnionAttribute` (non-generic alternative to UnionAttribute), `UnionAttribute`, `ObjectFactoryAttribute<T>`
     - Additional attributes: `KeyMemberEqualityComparerAttribute`, `KeyMemberComparerAttribute`, `MemberEqualityComparerAttribute`, `IgnoreMemberAttribute`, `ValidationErrorAttribute`, `UseDelegateFromConstructorAttribute`, `UnionSwitchMapOverloadAttribute`
-    - Key interfaces: `ISmartEnum<TKey>`, `IEnum`, `IKeyedObject<TKey>`, `IKeyedValueObject<TKey>`, `IComplexValueObject`, `IValidationError`, `IObjectFactory<T>`
+    - Key interfaces: `ISmartEnum<TKey>`, `IEnum`, `IKeyedObject<TKey>`, `IKeyedValueObject<TKey>`, `IValidationError`, `IObjectFactory<T>`
     - Utility types: `ValidationError`, `ComparerAccessors`, collection helpers (EmptyDictionary, EmptyLookup, SingleItemReadOnlyDictionary, etc.)
     - Enums: `AccessModifier`, `MemberKind`, `OperatorsGeneration`, `ConversionOperatorsGeneration`, `SwitchMapMethodsGeneration`, `SerializationFrameworks`, `UnionConstructorAccessModifier`
 - **`src/Thinktecture.Runtime.Extensions.SourceGenerator`**: Roslyn Source Generators and Analyzers that create boilerplate code and validate usage for partial classes/structs
     - Contains 6 source generators, 2 analyzers, and 1 code fix provider
     - Organized into subdirectories: SmartEnums, ValueObjects, AdHocUnions, RegularUnions, ObjectFactories, Annotations, Diagnostics, CodeFixes
-- **Framework Integration Projects**: Separate projects for JSON, MessagePack, Newtonsoft.Json, ProtoBuf, Entity Framework Core (7/8/9), ASP.NET Core, and Swashbuckle
-    - **EF Core**: Shared sources in `EntityFrameworkCore.Sources`, version-specific projects for EF Core 7/8/9
+- **Framework Integration Projects**: Separate projects for JSON, MessagePack, Newtonsoft.Json, ProtoBuf, Entity Framework Core (8/9/10), ASP.NET Core, and Swashbuckle
+    - **EF Core**: Shared sources in `EntityFrameworkCore.Sources`, version-specific projects for EF Core 8/9/10
     - **Serialization**: Converters/formatters for System.Text.Json, MessagePack, Newtonsoft.Json, and ProtoBuf
 
 ### Source Generators and Analyzers
@@ -518,5 +518,3 @@ Notes:
     - UseWithEntityFramework: bool — enable EF Core integration for this factory
     - UseForModelBinding: bool (init-only) — enable ASP.NET Core model binding
     - HasCorrespondingConstructor: bool (init-only) — indicates presence of a single-parameter ctor of type `Type`
-- Obsolete alias:
-    - ValueObjectFactoryAttribute<T> — use ObjectFactoryAttribute<T> instead

.github/copilot-instructions.md

@@ -23,14 +23,14 @@ This is a .NET library providing **Smart Enums**, **Value Objects**, and **Discr
 - **`src/Thinktecture.Runtime.Extensions`**: Core library with base interfaces, attributes, and runtime helpers
     - Attributes: `SmartEnumAttribute<TKey>`, `SmartEnumAttribute`, `ValueObjectAttribute<TKey>`, `ComplexValueObjectAttribute`, `UnionAttribute<T1,T2,...>` (up to 5 type parameters), `AdHocUnionAttribute` (non-generic alternative to UnionAttribute), `UnionAttribute`, `ObjectFactoryAttribute<T>`
     - Additional attributes: `KeyMemberEqualityComparerAttribute`, `KeyMemberComparerAttribute`, `MemberEqualityComparerAttribute`, `IgnoreMemberAttribute`, `ValidationErrorAttribute`, `UseDelegateFromConstructorAttribute`, `UnionSwitchMapOverloadAttribute`
-    - Key interfaces: `ISmartEnum<TKey>`, `IEnum`, `IKeyedObject<TKey>`, `IKeyedValueObject<TKey>`, `IComplexValueObject`, `IValidationError`, `IObjectFactory<T>`
+    - Key interfaces: `ISmartEnum<TKey>`, `IEnum`, `IKeyedObject<TKey>`, `IKeyedValueObject<TKey>`, `IValidationError`, `IObjectFactory<T>`
     - Utility types: `ValidationError`, `ComparerAccessors`, collection helpers (EmptyDictionary, EmptyLookup, SingleItemReadOnlyDictionary, etc.)
     - Enums: `AccessModifier`, `MemberKind`, `OperatorsGeneration`, `ConversionOperatorsGeneration`, `SwitchMapMethodsGeneration`, `SerializationFrameworks`, `UnionConstructorAccessModifier`
 - **`src/Thinktecture.Runtime.Extensions.SourceGenerator`**: Roslyn Source Generators and Analyzers that create boilerplate code and validate usage for partial classes/structs
     - Contains 6 source generators, 2 analyzers, and 1 code fix provider
     - Organized into subdirectories: SmartEnums, ValueObjects, AdHocUnions, RegularUnions, ObjectFactories, Annotations, Diagnostics, CodeFixes
-- **Framework Integration Projects**: Separate projects for JSON, MessagePack, Newtonsoft.Json, ProtoBuf, Entity Framework Core (7/8/9), ASP.NET Core, and Swashbuckle
-    - **EF Core**: Shared sources in `EntityFrameworkCore.Sources`, version-specific projects for EF Core 7/8/9
+- **Framework Integration Projects**: Separate projects for JSON, MessagePack, Newtonsoft.Json, ProtoBuf, Entity Framework Core (8/9/10), ASP.NET Core, and Swashbuckle
+    - **EF Core**: Shared sources in `EntityFrameworkCore.Sources`, version-specific projects for EF Core 8/9/10
     - **Serialization**: Converters/formatters for System.Text.Json, MessagePack, Newtonsoft.Json, and ProtoBuf
 
 ### Source Generators and Analyzers
@@ -518,5 +518,3 @@ Notes:
     - UseWithEntityFramework: bool — enable EF Core integration for this factory
     - UseForModelBinding: bool (init-only) — enable ASP.NET Core model binding
     - HasCorrespondingConstructor: bool (init-only) — indicates presence of a single-parameter ctor of type `Type`
-- Obsolete alias:
-    - ValueObjectFactoryAttribute<T> — use ObjectFactoryAttribute<T> instead

CLAUDE.md

@@ -23,14 +23,14 @@ This is a .NET library providing **Smart Enums**, **Value Objects**, and **Discr
 - **`src/Thinktecture.Runtime.Extensions`**: Core library with base interfaces, attributes, and runtime helpers
     - Attributes: `SmartEnumAttribute<TKey>`, `SmartEnumAttribute`, `ValueObjectAttribute<TKey>`, `ComplexValueObjectAttribute`, `UnionAttribute<T1,T2,...>` (up to 5 type parameters), `AdHocUnionAttribute` (non-generic alternative to UnionAttribute), `UnionAttribute`, `ObjectFactoryAttribute<T>`
     - Additional attributes: `KeyMemberEqualityComparerAttribute`, `KeyMemberComparerAttribute`, `MemberEqualityComparerAttribute`, `IgnoreMemberAttribute`, `ValidationErrorAttribute`, `UseDelegateFromConstructorAttribute`, `UnionSwitchMapOverloadAttribute`
-    - Key interfaces: `ISmartEnum<TKey>`, `IEnum`, `IKeyedObject<TKey>`, `IKeyedValueObject<TKey>`, `IComplexValueObject`, `IValidationError`, `IObjectFactory<T>`
+    - Key interfaces: `ISmartEnum<TKey>`, `IEnum`, `IKeyedObject<TKey>`, `IKeyedValueObject<TKey>`, `IValidationError`, `IObjectFactory<T>`
     - Utility types: `ValidationError`, `ComparerAccessors`, collection helpers (EmptyDictionary, EmptyLookup, SingleItemReadOnlyDictionary, etc.)
     - Enums: `AccessModifier`, `MemberKind`, `OperatorsGeneration`, `ConversionOperatorsGeneration`, `SwitchMapMethodsGeneration`, `SerializationFrameworks`, `UnionConstructorAccessModifier`
 - **`src/Thinktecture.Runtime.Extensions.SourceGenerator`**: Roslyn Source Generators and Analyzers that create boilerplate code and validate usage for partial classes/structs
     - Contains 6 source generators, 2 analyzers, and 1 code fix provider
     - Organized into subdirectories: SmartEnums, ValueObjects, AdHocUnions, RegularUnions, ObjectFactories, Annotations, Diagnostics, CodeFixes
-- **Framework Integration Projects**: Separate projects for JSON, MessagePack, Newtonsoft.Json, ProtoBuf, Entity Framework Core (7/8/9), ASP.NET Core, and Swashbuckle
-    - **EF Core**: Shared sources in `EntityFrameworkCore.Sources`, version-specific projects for EF Core 7/8/9
+- **Framework Integration Projects**: Separate projects for JSON, MessagePack, Newtonsoft.Json, ProtoBuf, Entity Framework Core (8/9/10), ASP.NET Core, and Swashbuckle
+    - **EF Core**: Shared sources in `EntityFrameworkCore.Sources`, version-specific projects for EF Core 8/9/10
     - **Serialization**: Converters/formatters for System.Text.Json, MessagePack, Newtonsoft.Json, and ProtoBuf
 
 ### Source Generators and Analyzers
@@ -518,5 +518,3 @@ Notes:
     - UseWithEntityFramework: bool — enable EF Core integration for this factory
     - UseForModelBinding: bool (init-only) — enable ASP.NET Core model binding
     - HasCorrespondingConstructor: bool (init-only) — indicates presence of a single-parameter ctor of type `Type`
-- Obsolete alias:
-    - ValueObjectFactoryAttribute<T> — use ObjectFactoryAttribute<T> instead

src/Thinktecture.Runtime.Extensions.AspNetCore/AspNetCore/ModelBinding/ThinktectureModelBinderProvider.cs

@@ -3,35 +3,6 @@
 
 namespace Thinktecture.AspNetCore.ModelBinding;
 
-/// <summary>
-/// Provider for creation of model binders for Smart Enums and for Value Objects with a key member.
-/// </summary>
-[Obsolete("Use 'ThinktectureModelBinderProvider' instead.")]
-public sealed class ValueObjectModelBinderProvider : ThinktectureModelBinderProvider
-{
-   /// <summary>
-   /// Initializes new instance of <see cref="ValueObjectModelBinderProvider"/>.
-   /// </summary>
-   /// <param name="skipBindingFromBody">Indication whether to skip model binding if the raw value comes from request body.</param>
-   public ValueObjectModelBinderProvider(bool skipBindingFromBody = true)
-      : base(skipBindingFromBody)
-   {
-   }
-
-   /// <summary>
-   /// Initializes new instance of <see cref="ValueObjectModelBinderProvider"/>.
-   /// </summary>
-   /// <param name="trimStringBasedEnums">Indication whether to trim string-values before parsing them.</param>
-   /// <param name="skipBindingFromBody">Indication whether to skip model binding if the raw value comes from request body.</param>
-   [Obsolete("Use constructor without 'trimStringBasedEnums' parameter instead")]
-   public ValueObjectModelBinderProvider(
-      bool trimStringBasedEnums,
-      bool skipBindingFromBody = true)
-      : this(skipBindingFromBody)
-   {
-   }
-}
-
 /// <summary>
 /// Provider for creation of model binders for Smart Enums and for Value Objects with a key member.
 /// </summary>

src/Thinktecture.Runtime.Extensions.AspNetCore/AspNetCore/ModelBinding/TrimmingSmartEnumModelBinder.cs

@@ -1,17 +1,5 @@
 namespace Thinktecture.AspNetCore.ModelBinding;
 
-/// <summary>
-/// Model binder for Smart Enums Value Objects with a key member.
-/// </summary>
-/// <typeparam name="T">Type of the value object.</typeparam>
-/// <typeparam name="TKey">Type of the key member.</typeparam>
-/// <typeparam name="TValidationError">Type of the validation error.</typeparam>
-[Obsolete("Use 'ThinktectureModelBinderProvider' instead")]
-public sealed class ValueObjectModelBinder<T, TKey, TValidationError> : ThinktectureModelBinderBase<T, TKey, TValidationError>
-   where T : IObjectFactory<T, TKey, TValidationError>
-   where TKey : notnull
-   where TValidationError : class, IValidationError<TValidationError>;
-
 /// <summary>
 /// Model binder for Smart Enums Value Objects with a key member.
 /// </summary>

src/Thinktecture.Runtime.Extensions.AspNetCore/AspNetCore/ModelBinding/ValueObjectModelBinder.cs

@@ -6,12 +6,6 @@
 
 namespace Thinktecture.EntityFrameworkCore.Storage.ValueConversion;
 
-/// <summary>
-/// Value converter for Smart Enums and for Value Objects with a key member.
-/// </summary>
-[Obsolete("Use 'AddThinktectureValueConverters()' or 'UseThinktectureValueConverters()' with corresponding builder instead.")]
-public sealed class ValueObjectValueConverterFactory : ThinktectureValueConverterFactory;
-
 /// <summary>
 /// Value converter for Smart Enums and for Value Objects with a key member.
 /// </summary>

src/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Sources/EntityFrameworkCore/Storage/ValueConversion/ThinktectureValueConverterFactory.cs

@@ -8,21 +8,6 @@ namespace Thinktecture;
 /// </summary>
 public static class ComplexTypePropertyBuilderExtensions
 {
-   /// <summary>
-   /// Configures a complex type property to use value object conversion.
-   /// </summary>
-   /// <typeparam name="TProperty">The property type.</typeparam>
-   /// <param name="propertyBuilder">The complex type property builder.</param>
-   /// <param name="useConstructorForRead">For keyed value objects only. Whether to use the constructor when reading from the database.</param>
-   /// <returns>The complex type property builder for chaining.</returns>
-   [Obsolete("Use 'HasThinktectureValueConverter' instead.")]
-   public static ComplexTypePropertyBuilder<TProperty> HasValueObjectConversion<TProperty>(
-      this ComplexTypePropertyBuilder<TProperty> propertyBuilder,
-      bool useConstructorForRead = true)
-   {
-      return propertyBuilder.HasThinktectureValueConverter(useConstructorForRead);
-   }
-
    /// <summary>
    /// Configures a complex type property to use value converter for Smart Enums and Value Objects.
    /// </summary>

src/Thinktecture.Runtime.Extensions.EntityFrameworkCore.Sources/Extensions/ComplexTypePropertyBuilderExtensions.cs

@@ -11,43 +11,6 @@ namespace Thinktecture;
 /// </summary>
 public static class DbContextOptionsBuilderExtensions
 {
-   /// <summary>
-   /// Enables automatic configuration of <see cref="ValueConverter"/> for Smart Enums and Value Objects.
-   /// </summary>
-   /// <param name="builder">Options builder.</param>
-   /// <param name="useThinktectureConverters">Indication whether to enable or disable the feature.</param>
-   /// <param name="useConstructorForRead">For keyed value objects only. Use the constructor instead of the factory method when reading the data from the database.</param>
-   /// <param name="configureEnumsAndKeyedValueObjects">Action for further configuration of the property.</param>
-   /// <returns>The provided <paramref name="builder"/>.</returns>
-   [Obsolete("Use 'UseThinktectureValueConverters' instead.")]
-   public static DbContextOptionsBuilder<T> UseValueObjectValueConverter<T>(
-      this DbContextOptionsBuilder<T> builder,
-      bool useThinktectureConverters = true,
-      bool useConstructorForRead = true,
-      Action<IConventionProperty>? configureEnumsAndKeyedValueObjects = null)
-      where T : DbContext
-   {
-      return builder.UseThinktectureValueConverters(useThinktectureConverters, useConstructorForRead, configureEnumsAndKeyedValueObjects);
-   }
-
-   /// <summary>
-   /// Enables automatic configuration of <see cref="ValueConverter"/> for Smart Enums and Value Objects.
-   /// </summary>
-   /// <param name="builder">Options builder.</param>
-   /// <param name="useThinktectureConverters">Indication whether to enable or disable the feature.</param>
-   /// <param name="useConstructorForRead">For keyed value objects only. Use the constructor instead of the factory method when reading the data from a database.</param>
-   /// <param name="configureEnumsAndKeyedValueObjects">Action for further configuration of the property.</param>
-   /// <returns>The provided <paramref name="builder"/>.</returns>
-   [Obsolete("Use 'UseThinktectureValueConverters' instead.")]
-   public static DbContextOptionsBuilder UseValueObjectValueConverter(
-      this DbContextOptionsBuilder builder,
-      bool useThinktectureConverters = true,
-      bool useConstructorForRead = true,
-      Action<IConventionProperty>? configureEnumsAndKeyedValueObjects = null)
-   {
-      return builder.UseThinktectureValueConverters(useThinktectureConverters, useConstructorForRead, configureEnumsAndKeyedValueObjects);
-   }
-
    /// <summary>
    /// Enables automatic configuration of <see cref="ValueConverter"/> for Smart Enums and Value Objects.
    /// </summary>