Skip to content

Commit d9bb6e3

Browse files
Use invariant culture for culture specific unit tests
1 parent dbce23e commit d9bb6e3

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

test/Thinktecture.Runtime.Extensions.Json.Tests/Text/Json/Serialization/ThinktectureJsonConverterFactoryTests/RoundTrip.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,12 @@ public void Should_deserialize_ulong_from_string_with_corresponding_NumberHandli
148148
public void Should_deserialize_float_from_string_with_corresponding_NumberHandling(float number)
149149
{
150150
var numberJson = number.ToString(CultureInfo.InvariantCulture);
151-
var numberAsStringJson = $"\"{number}\"";
151+
var numberAsStringJson = $"\"{numberJson}\"";
152152
var obj = TestValueObjectFloat.Create(number);
153153

154154
Serialize<TestValueObjectFloat, float>(obj).Should().Be(numberJson);
155155
Serialize<TestValueObjectFloat, float>(obj, numberHandling: JsonNumberHandling.WriteAsString).Should().Be(numberAsStringJson);
156-
Deserialize<TestValueObjectFloat>($"\"{number}\"", numberHandling: JsonNumberHandling.AllowReadingFromString).Should().Be(obj);
156+
Deserialize<TestValueObjectFloat>($"\"{numberJson}\"", numberHandling: JsonNumberHandling.AllowReadingFromString).Should().Be(obj);
157157
}
158158

159159
[Theory]
@@ -167,12 +167,12 @@ public void Should_deserialize_float_from_string_with_corresponding_NumberHandli
167167
public void Should_deserialize_double_from_string_with_corresponding_NumberHandling(double number)
168168
{
169169
var numberJson = number.ToString(CultureInfo.InvariantCulture);
170-
var numberAsStringJson = $"\"{number}\"";
170+
var numberAsStringJson = $"\"{numberJson}\"";
171171
var obj = TestValueObjectDouble.Create(number);
172172

173173
Serialize<TestValueObjectDouble, double>(obj).Should().Be(numberJson);
174174
Serialize<TestValueObjectDouble, double>(obj, numberHandling: JsonNumberHandling.WriteAsString).Should().Be(numberAsStringJson);
175-
Deserialize<TestValueObjectDouble>($"\"{number}\"", numberHandling: JsonNumberHandling.AllowReadingFromString).Should().Be(obj);
175+
Deserialize<TestValueObjectDouble>($"\"{numberJson}\"", numberHandling: JsonNumberHandling.AllowReadingFromString).Should().Be(obj);
176176
}
177177

178178
[Theory]
@@ -189,12 +189,12 @@ public void Should_deserialize_decimal_from_string_with_corresponding_NumberHand
189189
var number = decimals[index];
190190

191191
var numberJson = number.ToString(CultureInfo.InvariantCulture);
192-
var numberAsStringJson = $"\"{number}\"";
192+
var numberAsStringJson = $"\"{numberJson}\"";
193193
var obj = TestValueObjectDecimal.Create(number);
194194

195195
Serialize<TestValueObjectDecimal, decimal>(obj).Should().Be(numberJson);
196196
Serialize<TestValueObjectDecimal, decimal>(obj, numberHandling: JsonNumberHandling.WriteAsString).Should().Be(numberAsStringJson);
197-
Deserialize<TestValueObjectDecimal>($"\"{number}\"", numberHandling: JsonNumberHandling.AllowReadingFromString).Should().Be(obj);
197+
Deserialize<TestValueObjectDecimal>($"\"{numberJson}\"", numberHandling: JsonNumberHandling.AllowReadingFromString).Should().Be(obj);
198198
}
199199

200200
[Fact]

test/Thinktecture.Runtime.Extensions.Tests/EnumTests/Parse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public void Should_parse_valid_value()
1111
{
1212
SmartEnum_DecimalBased.Parse("1", null).Should().Be(SmartEnum_DecimalBased.Value1);
1313

14-
SmartEnum_DecimalBased.Parse("1.0", null).Should().Be(SmartEnum_DecimalBased.Value1);
14+
SmartEnum_DecimalBased.Parse("1.0", CultureInfo.InvariantCulture).Should().Be(SmartEnum_DecimalBased.Value1);
1515
}
1616

1717
#if NET9_0_OR_GREATER

test/Thinktecture.Runtime.Extensions.Tests/EnumTests/TryParse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public void Should_parse_valid_value()
1212
SmartEnum_DecimalBased.TryParse("1", null, out var item).Should().BeTrue();
1313
item.Should().Be(SmartEnum_DecimalBased.Value1);
1414

15-
SmartEnum_DecimalBased.TryParse("1.0", null, out item).Should().BeTrue();
15+
SmartEnum_DecimalBased.TryParse("1.0", CultureInfo.InvariantCulture, out item).Should().BeTrue();
1616
item.Should().Be(SmartEnum_DecimalBased.Value1);
1717

1818
SmartEnum_CaseSensitive.TryParse("item", null, out var caseSensitiveItem).Should().BeTrue();

test/Thinktecture.Runtime.Extensions.Tests/ValueObjectTests/Parse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public void Should_parse_valid_value()
1111
{
1212
DecimalBasedClassValueObject.Parse("1", null).Should().Be(DecimalBasedClassValueObject.Create(1));
1313

14-
DecimalBasedClassValueObject.Parse("1.0", null).Should().Be(DecimalBasedClassValueObject.Create(1));
14+
DecimalBasedClassValueObject.Parse("1.0", CultureInfo.InvariantCulture).Should().Be(DecimalBasedClassValueObject.Create(1));
1515
}
1616

1717
[Fact]

test/Thinktecture.Runtime.Extensions.Tests/ValueObjectTests/TryParse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public void Should_parse_valid_value()
1212
DecimalBasedClassValueObject.TryParse("1", null, out var item).Should().BeTrue();
1313
item.Should().Be(DecimalBasedClassValueObject.Create(1));
1414

15-
DecimalBasedClassValueObject.TryParse("1.0", null, out item).Should().BeTrue();
15+
DecimalBasedClassValueObject.TryParse("1.0", CultureInfo.InvariantCulture, out item).Should().BeTrue();
1616
item.Should().Be(DecimalBasedClassValueObject.Create(1));
1717
}
1818

0 commit comments

Comments
 (0)