use constants in source gen projects

PawelGerr · PawelGerr · commit e7c65551135b · 2026-02-28T11:19:47.000+01:00
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/AdHocUnions/AdHocUnionCodeGenerator.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/AdHocUnions/AdHocUnionCodeGenerator.cs
@@ -462,7 +462,7 @@ private void GenerateSwitchForAction(bool withState, bool isPartially)
 
       _sb.Append(@"
       [global::System.Diagnostics.DebuggerStepThroughAttribute]
-      public void ").Append(isPartially ? "SwitchPartially" : "Switch");
+      public void ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);
 
       if (withState)
       {
@@ -631,7 +631,7 @@ private void GenerateSwitchForFunc(bool withState, bool isPartially)
 
       _sb.Append(@"
       [global::System.Diagnostics.DebuggerStepThroughAttribute]
-      public TResult ").Append(isPartially ? "SwitchPartially" : "Switch");
+      public TResult ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);
 
       if (withState)
       {
@@ -795,7 +795,7 @@ private void GenerateMap(bool isPartially)
 
       _sb.Append(@"
       [global::System.Diagnostics.DebuggerStepThroughAttribute]
-      public TResult ").Append(isPartially ? "MapPartially" : "Map").Append("<TResult>(");
+      public TResult ").Append(isPartially ? Constants.Methods.MAP_PARTIALLY : Constants.Methods.MAP).Append("<TResult>(");
 
       if (isPartially)
       {
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/CodeFixes/ThinktectureRuntimeExtensionsCodeFixProvider.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/CodeFixes/ThinktectureRuntimeExtensionsCodeFixProvider.cs
@@ -497,7 +497,7 @@ private static async Task<Document> GenerateValidateMethodAsync(
 
          var methodBody = SyntaxFactory.Block(BuildThrowNotImplementedException(false));
 
-         var validateMethod = SyntaxFactory.MethodDeclaration(returnType, "Validate")
+         var validateMethod = SyntaxFactory.MethodDeclaration(returnType, Constants.Methods.VALIDATE)
                                            .WithModifiers(SyntaxFactory.TokenList(
                                                              SyntaxFactory.Token(SyntaxKind.PublicKeyword),
                                                              SyntaxFactory.Token(SyntaxKind.StaticKeyword)))
@@ -553,7 +553,7 @@ private static async Task<Document> GenerateToValueMethodAsync(
 
          var methodBody = SyntaxFactory.Block(BuildThrowNotImplementedException(false));
 
-         var toValueMethod = SyntaxFactory.MethodDeclaration(valueTypeName, "ToValue")
+         var toValueMethod = SyntaxFactory.MethodDeclaration(valueTypeName, Constants.Methods.TO_VALUE)
                                           .WithModifiers(SyntaxFactory.TokenList(SyntaxFactory.Token(SyntaxKind.PublicKeyword)))
                                           .WithParameterList(SyntaxFactory.ParameterList())
                                           .WithBody(methodBody)
@@ -848,7 +848,7 @@ private static async Task<Document> UseStateOverloadAsync(
 
       // State argument (first)
       var stateArg = SyntaxFactory.Argument(
-         SyntaxFactory.NameColon("state"),
+         SyntaxFactory.NameColon(Constants.Parameters.STATE),
          default,
          stateExpression);
       newArguments.Add(stateArg);
@@ -904,13 +904,13 @@ private static LambdaExpressionSyntax TransformLambdaForStateOverload(
 
          if (captures.Count == 1)
          {
-            replacement = SyntaxFactory.IdentifierName("state").WithTriviaFrom(identifier);
+            replacement = SyntaxFactory.IdentifierName(Constants.Parameters.STATE).WithTriviaFrom(identifier);
          }
          else
          {
             replacement = SyntaxFactory.MemberAccessExpression(
                SyntaxKind.SimpleMemberAccessExpression,
-               SyntaxFactory.IdentifierName("state"),
+               SyntaxFactory.IdentifierName(Constants.Parameters.STATE),
                SyntaxFactory.IdentifierName(identifier.Identifier.Text)).WithTriviaFrom(identifier);
          }
 
@@ -932,7 +932,7 @@ private static LambdaExpressionSyntax TransformLambdaForStateOverload(
       }
 
       // Step 3: Add state parameter
-      var stateParam = SyntaxFactory.Parameter(SyntaxFactory.Identifier("state"));
+      var stateParam = SyntaxFactory.Parameter(SyntaxFactory.Identifier(Constants.Parameters.STATE));
 
       if (transformedLambda is SimpleLambdaExpressionSyntax simple)
       {
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Constants.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Constants.cs
@@ -36,8 +36,28 @@ public static class ComparerAccessor
 
    public static class Methods
    {
-      public const string VALIDATE_FACTORY_ARGUMENTS = "ValidateFactoryArguments";
+      public const string CREATE = "Create";
+      public const string FACTORY_POST_INIT = "FactoryPostInit";
       public const string GET = "Get";
+      public const string MAP = "Map";
+      public const string MAP_PARTIALLY = "MapPartially";
+      public const string SWITCH = "Switch";
+      public const string SWITCH_PARTIALLY = "SwitchPartially";
+      public const string TO_STRING = "ToString";
+      public const string TO_VALUE = "ToValue";
+      public const string TRY_CREATE = "TryCreate";
+      public const string VALIDATE = "Validate";
+      public const string VALIDATE_FACTORY_ARGUMENTS = "ValidateFactoryArguments";
+   }
+
+   public static class Parameters
+   {
+      public const string STATE = "state";
+   }
+
+   public static class Variables
+   {
+      public const string FACTORY_ARGUMENTS_VALIDATION_ERROR = "factoryArgumentsValidationError";
    }
 
    public static class Configuration
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs
@@ -8,9 +8,6 @@ namespace Thinktecture.CodeAnalysis.Diagnostics;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public sealed class ThinktectureRuntimeExtensionsAnalyzer : DiagnosticAnalyzer
 {
-   private const string _SWITCH_PARTIALLY = "SwitchPartially";
-   private const string _MAP_PARTIALLY = "MapPartially";
-
    /// <inheritdoc />
    public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
    [
@@ -414,10 +411,10 @@ private static void AnalyzeMethodCall(OperationAnalysisContext context)
       if (operation.Instance is null
           || operation.Arguments.IsDefaultOrEmpty
           || operation.TargetMethod.IsStatic
-          || (operation.TargetMethod.Name != "Switch"
-              && operation.TargetMethod.Name != _SWITCH_PARTIALLY
-              && operation.TargetMethod.Name != "Map"
-              && operation.TargetMethod.Name != _MAP_PARTIALLY))
+          || (operation.TargetMethod.Name != Constants.Methods.SWITCH
+              && operation.TargetMethod.Name != Constants.Methods.SWITCH_PARTIALLY
+              && operation.TargetMethod.Name != Constants.Methods.MAP
+              && operation.TargetMethod.Name != Constants.Methods.MAP_PARTIALLY))
       {
          return;
       }
@@ -445,7 +442,7 @@ private static void AnalyzeMethodCall(OperationAnalysisContext context)
          return;
       }
 
-      if (operation.TargetMethod.Name is "Switch" or _SWITCH_PARTIALLY)
+      if (operation.TargetMethod.Name is Constants.Methods.SWITCH or Constants.Methods.SWITCH_PARTIALLY)
       {
          AnalyzeSwitchMapLambdas(context, operation);
       }
@@ -458,7 +455,7 @@ private static void AnalyzeEnumSwitchMap(
       IInvocationOperation operation)
    {
       var numberOfCallbacks = (items.IsDefaultOrEmpty ? 0 : items.Length)
-                              + (operation.TargetMethod.Name is _SWITCH_PARTIALLY or _MAP_PARTIALLY ? 1 : 0);
+                              + (operation.TargetMethod.Name is Constants.Methods.SWITCH_PARTIALLY or Constants.Methods.MAP_PARTIALLY ? 1 : 0);
 
       AnalyzeSwitchMap(context, args, operation, numberOfCallbacks);
    }
@@ -471,7 +468,7 @@ private static void AnalyzeAnyUnionSwitchMap(
       var numberOfCallbacks = operation.TargetMethod.Parameters.IsDefaultOrEmpty ? 0 : operation.TargetMethod.Parameters.Length;
 
       if (numberOfCallbacks > 0
-          && operation.TargetMethod.Parameters[0].Name == "state")
+          && operation.TargetMethod.Parameters[0].Name == Constants.Parameters.STATE)
       {
          numberOfCallbacks--;
       }
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/RegularUnions/RegularUnionCodeGenerator.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/RegularUnions/RegularUnionCodeGenerator.cs
@@ -256,7 +256,7 @@ private void GenerateSwitchForAction(bool withState, bool isPartially, IReadOnly
 
       _sb.Append(@"
    [global::System.Diagnostics.DebuggerStepThroughAttribute]
-   public void ").Append(isPartially ? "SwitchPartially" : "Switch");
+   public void ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);
 
       if (withState)
       {
@@ -417,7 +417,7 @@ private void GenerateSwitchForFunc(bool withState, bool isPartially, IReadOnlyLi
 
       _sb.Append(@"
    [global::System.Diagnostics.DebuggerStepThroughAttribute]
-   public TResult ").Append(isPartially ? "SwitchPartially" : "Switch");
+   public TResult ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);
 
       if (withState)
       {
@@ -572,7 +572,7 @@ private void GenerateMap(bool isPartially, IReadOnlyList<TypeMember> typeMembers
 
       _sb.Append(@"
    [global::System.Diagnostics.DebuggerStepThroughAttribute]
-   public TResult ").Append(isPartially ? "MapPartially" : "Map").Append("<TResult>(");
+   public TResult ").Append(isPartially ? Constants.Methods.MAP_PARTIALLY : Constants.Methods.MAP).Append("<TResult>(");
 
       if (isPartially)
       {
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/SmartEnums/SmartEnumCodeGenerator.cs
@@ -445,7 +445,7 @@ private void GenerateSwitchForAction(bool withState, bool isPartially)
 
       _sb.Append(@"
       [global::System.Diagnostics.DebuggerStepThroughAttribute]
-      public void ").Append(isPartially ? "SwitchPartially" : "Switch");
+      public void ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);
 
       if (withState)
       {
@@ -588,7 +588,7 @@ private void GenerateSwitchForFunc(bool withState, bool isPartially)
 
       _sb.Append(@"
       [global::System.Diagnostics.DebuggerStepThroughAttribute]
-      public TResult ").Append(isPartially ? "SwitchPartially" : "Switch");
+      public TResult ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);
 
       if (withState)
       {
@@ -726,7 +726,7 @@ private void GenerateMap(bool isPartially)
 
       _sb.Append(@"
       [global::System.Diagnostics.DebuggerStepThroughAttribute]
-      public TResult ").Append(isPartially ? "MapPartially" : "Map").Append("<TResult>(");
+      public TResult ").Append(isPartially ? Constants.Methods.MAP_PARTIALLY : Constants.Methods.MAP).Append("<TResult>(");
 
       if (isPartially)
       {
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/TypedMemberState.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/TypedMemberState.cs
@@ -152,7 +152,7 @@ public TypedMemberState(ITypeSymbol type)
 
    private static bool IsToStringNullable(ITypeSymbol type)
    {
-      var array = type.GetMembers("ToString");
+      var array = type.GetMembers(Constants.Methods.TO_STRING);
 
       for (var i = 0; i < array.Length; i++)
       {
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/AllValueObjectSettings.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/AllValueObjectSettings.cs
@@ -42,8 +42,8 @@ public AllValueObjectSettings(
       SkipKeyMember = valueObjectAttribute.FindSkipKeyMember() ?? false;
       SkipFactoryMethods = valueObjectAttribute.FindSkipFactoryMethods() ?? false;
       ConstructorAccessModifier = valueObjectAttribute.FindConstructorAccessModifier() ?? Constants.ValueObject.DEFAULT_CONSTRUCTOR_ACCESS_MODIFIER;
-      CreateFactoryMethodName = valueObjectAttribute.FindCreateFactoryMethodName() ?? "Create";
-      TryCreateFactoryMethodName = valueObjectAttribute.FindTryCreateFactoryMethodName() ?? "TryCreate";
+      CreateFactoryMethodName = valueObjectAttribute.FindCreateFactoryMethodName() ?? Constants.Methods.CREATE;
+      TryCreateFactoryMethodName = valueObjectAttribute.FindTryCreateFactoryMethodName() ?? Constants.Methods.TRY_CREATE;
       EmptyStringInFactoryMethodsYieldsNull = hasStringKey && (valueObjectAttribute.FindEmptyStringInFactoryMethodsYieldsNull() ?? false);
       NullInFactoryMethodsYieldsNull = EmptyStringInFactoryMethodsYieldsNull || (valueObjectAttribute.FindNullInFactoryMethodsYieldsNull() ?? false);
       SkipIComparable = valueObjectAttribute.FindSkipIComparable() ?? false;
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/ComplexValueObjectCodeGenerator.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/ComplexValueObjectCodeGenerator.cs
@@ -4,9 +4,6 @@ namespace Thinktecture.CodeAnalysis.ValueObjects;
 
 public sealed class ComplexValueObjectCodeGenerator : SmartEnumAndValueObjectCodeGeneratorBase
 {
-   private const string _FACTORY_ARGUMENTS_VALIDATION_ERROR = "factoryArgumentsValidationError";
-   private const string _FACTORY_POST_INIT = "FactoryPostInit";
-
    private readonly ComplexValueObjectSourceGeneratorState _state;
    private readonly StringBuilder _sb;
 
@@ -56,7 +53,7 @@ private void GenerateValueObject(CancellationToken cancellationToken)
 
       if (!_state.Settings.SkipEqualityComparison)
       {
-          _sb.Append(@"
+         _sb.Append(@"
       global::System.IEquatable<").AppendTypeFullyQualifiedNullAnnotated(_state).Append(@">,
       global::System.Numerics.IEqualityOperators<").AppendTypeFullyQualified(_state).Append(", ").AppendTypeFullyQualified(_state).Append(", bool>,");
       }
@@ -114,9 +111,9 @@ private void GenerateValueObject(CancellationToken cancellationToken)
 
       if (!_state.Settings.SkipEqualityComparison)
       {
-          GenerateEqualityOperators();
-          GenerateEquals();
-          GenerateGetHashCode();
+         GenerateEqualityOperators();
+         GenerateEquals();
+         GenerateGetHashCode();
       }
 
       if (!_state.Settings.SkipToString)
@@ -319,7 +316,7 @@ private void GenerateValidateMethod()
          ");
 
       if (_state.FactoryValidationReturnType is not null)
-         _sb.Append("var ").Append(_FACTORY_ARGUMENTS_VALIDATION_ERROR).Append(" = ");
+         _sb.Append("var ").Append(Constants.Variables.FACTORY_ARGUMENTS_VALIDATION_ERROR).Append(" = ");
 
       _sb.Append(Constants.Methods.VALIDATE_FACTORY_ARGUMENTS).Append(@"(
             ref validationError").RenderArguments(fieldsAndProperties, @"
@@ -332,10 +329,10 @@ private void GenerateValidateMethod()
       GenerateConstructCall();
 
       _sb.Append(@";
-            obj.").Append(_FACTORY_POST_INIT).Append("(");
+            obj.").Append(Constants.Methods.FACTORY_POST_INIT).Append("(");
 
       if (_state.FactoryValidationReturnType is not null)
-         _sb.Append(_FACTORY_ARGUMENTS_VALIDATION_ERROR);
+         _sb.Append(Constants.Variables.FACTORY_ARGUMENTS_VALIDATION_ERROR);
 
       _sb.Append(@");
          }
@@ -372,10 +369,10 @@ private void GenerateFactoryPostInit()
    {
       _sb.Append(@"
 
-      partial void ").Append(_FACTORY_POST_INIT).Append("(");
+      partial void ").Append(Constants.Methods.FACTORY_POST_INIT).Append("(");
 
       if (_state.FactoryValidationReturnType is not null)
-         _sb.Append(_state.FactoryValidationReturnType).Append(" ").Append(_FACTORY_ARGUMENTS_VALIDATION_ERROR);
+         _sb.Append(_state.FactoryValidationReturnType).Append(" ").Append(Constants.Variables.FACTORY_ARGUMENTS_VALIDATION_ERROR);
 
       _sb.Append(");");
    }
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/KeyedValueObjectCodeGenerator.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/ValueObjects/KeyedValueObjectCodeGenerator.cs
@@ -4,9 +4,6 @@ namespace Thinktecture.CodeAnalysis.ValueObjects;
 
 public sealed class KeyedValueObjectCodeGenerator : SmartEnumAndValueObjectCodeGeneratorBase
 {
-   private const string _FACTORY_ARGUMENTS_VALIDATION_ERROR = "factoryArgumentsValidationError";
-   private const string _FACTORY_POST_INIT = "FactoryPostInit";
-
    private readonly KeyedValueObjectSourceGeneratorState _state;
    private readonly StringBuilder _sb;
 
@@ -414,7 +411,7 @@ private void GenerateValidateMethod(bool allowNullKeyMemberInput, bool allowNull
          ");
 
       if (_state.FactoryValidationReturnType is not null)
-         _sb.Append("var ").Append(_FACTORY_ARGUMENTS_VALIDATION_ERROR).Append(" = ");
+         _sb.Append("var ").Append(Constants.Variables.FACTORY_ARGUMENTS_VALIDATION_ERROR).Append(" = ");
 
       _sb.Append(Constants.Methods.VALIDATE_FACTORY_ARGUMENTS).Append("(ref validationError, ").RenderArgument(_state.KeyMember, "ref ").Append(@");
 
@@ -425,10 +422,10 @@ private void GenerateValidateMethod(bool allowNullKeyMemberInput, bool allowNull
       GenerateConstructCall();
 
       _sb.Append(@";
-            obj.").Append(_FACTORY_POST_INIT).Append("(");
+            obj.").Append(Constants.Methods.FACTORY_POST_INIT).Append("(");
 
       if (_state.FactoryValidationReturnType is not null)
-         _sb.Append(_FACTORY_ARGUMENTS_VALIDATION_ERROR);
+         _sb.Append(Constants.Variables.FACTORY_ARGUMENTS_VALIDATION_ERROR);
 
       _sb.Append(@");
          }
@@ -457,10 +454,10 @@ private void GenerateFactoryPostInit()
    {
       _sb.Append(@"
 
-      partial void ").Append(_FACTORY_POST_INIT).Append("(");
+      partial void ").Append(Constants.Methods.FACTORY_POST_INIT).Append("(");
 
       if (_state.FactoryValidationReturnType is not null)
-         _sb.Append(_state.FactoryValidationReturnType).Append(" ").Append(_FACTORY_ARGUMENTS_VALIDATION_ERROR);
+         _sb.Append(_state.FactoryValidationReturnType).Append(" ").Append(Constants.Variables.FACTORY_ARGUMENTS_VALIDATION_ERROR);
 
       _sb.Append(");");
    }
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/Extensions/AttributeDataExtensions.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/Extensions/AttributeDataExtensions.cs
@@ -250,7 +250,7 @@ public static bool FindHasCorrespondingConstructor(this AttributeData attributeD
 
    public static string FindSwitchMapStateParameterName(this AttributeData attributeData)
    {
-      return GetStringParameterValue(attributeData, Constants.Attributes.Properties.SWITCH_MAP_STATE_PARAMETER_NAME) ?? "state";
+      return GetStringParameterValue(attributeData, Constants.Attributes.Properties.SWITCH_MAP_STATE_PARAMETER_NAME) ?? Constants.Parameters.STATE;
    }
 
    public static NestedUnionParameterNameGeneration FindNestedUnionParameterNameGeneration(
diff --git a/src/Thinktecture.Runtime.Extensions.SourceGenerator/Extensions/TypeSymbolExtensions.cs b/src/Thinktecture.Runtime.Extensions.SourceGenerator/Extensions/TypeSymbolExtensions.cs
@@ -1120,7 +1120,7 @@ public static bool HasValidateMethod(
             {
                var interfaceMember = method.ExplicitInterfaceImplementations[j];
 
-               if (interfaceMember.Name == "Validate"
+               if (interfaceMember.Name == Constants.Methods.VALIDATE
                    && interfaceMember.ContainingType.IsObjectFactoryInterface()
                    && SymbolEqualityComparer.Default.Equals(interfaceMember.ContainingType.TypeArguments[0], objectType)
                    && SymbolEqualityComparer.Default.Equals(interfaceMember.ContainingType.TypeArguments[1], valueType)
@@ -1137,7 +1137,7 @@ public static bool HasValidateMethod(
             if (!foundInterface)
                continue;
          }
-         else if (method.MethodKind != MethodKind.Ordinary || method.Name != "Validate")
+         else if (method.MethodKind != MethodKind.Ordinary || method.Name != Constants.Methods.VALIDATE)
          {
             continue;
          }
@@ -1203,7 +1203,7 @@ public static bool HasToValueMethod(
             {
                var interfaceMember = method.ExplicitInterfaceImplementations[j];
 
-               if (interfaceMember.Name == "ToValue"
+               if (interfaceMember.Name == Constants.Methods.TO_VALUE
                    && interfaceMember.ContainingType.IsConvertibleInterface()
                    && SymbolEqualityComparer.Default.Equals(interfaceMember.ContainingType.TypeArguments[0], valueType)
                    && objectType.FindImplementationForInterfaceMember(interfaceMember) is not null)
@@ -1216,7 +1216,7 @@ public static bool HasToValueMethod(
             if (!foundInterface)
                continue;
          }
-         else if (method.MethodKind != MethodKind.Ordinary || method.Name != "ToValue")
+         else if (method.MethodKind != MethodKind.Ordinary || method.Name != Constants.Methods.TO_VALUE)
          {
             continue;
          }

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ private void GenerateSwitchForAction(bool withState, bool isPartially)`
`462`	`462`
`463`	`463`	`_sb.Append(@"`
`464`	`464`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`465`		`- public void ").Append(isPartially ? "SwitchPartially" : "Switch");`
	`465`	`+ public void ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);`
`466`	`466`
`467`	`467`	`if (withState)`
`468`	`468`	`{`
`@@ -631,7 +631,7 @@ private void GenerateSwitchForFunc(bool withState, bool isPartially)`
`631`	`631`
`632`	`632`	`_sb.Append(@"`
`633`	`633`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`634`		`- public TResult ").Append(isPartially ? "SwitchPartially" : "Switch");`
	`634`	`+ public TResult ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);`
`635`	`635`
`636`	`636`	`if (withState)`
`637`	`637`	`{`
`@@ -795,7 +795,7 @@ private void GenerateMap(bool isPartially)`
`795`	`795`
`796`	`796`	`_sb.Append(@"`
`797`	`797`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`798`		`- public TResult ").Append(isPartially ? "MapPartially" : "Map").Append("<TResult>(");`
	`798`	`+ public TResult ").Append(isPartially ? Constants.Methods.MAP_PARTIALLY : Constants.Methods.MAP).Append("<TResult>(");`
`799`	`799`
`800`	`800`	`if (isPartially)`
`801`	`801`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,6 @@ namespace Thinktecture.CodeAnalysis.Diagnostics;`
`8`	`8`	`[DiagnosticAnalyzer(LanguageNames.CSharp)]`
`9`	`9`	`public sealed class ThinktectureRuntimeExtensionsAnalyzer : DiagnosticAnalyzer`
`10`	`10`	`{`
`11`		`- private const string _SWITCH_PARTIALLY = "SwitchPartially";`
`12`		`- private const string _MAP_PARTIALLY = "MapPartially";`
`13`		`-`
`14`	`11`	`/// <inheritdoc />`
`15`	`12`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =`
`16`	`13`	`[`
`@@ -414,10 +411,10 @@ private static void AnalyzeMethodCall(OperationAnalysisContext context)`
`414`	`411`	`if (operation.Instance is null`
`415`	`412`	`\|\| operation.Arguments.IsDefaultOrEmpty`
`416`	`413`	`\|\| operation.TargetMethod.IsStatic`
`417`		`- \|\| (operation.TargetMethod.Name != "Switch"`
`418`		`- && operation.TargetMethod.Name != _SWITCH_PARTIALLY`
`419`		`- && operation.TargetMethod.Name != "Map"`
`420`		`- && operation.TargetMethod.Name != _MAP_PARTIALLY))`
	`414`	`+ \|\| (operation.TargetMethod.Name != Constants.Methods.SWITCH`
	`415`	`+ && operation.TargetMethod.Name != Constants.Methods.SWITCH_PARTIALLY`
	`416`	`+ && operation.TargetMethod.Name != Constants.Methods.MAP`
	`417`	`+ && operation.TargetMethod.Name != Constants.Methods.MAP_PARTIALLY))`
`421`	`418`	`{`
`422`	`419`	`return;`
`423`	`420`	`}`
`@@ -445,7 +442,7 @@ private static void AnalyzeMethodCall(OperationAnalysisContext context)`
`445`	`442`	`return;`
`446`	`443`	`}`
`447`	`444`
`448`		`- if (operation.TargetMethod.Name is "Switch" or _SWITCH_PARTIALLY)`
	`445`	`+ if (operation.TargetMethod.Name is Constants.Methods.SWITCH or Constants.Methods.SWITCH_PARTIALLY)`
`449`	`446`	`{`
`450`	`447`	`AnalyzeSwitchMapLambdas(context, operation);`
`451`	`448`	`}`
`@@ -458,7 +455,7 @@ private static void AnalyzeEnumSwitchMap(`
`458`	`455`	`IInvocationOperation operation)`
`459`	`456`	`{`
`460`	`457`	`var numberOfCallbacks = (items.IsDefaultOrEmpty ? 0 : items.Length)`
`461`		`- + (operation.TargetMethod.Name is _SWITCH_PARTIALLY or _MAP_PARTIALLY ? 1 : 0);`
	`458`	`+ + (operation.TargetMethod.Name is Constants.Methods.SWITCH_PARTIALLY or Constants.Methods.MAP_PARTIALLY ? 1 : 0);`
`462`	`459`
`463`	`460`	`AnalyzeSwitchMap(context, args, operation, numberOfCallbacks);`
`464`	`461`	`}`
`@@ -471,7 +468,7 @@ private static void AnalyzeAnyUnionSwitchMap(`
`471`	`468`	`var numberOfCallbacks = operation.TargetMethod.Parameters.IsDefaultOrEmpty ? 0 : operation.TargetMethod.Parameters.Length;`
`472`	`469`
`473`	`470`	`if (numberOfCallbacks > 0`
`474`		`- && operation.TargetMethod.Parameters[0].Name == "state")`
	`471`	`+ && operation.TargetMethod.Parameters[0].Name == Constants.Parameters.STATE)`
`475`	`472`	`{`
`476`	`473`	`numberOfCallbacks--;`
`477`	`474`	`}`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ private void GenerateSwitchForAction(bool withState, bool isPartially, IReadOnly`
`256`	`256`
`257`	`257`	`_sb.Append(@"`
`258`	`258`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`259`		`- public void ").Append(isPartially ? "SwitchPartially" : "Switch");`
	`259`	`+ public void ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);`
`260`	`260`
`261`	`261`	`if (withState)`
`262`	`262`	`{`
`@@ -417,7 +417,7 @@ private void GenerateSwitchForFunc(bool withState, bool isPartially, IReadOnlyLi`
`417`	`417`
`418`	`418`	`_sb.Append(@"`
`419`	`419`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`420`		`- public TResult ").Append(isPartially ? "SwitchPartially" : "Switch");`
	`420`	`+ public TResult ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);`
`421`	`421`
`422`	`422`	`if (withState)`
`423`	`423`	`{`
`@@ -572,7 +572,7 @@ private void GenerateMap(bool isPartially, IReadOnlyList<TypeMember> typeMembers`
`572`	`572`
`573`	`573`	`_sb.Append(@"`
`574`	`574`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`575`		`- public TResult ").Append(isPartially ? "MapPartially" : "Map").Append("<TResult>(");`
	`575`	`+ public TResult ").Append(isPartially ? Constants.Methods.MAP_PARTIALLY : Constants.Methods.MAP).Append("<TResult>(");`
`576`	`576`
`577`	`577`	`if (isPartially)`
`578`	`578`	`{`
Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,7 @@ private void GenerateSwitchForAction(bool withState, bool isPartially)`
`445`	`445`
`446`	`446`	`_sb.Append(@"`
`447`	`447`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`448`		`- public void ").Append(isPartially ? "SwitchPartially" : "Switch");`
	`448`	`+ public void ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);`
`449`	`449`
`450`	`450`	`if (withState)`
`451`	`451`	`{`
`@@ -588,7 +588,7 @@ private void GenerateSwitchForFunc(bool withState, bool isPartially)`
`588`	`588`
`589`	`589`	`_sb.Append(@"`
`590`	`590`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`591`		`- public TResult ").Append(isPartially ? "SwitchPartially" : "Switch");`
	`591`	`+ public TResult ").Append(isPartially ? Constants.Methods.SWITCH_PARTIALLY : Constants.Methods.SWITCH);`
`592`	`592`
`593`	`593`	`if (withState)`
`594`	`594`	`{`
`@@ -726,7 +726,7 @@ private void GenerateMap(bool isPartially)`
`726`	`726`
`727`	`727`	`_sb.Append(@"`
`728`	`728`	`[global::System.Diagnostics.DebuggerStepThroughAttribute]`
`729`		`- public TResult ").Append(isPartially ? "MapPartially" : "Map").Append("<TResult>(");`
	`729`	`+ public TResult ").Append(isPartially ? Constants.Methods.MAP_PARTIALLY : Constants.Methods.MAP).Append("<TResult>(");`
`730`	`730`
`731`	`731`	`if (isPartially)`
`732`	`732`	`{`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ public TypedMemberState(ITypeSymbol type)`
`152`	`152`
`153`	`153`	`private static bool IsToStringNullable(ITypeSymbol type)`
`154`	`154`	`{`
`155`		`- var array = type.GetMembers("ToString");`
	`155`	`+ var array = type.GetMembers(Constants.Methods.TO_STRING);`
`156`	`156`
`157`	`157`	`for (var i = 0; i < array.Length; i++)`
`158`	`158`	`{`