Add XML documentation for default instance properties in complex value objects#13
Merged
PawelGerr merged 1 commit intoPawelGerr:masterfrom Sep 30, 2025
Merged
Conversation
kmskebo
force-pushed
the
feature/add-missing-xmldoc
branch
from
84496be to
103093c
Compare
Owner
|
@claude Review the pull request :) |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing XML documentation for default instance properties in complex value objects. The source generator was missing XML documentation comments for the default instance property when DefaultInstancePropertyName was customized in ComplexValueObjectAttribute, while regular value objects already had this documentation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ComplexValueObjectCodeGenerator.cs | Adds XML documentation generation for default instance properties in complex value objects |
| ValueObjectSourceGeneratorTests.Should_generate_complex_struct_with_custom_default_instance_property_name.verified.txt | Updates test verification to include the expected XML documentation comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When defining DefaultInstancePropertyName for ComplexValueObjectAttribute the generated default instance has no xml doc.
It however works fine for the ValueObject attribute so it seems like it has just been forgotten.