Skip TTRESG104 diagnostic for interface properties#18
Merged
Conversation
Interfaces cannot have `required` members in C#, so the diagnostic (and its code fix) should not fire for properties declared in interfaces. https://claude.ai/code/session_01GfG47CpoCK1fMQ3E5D9wR6
There was a problem hiding this comment.
Pull request overview
Updates TTRESG104 to avoid producing an invalid suggestion (required) for properties declared on interfaces, since interfaces can’t declare required members in C#.
Changes:
- Skip TTRESG104 analysis for properties whose containing type is an interface.
- Add an analyzer test case ensuring no diagnostic is reported for an interface property using a value object that disallows default values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/Thinktecture.Runtime.Extensions.SourceGenerator.Tests/AnalyzerAndCodeFixTests/TTRESG104_MembersDisallowingDefaultValuesMustBeRequired.cs |
Adds regression test to ensure TTRESG104 does not trigger on interface properties. |
src/Thinktecture.Runtime.Extensions.SourceGenerator/CodeAnalysis/Diagnostics/ThinktectureRuntimeExtensionsAnalyzer.cs |
Adds an early-return guard to skip TTRESG104 for interface-contained properties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interfaces cannot have
requiredmembers in C#, so the diagnostic(and its code fix) should not fire for properties declared in interfaces.
https://claude.ai/code/session_01GfG47CpoCK1fMQ3E5D9wR6