Skip to content

Commit d04161f

Browse files
security: add GitHub secret scanning config with test path exclusions
Created .github/secret_scanning.yml with empty paths-ignore list, which is the correct configuration for repositories with no test infrastructure. This ensures all files are scanned for secrets without over-exclusion. - Assessment confirmed zero test directories, files, or frameworks - Empty paths-ignore: [] follows GitHub best practices for repos without tests - Updated documentation to reflect implementation status Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 93e93c5 commit d04161f

2 files changed

Lines changed: 39 additions & 5 deletions

File tree

.github/secret_scanning.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
paths-ignore: []

docs/memory/secret-scanning.md

Lines changed: 38 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,13 @@ Verified that no non-test directories or files would be accidentally matched by
9696

9797
## Recommendation
9898

99-
**No `.github/secret_scanning.yml` configuration is needed at this time.**
99+
**Empty `.github/secret_scanning.yml` configuration created.**
100100

101101
Since this repository has no test infrastructure:
102102
1. There are no test fixtures, mock credentials, or seed data to exclude
103103
2. All source code should be scanned for secrets without exclusions
104-
3. When test infrastructure is added in the future, this assessment should be revisited
104+
3. An empty `paths-ignore: []` list correctly indicates no exclusions
105+
4. When test infrastructure is added in the future, this configuration should be updated
105106

106107
## Future Considerations
107108

@@ -134,6 +135,38 @@ This assessment was conducted using:
134135

135136
---
136137

137-
**Assessment Status:** Complete
138-
**Action Required:** None - no secret scanning configuration needed
139-
**Next Steps:** Review this assessment before closing the PR
138+
## Implementation
139+
140+
**Date Implemented:** 2026-03-05
141+
**File Created:** `.github/secret_scanning.yml`
142+
143+
### Configuration
144+
145+
```yaml
146+
paths-ignore: []
147+
```
148+
149+
### Justification
150+
151+
An empty `paths-ignore` list was intentionally chosen because:
152+
153+
1. ✅ **No test directories exist** - Comprehensive search found zero test infrastructure
154+
2. ✅ **No test files exist** - No `*.test.*` or `*.spec.*` files in the repository
155+
3. ✅ **No mock/fixture data** - No seed data, factories, or mock directories
156+
4. ✅ **Follows best practices** - Empty list is correct for repos with no tests, prevents over-exclusion
157+
5. ✅ **Maximum security** - All files will be scanned; no false negatives from overly broad patterns
158+
159+
### Pattern Rules Applied
160+
161+
- ❌ Did not add speculative patterns (no `test/**`, no `**/__tests__/**`)
162+
- ❌ Did not use broad wildcards (no `**/*test*/**`, no partial matches)
163+
- ❌ Did not exclude config files (no `*.config.*` patterns)
164+
- ❌ Did not exclude documentation or .env files
165+
- ✅ Created minimal, accurate configuration matching actual repo structure
166+
167+
---
168+
169+
**Assessment Status:** Complete ✅
170+
**Implementation Status:** Complete ✅
171+
**Action Required:** Commit and push configuration
172+
**Next Steps:** Convert draft PR to ready for review

0 commit comments

Comments
 (0)