Skip to content

Commit eed79f9

Browse files
committed
* Changed ce_cameratools_taunt_thirdperson -> ce_tplock_taunt_enable.
* Updated default values for tplock cvars.
1 parent 8fcd066 commit eed79f9

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

CastingEssentials/Modules/CameraTools.cpp

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,21 @@ CameraTools::CameraTools() :
3535
[](IConVar* var, const char* pOldValue, float flOldValue) { GetModule()->ToggleForceValidTarget(var, pOldValue, flOldValue); }),
3636
ce_cameratools_spec_player_alive("ce_cameratools_spec_player_alive", "1", FCVAR_NONE, "Prevents spectating dead players."),
3737

38-
ce_cameratools_taunt_thirdperson("ce_cameratools_taunt_thirdperson", "0", FCVAR_NONE, "Force the camera into thirdperson when taunting."),
39-
4038
ce_tplock_enable("ce_tplock_enable", "0", FCVAR_NONE, "Locks view angles in spec_mode 5 (thirdperson/chase) to always looking the same direction as the spectated player."),
39+
ce_tplock_taunt_enable("ce_tplock_taunt_enable", "0", FCVAR_NONE, "Force the camera into thirdperson tplock when taunting. Does not require ce_tplock_enable."),
4140

42-
ce_tplock_default_pos("ce_tplock_default_pos", "+18 -80 +20", FCVAR_NONE, "",
41+
ce_tplock_default_pos("ce_tplock_default_pos", "18 -80 20", FCVAR_NONE, "Camera x/y/z offset from ce_tplock_bone when tplock is active.",
4342
[](IConVar* var, const char* old, float) { ParseTPLockValuesInto(static_cast<ConVar*>(var), old, GetModule()->m_TPLockDefault.m_Pos); }),
44-
ce_tplock_default_angle("ce_tplock_default_angle", "0 ? 0", FCVAR_NONE, "",
43+
ce_tplock_default_angle("ce_tplock_default_angle", "*0.5 ? =0", FCVAR_NONE, "Camera angle offset (pitch/yaw/roll) from ce_tplock_bone when tplock is active. See wiki for more information.",
4544
[](IConVar* var, const char* old, float) { ParseTPLockValuesInto(static_cast<ConVar*>(var), old, GetModule()->m_TPLockDefault.m_Angle); }),
46-
ce_tplock_default_dps("ce_tplock_default_dps", "-1 -1 -1", FCVAR_NONE, "Max degrees per second for angle. Set < 0 to uncap.",
45+
ce_tplock_default_dps("ce_tplock_default_dps", "-1 -1 -1", FCVAR_NONE, "Max degrees per second for angle (pitch/yaw/roll) when tplock is active. Set < 0 to uncap.",
4746
[](IConVar* var, const char* old, float) { ParseTPLockValuesInto(static_cast<ConVar*>(var), old, GetModule()->m_TPLockDefault.m_DPS); }),
4847

49-
ce_tplock_taunt_pos("ce_tplock_taunt_pos", "+18 -80 +20", FCVAR_NONE, "",
48+
ce_tplock_taunt_pos("ce_tplock_taunt_pos", "0 -80 -15", FCVAR_NONE, "Camera x/y/z offset from ce_tplock_bone when taunting with taunt tplock enabled.",
5049
[](IConVar* var, const char* old, float) { ParseTPLockValuesInto(static_cast<ConVar*>(var), old, GetModule()->m_TPLockTaunt.m_Pos); }),
51-
ce_tplock_taunt_angle("ce_tplock_taunt_angle", "0 -180 0", FCVAR_NONE, "",
50+
ce_tplock_taunt_angle("ce_tplock_taunt_angle", "=15 180 =0", FCVAR_NONE, "Camera angle offset (pitch/yaw/roll) from ce_tplock_bone when taunting with taunt tplock enabled.",
5251
[](IConVar* var, const char* old, float) { ParseTPLockValuesInto(static_cast<ConVar*>(var), old, GetModule()->m_TPLockTaunt.m_Angle); }),
53-
ce_tplock_taunt_dps("ce_tplock_taunt_dps", "-1 -1 -1", FCVAR_NONE, "Max degrees per second for angle. Set < 0 to uncap.",
52+
ce_tplock_taunt_dps("ce_tplock_taunt_dps", "-1 -1 -1", FCVAR_NONE, "Max degrees per second for angle (pitch/yaw/roll) when taunting with taunt tplock enabled. Set < 0 to uncap.",
5453
[](IConVar* var, const char* old, float) { ParseTPLockValuesInto(static_cast<ConVar*>(var), old, GetModule()->m_TPLockTaunt.m_DPS); }),
5554

5655
ce_tplock_bone("ce_tplock_bone", "bip_spine_2", FCVAR_NONE, "Bone to attach camera position to. Enable developer 2 for associated warnings.",
@@ -617,7 +616,7 @@ void CameraTools::UpdateIsTaunting()
617616
{
618617
m_IsTaunting = false;
619618

620-
if (!ce_cameratools_taunt_thirdperson.GetBool())
619+
if (!ce_tplock_taunt_enable.GetBool())
621620
return;
622621

623622
if (auto mode = CameraState::GetLocalObserverMode();

CastingEssentials/Modules/CameraTools.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ class CameraTools final : public Module<CameraTools>, public ICameraOverride
3939

4040
ModeSwitchReason GetModeSwitchReason() const { return m_SwitchReason; }
4141

42+
protected:
43+
bool InToolModeOverride() const override;
44+
bool IsThirdPersonCameraOverride() const override { return m_IsTaunting; }
45+
bool SetupEngineViewOverride(Vector& origin, QAngle& angles, float& fov) override;
46+
4247
private:
4348
int m_SetModeHook;
4449
int m_SetPrimaryTargetHook;
@@ -54,9 +59,8 @@ class CameraTools final : public Module<CameraTools>, public ICameraOverride
5459
ConVar ce_cameratools_force_valid_target;
5560
ConVar ce_cameratools_spec_player_alive;
5661

57-
ConVar ce_cameratools_taunt_thirdperson;
58-
5962
ConVar ce_tplock_enable;
63+
ConVar ce_tplock_taunt_enable;
6064

6165
ConVar ce_tplock_default_pos;
6266
ConVar ce_tplock_default_angle;
@@ -134,9 +138,6 @@ class CameraTools final : public Module<CameraTools>, public ICameraOverride
134138

135139
Vector CalcPosForAngle(const TPLockRuleset& ruleset, const Vector& orbitCenter, const QAngle& angle) const;
136140

137-
bool InToolModeOverride() const override;
138-
bool IsThirdPersonCameraOverride() const override { return m_IsTaunting; }
139-
bool SetupEngineViewOverride(Vector& origin, QAngle& angles, float& fov) override;
140141
QAngle m_LastFrameAngle;
141142
Player* m_LastTargetPlayer;
142143

0 commit comments

Comments
 (0)