Skip to content

Commit aeded18

Browse files
committed
clang interesting warning fixes and error fix
1 parent 745a0dc commit aeded18

6 files changed

Lines changed: 7 additions & 7 deletions

File tree

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ before_script:
3535
- cmake -DCMAKE_BUILD_TYPE=Debug -DPR_USE_LTO=OFF -DPYBIND11_PYTHON_VERSION=$PYTHON ..
3636
script:
3737
- make $MAKE_FLAGS
38-
- make test || true
39-
- make coveralls || true
38+
after_success:
39+
- make test
40+
- make coveralls
4041
branches:
4142
only:
4243
- master

src/diagnostic/io/EXRFile.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
class EXRLayer : public ImageBufferView {
99
public:
1010
EXRLayer(const QString& name, size_t channels, size_t width, size_t height);
11-
~EXRLayer();
11+
virtual ~EXRLayer();
1212

1313
inline QVector<QVector<float>>& data() { return mData; }
1414
inline QVector<QString>& channelNames() { return mChannelNames; }

src/diagnostic/io/SpecFile.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
class SpecFile : public ImageBufferView {
99
public:
1010
SpecFile();
11-
~SpecFile();
11+
virtual ~SpecFile();
1212

1313
bool open(const QString& file);
1414

src/library/math/Tangent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ inline void invert_frame(Vector3f& N, Vector3f& Nx, Vector3f& Ny)
4141
{
4242
N = -N;
4343
Nx = -Nx;
44-
Ny = Ny;
44+
//Ny = Ny;
4545
}
4646

4747
template <typename T>

src/library/renderer/RenderThread.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,5 @@ class PR_LIB RenderThread : public Thread {
2525
RenderContext* mRenderer;
2626
RenderTile* mTile;
2727
RenderThreadStatistics mStatistics;
28-
29-
size_t mStreamElementCount;
3028
};
3129
} // namespace PR

src/library/renderer/RenderTileSession.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
#include "buffer/Feedback.h"
55
#include "buffer/OutputBuffer.h"
66
#include "entity/IEntity.h"
7+
#include "geometry/GeometryPoint.h"
78
#include "ray/RayPackage.h"
89
#include "ray/RayStream.h"
910
#include "renderer/RenderContext.h"

0 commit comments

Comments
 (0)