feat: implement automated reporting and visualization layer#4040
Open
ayushman1210 wants to merge 10 commits into
Open
feat: implement automated reporting and visualization layer#4040ayushman1210 wants to merge 10 commits into
ayushman1210 wants to merge 10 commits into
Conversation
divine7022
reviewed
Jul 14, 2026
divine7022
left a comment
Member
There was a problem hiding this comment.
solid work! thanks for putting this together
the bigger picture, ryt now this is plotting layer. and 4037 is validation report, and the job of a validation report is to answer two questions "is the model good enough ?" and "where does it fail ?". a stack of pretty panels doesn't answer either. the upgrades I am trying to asking are what turn this from "here are some plots" into "here's whether the model passes, and where it doesn't" none of it is hard and you have already got the pieces in.
and consolidate one off plot_time_series into these, it is not touched here. either fold it in or spin quick follow up
Co-authored-by: Akash B V <www.divinehome12@gmail.com>
- Add per-site faceting and scorecards to timeseries and residual plots - Standardize plot styles (lowercase axes, dynamic units, 12pt base_size) - Implement linear trendlines for residual plots - Incorporate obvs_sd into overlap/coverage logic - Remove redundant stop() calls and ensure terminating newlines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here's a breakdown of what I worked on:
metric_timeseries_plot.R,metric_scatter_plot.R, andmetric_residual_plot.Rfunctions so they can easily consume thedata.frameordata.tableoutputs straight from therun_benchmark()pipeline. I also took the opportunity to clean up theggplot2aesthetics (better themes, removing hardcoded date limitations, adding reference lines, etc.).Validation_report.qmdtemplate ininst/reports/. This generates a nice HTML scorecard (ILAMB-style) that compiles all our computed metrics alongside the plots.generate_validation_report.R, which acts as a wrapper to render the Quarto template automatically at the end of a benchmark run.test-visualization.Rto make sure the plots render correctly and the wrapper function handles missing templates gracefully.Types of changes
Fixes #4037