Update docs/parameters.md to reflect deprecated and obsolete params#123
Conversation
| | `soil-quality` | 0 | Use soil quality submodel. | | ||
| | `water-hresp` | 1 | Whether soil moisture affects heterotrophic respiration. | | ||
| | `num-carbon-soil-pools` | 1 | Number of carbon soil pools. | | ||
| | `do-main-output` | 1 | Print time series of all output variables to `<file-name>.out`. | |
There was a problem hiding this comment.
Need to delete duplicate rows
| # Input files | ||
| param-file = mysite.param | ||
| clim-file = mysite.clim |
There was a problem hiding this comment.
These are not settable in the config file (or via command line). They'll get read, but they will be overridden by calculation from file-name
|
|
||
| ``` | ||
| # Base filename (used for derived filenames if not explicitly specified) | ||
| file-name = mysite |
There was a problem hiding this comment.
I definitely like this form ('snake-case', as it's called), given the parallel with the command line - but it's a deviation from all of the sipnet.in files in the codebase (which use ALL_CAPS versions of these params). Do we care?
There was a problem hiding this comment.
VERY IMPORTANT correction: snake_case uses underscores. This is obviously kebab-case 😛
But more seriously I vote we enforce identical spelling on command line and sipnet.in so that we don't have to remember differences like underscore vs hyphen.
Alomir
left a comment
Alomir
left a comment
There was a problem hiding this comment.
A couple of tweaks needed, which I'll get in the parent branch. Thanks so much for doing this!
Alomir
merged commit 756855b
into
SIP78_convert_switches_to_run_time_options_part_3
3 participants
This PR updates docs/parameters.md to align with the SIPNET implementation as it will be following completion of #78 by merging #114.
More work is likely needed - I am just adding these as I review #114.