Skip to content

SIP333 docs#335

Merged
Alomir merged 2 commits into
SIP333-refactor-nitrogenfrom
SIP33-docs
May 12, 2026
Merged

SIP333 docs#335
Alomir merged 2 commits into
SIP333-refactor-nitrogenfrom
SIP33-docs

Conversation

@dlebauer
Copy link
Copy Markdown
Member

Summary

How was this change tested?

Not tested, just docs.

Related issues

Checklist

  • Related issues are listed above. PRs without an approved, related issue may not get reviewed.
  • PR title has the issue number in it ("[#] <concise description of proposed change>")
  • Tests added/updated for new features (if applicable)
  • Documentation updated (if applicable)
  • docs/CHANGELOG.md updated with noteworthy changes
  • Code formatted with clang-format (run git clang-format if needed)

Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run git clang-format to format staged changes.

Comment thread docs/model-structure.md

| Parameter | Value | Description |
|-----------|----------------------|-------------------|
| --------- | -------------------- | ----------------- |
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was an auto-formatter - let me know if I should change my autoformatting settings

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice - my IDE complains about the spaces (which perhaps I could change?)

@dlebauer dlebauer mentioned this pull request May 12, 2026
6 tasks
Copy link
Copy Markdown
Collaborator

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@Alomir Alomir merged commit 4eb6389 into SIP333-refactor-nitrogen May 12, 2026
10 checks passed
@Alomir Alomir deleted the SIP33-docs branch May 12, 2026 14:47
Alomir added a commit that referenced this pull request May 12, 2026
* Interim commit

* First pass at refactor; N limit still needs work

* First pass at refactor; N limit still needs work

* Tweaks before N limit refactor

* Fix CN calcs

* Update for refactored N limitation

* Refactor N limitation to limitations.c

* Doc update

* SIP333 docs (#335)

* update model structure b/c not all source is in sipnet.c

* added check limitations to code-structure doc

* Signature and scope tweaks from PR feedback

---------

Co-authored-by: David LeBauer <dlebauer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants