Revamp .clang-tidy #65
Merged
Merged
Conversation
… inclusion list, with updates to code
dlebauer
approved these changes
Apr 25, 2025
Member
dlebauer
left a comment
dlebauer
left a comment
There was a problem hiding this comment.
LGTM. Makes sense to punt removal deprecated files & functions to another day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was never really happy with our
.clang-tidyfile, as it was just a dump of CLion's config of dubious provenance (with some small exclusions).This PR changes the strategy, making the file a small exclusion list from the clang-tidy default, instead of turning all checks off and then adding back a subset.
There are a pair of NOLINT directives in the code that tell clang-tidy to ignore the line, as they had warnings that were (a) false positives as far as I can tell, and (b) not warnings I want to totally shut off.