fix: pass full contentContainerStyle in FlashList wrapper (Android minHeight)#497
Open
AgathaCrystal wants to merge 1 commit into
Open
fix: pass full contentContainerStyle in FlashList wrapper (Android minHeight)#497AgathaCrystal wants to merge 1 commit into
AgathaCrystal wants to merge 1 commit into
Conversation
FlashList.tsx only extracted paddingTop from the library's calculated contentContainerStyle, dropping minHeight. This caused Android scroll sync to fail on tab switch when content was shorter than the viewport. The fix spreads the full contentContainerStyle (matching FlatList.tsx behavior), so the library's minHeight reaches the FlashList.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlashList.tsxonly extractedpaddingTopfrom the library's calculatedcontentContainerStyle, droppingminHeight. This caused Android scroll sync to fail on tab switch when content was shorter than the viewport.The fix spreads the full
contentContainerStyle(matchingFlatList.tsxbehavior), ensuring the library's calculatedminHeightreaches the FlashList.Root Cause
useCollapsibleStyle()calculatesminHeight: containerHeight + headerScrollDistanceto ensure content is tall enough for Android's scroll sync.FlatList.tsxpasses this through correctly, butFlashList.tsxonly extractedpaddingTop:Without
minHeight, Android'sscrollTo(headerScrollDistance)silently fails when tab content is shorter than the viewport, because the max scroll offset is less than the target. iOS is unaffected (uses nativecontentInset).Reproduction
Tabs.FlashListwith 2+ tabs on AndroidTest plan
fixes #498