Update gomod dependencies #4399
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,10 +9,10 @@ require ( | |
| cloud.google.com/go/kms v1.31.0 | ||
| cloud.google.com/go/pubsub/v2 v2.3.0 | ||
| cloud.google.com/go/storage v1.62.1 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.14.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs/v2 v2.0.2 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/eventhub/armeventhub v1.3.0 | ||
| github.com/ClickHouse/ch-go v0.73.0 | ||
| github.com/ClickHouse/clickhouse-go/v2 v2.46.0 | ||
| github.com/PeerDB-io/glua64 v1.0.1 | ||
| github.com/PeerDB-io/gluabit32 v1.0.2 | ||
|
|
@@ -22,20 +22,20 @@ require ( | |
| github.com/PeerDB-io/peerdb/flow/pkg v0.0.0 | ||
| github.com/Shopify/toxiproxy/v2 v2.12.0 | ||
| github.com/apache/arrow-go/v18 v18.6.0 | ||
| github.com/aws/aws-sdk-go-v2 v1.42.0 | ||
| github.com/aws/aws-sdk-go-v2/config v1.32.25 | ||
| github.com/aws/aws-sdk-go-v2/credentials v1.19.24 | ||
| github.com/aws/aws-sdk-go-v2/feature/rds/auth v1.6.29 | ||
| github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.21.0 // PINNED(DBI-500): v1.22.0 deprecates NewUploader in favor of feature/s3/transfermanager | ||
| github.com/aws/aws-sdk-go-v2/service/kms v1.53.4 | ||
| github.com/aws/aws-sdk-go-v2/service/s3 v1.104.0 | ||
| github.com/aws/aws-sdk-go-v2/service/ses v1.35.2 | ||
| github.com/aws/aws-sdk-go-v2/service/sts v1.43.3 | ||
| github.com/aws/smithy-go v1.27.2 | ||
| github.com/cockroachdb/pebble/v2 v2.1.6 | ||
| github.com/elastic/go-elasticsearch/v8 v8.19.6 | ||
| github.com/go-logr/logr v1.4.3 | ||
| github.com/go-mysql-org/go-mysql v1.15.1-0.20260701093637-35ca5c6ee8c8 | ||
| github.com/gogo/googleapis v1.4.1 | ||
| github.com/google/uuid v1.6.0 | ||
| github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.3.3 | ||
|
|
@@ -46,7 +46,7 @@ require ( | |
| github.com/jackc/pgx/v5 v5.10.0 | ||
| github.com/joho/godotenv v1.5.1 | ||
| github.com/json-iterator/go v1.1.12 | ||
| github.com/lestrrat-go/httprc/v3 v3.0.6 | ||
| github.com/lestrrat-go/jwx/v3 v3.1.1 | ||
| github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee | ||
| github.com/nickbruun/pgsplit v0.0.0-20240103043353-43e6c2dddfad | ||
|
|
@@ -58,43 +58,43 @@ require ( | |
| github.com/pingcap/tidb/pkg/parser v0.0.0-20260504140133-511dba1dbe17 | ||
| github.com/quasilyte/go-ruleguard/dsl v0.3.23 | ||
| github.com/shopspring/decimal v1.4.0 | ||
| github.com/slack-go/slack v0.26.0 | ||
| github.com/snowflakedb/gosnowflake/v2 v2.1.0 | ||
| github.com/stretchr/testify v1.11.1 | ||
| github.com/testcontainers/testcontainers-go v0.43.0 | ||
| github.com/twmb/franz-go v1.21.4 | ||
| github.com/twmb/franz-go/pkg/kadm v1.18.0 | ||
| github.com/twmb/franz-go/plugin/kslog v1.0.0 | ||
| github.com/twpayne/go-geos v0.20.4 | ||
| github.com/urfave/cli/v3 v3.10.0 | ||
| github.com/xdg-go/scram v1.2.0 | ||
| github.com/youmark/pkcs8 v0.0.0-20240726163527-a2c0da244d78 | ||
| github.com/yuin/gopher-lua v1.1.2 | ||
| go.mongodb.org/mongo-driver/v2 v2.7.0 | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.69.0 | ||
|
There was a problem hiding this comment. [Informational] otelgrpc v0.69.0 upgraded semantic conventions to v1.40.0, which removes the following metrics and span events:
PeerDB uses Also removes deprecated functions |
||
| go.opentelemetry.io/otel v1.44.0 | ||
|
There was a problem hiding this comment. PeerDB metrics use high-cardinality attributes ( The meter provider in There was a problem hiding this comment. [Informational] OpenTelemetry v1.44.0 introduces a default metrics cardinality limit of 2000 per instrument. Attribute-set combinations beyond this are dropped into an overflow bucket. PeerDB attaches per-flow attributes to metrics (flow name, source/destination peer name, peer type, hostname, status, etc.). For most deployments this should be fine, but if a deployment has 2000+ active flows, metrics could be silently dropped. If this becomes an issue, setting Also note: There was a problem hiding this comment. Informational — OTel v1.44.0 introduces a default cardinality limit of 2000 per metric instrument. Previously unlimited, the Metrics SDK now drops attribute sets exceeding 2000 unique combinations per instrument, aggregating overflow under PeerDB's metric attributes (flow name, source/dest peer, status, operation, activity type, etc.) are bounded by the number of active flows × operations, which should comfortably stay under 2000 for typical deployments. However, for large-scale deployments with many concurrent flows, this is worth keeping in mind. To restore the old (unlimited) behavior if needed: No action required — just flagging for awareness since this is a default behavior change from upstream. There was a problem hiding this comment. Info (not blocking): OTel v1.44.0 introduces a default cardinality limit of 2000 per metric instrument. Attribute sets beyond this limit are silently dropped and aggregated under an otel.metric.overflow=true marker. PeerDB does not explicitly configure a cardinality limit in flow/otel_metrics/otel_manager.go. This is almost certainly fine -- PeerDB metrics use bounded attribute sets (peer names, table names, flow names). But if any metric has high-cardinality attributes (e.g. per-partition keys), data could be silently dropped. There was a problem hiding this comment. OTel SDK v1.44.0 introduces a default metrics cardinality limit of 2000 (previously unlimited). Once a metric instrument hits 2000 unique attribute-set combinations, new attribute sets are silently dropped and aggregated into a special overflow set tagged otel.metric.overflow=true. PeerDB metrics use per-flow attributes (FlowName, SourcePeerName, DestinationPeerName, PipeName, TemporalActivityType, etc. in flow/otel_metrics/observables.go:115-152). The total cardinality per metric instrument scales with flows x pipes x operations x activity_types. For most deployments this should be fine (2000 is generous), but large deployments with hundreds of mirrors could silently lose metric data. To restore unlimited cardinality if needed: sdkmetric.WithCardinalityLimit(0) when creating the MeterProvider (in otel_manager.go:710). Not a blocker -- the new default follows the OTel spec and is a safety improvement -- but worth being aware of. There was a problem hiding this comment. Previously the limit was unlimited. When exceeded, excess attribute sets are silently dropped and aggregated into an PeerDB's To restore unlimited behavior: pass Recommendation: This is likely fine for most deployments, but worth being aware of. Consider adding Additionally, this bump includes two security fixes:
There was a problem hiding this comment. [Medium] OTel v1.44.0 introduces a default metric cardinality limit of 2000 per metric instrument. Attribute sets beyond this limit are silently dropped into an overflow bucket. PeerDB emits metrics with per-flow attributes (FlowName, SourcePeerName, DestinationPeerName, FlowStatus, etc. -- see flow/otel_metrics/observables.go). For most deployments this should be well under 2000, but large installations with many mirrors could potentially hit this ceiling. PeerDB does not currently configure WithCardinalityLimit, so the new default applies. If concerned, the limit can be raised or disabled via WithCardinalityLimit(0) on the metric reader. Also notable: this release patches two security advisories (file handle leak in schema ParseFile, baggage header log flooding) and deprecates Value.Emit() in favor of Value.String(). There was a problem hiding this comment. OTel v1.44.0 introduces a default metric cardinality limit of 2000. Previously unlimited, Additionally, OTLP exporters now impose a 64 MiB default request size limit (before compression); oversized requests become non-retryable errors. Recommendation: This is likely fine for most deployments, but worth being aware of. If metric cardinality issues surface post-upgrade, the limit can be raised via |
||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.44.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.44.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.44.0 | ||
| go.opentelemetry.io/otel/metric v1.44.0 | ||
| go.opentelemetry.io/otel/sdk v1.44.0 | ||
|
There was a problem hiding this comment. Warning: go.opentelemetry.io/otel/sdk/metric v1.44.0 introduces a default cardinality limit of 2000 per instrument. When the limit is reached, new attribute sets are silently dropped into an overflow bucket. PeerDB defines 40+ metric instruments in flow/otel_metrics/otel_manager.go, some keyed by dynamic attributes (per-table, per-flow). If any single instrument exceeds 2000 unique attribute combinations, metrics will be silently lost. For most deployments this is probably fine (2000 is generous), but worth verifying for large multi-tenant deployments. If needed, override with sdkmetric.WithCardinalityLimit(0) in setupMetricsAndProvider(). There was a problem hiding this comment. Note (informational, non-blocking): OpenTelemetry SDK v1.44.0 introduces a default cardinality limit of 2000 for the metrics SDK. When more than 2000 unique attribute sets are recorded for a single metric instrument, new attribute sets are dropped and aggregated into an overflow bucket. Previously there was no limit. If PeerDB has any high-cardinality metrics (e.g. metrics tagged per-table, per-peer, or per-flow), this could silently truncate metric data. To restore old behavior use WithCardinalityLimit(0). Also: attribute.Value.Emit() is deprecated in favor of Value.String(); security fixes for schema file handle leak and baggage extraction DoS; new default 64 MiB OTLP request size limit. All other bumps are clean - see review summary comment for details. There was a problem hiding this comment. OTel SDK v1.44.0 introduces a default 2000 cardinality limit. There was a problem hiding this comment. OTel SDK v1.44.0 introduces a default 2000 cardinality limit on metrics. The metrics SDK now enforces a default cap of 2000 unique attribute-set combinations per metric instrument. Excess sets are silently dropped into an overflow bucket. PeerDB does not currently configure any cardinality limits (verified via grep). If any custom OTel metrics exceed 2000 unique attribute combinations, metric data will be silently dropped. Worth verifying for high-cardinality dimensions (per-table, per-mirror, per-partition metrics). If unlimited cardinality is needed, pass WithCardinalityLimit(0) when creating the meter provider. Also: Value.Emit is deprecated in favor of Value.String. |
||
| go.opentelemetry.io/otel/sdk/metric v1.44.0 | ||
|
There was a problem hiding this comment. Informational — OTel v1.44.0 introduces a default cardinality limit of 2000 per metric instrument. Previously unlimited, new attribute sets beyond 2000 unique combinations per instrument are now dropped and aggregated under To restore the old unlimited behavior if needed: Also: OTLP exporters now cap request size at 64 MiB (configurable via There was a problem hiding this comment. [Informational — OTel v1.44.0 default cardinality limit] This bump introduces a new default cardinality limit of 2,000 attribute sets per metric instrument (changelog). Excess attribute sets are dropped into an overflow bucket tagged PeerDB's Additionally, OTLP exporters now enforce a 64 MiB default request size limit — oversized payloads become non-retryable errors. Both limits are configurable ( There was a problem hiding this comment. [Informational] OTel SDK v1.44.0 introduces a default cardinality limit of 2000 per metric instrument (per the OTel spec). When exceeded, new attribute sets are silently dropped and aggregated into an overflow bucket with PeerDB metrics use per-flow, per-peer, and per-table attributes (e.g. Impact: Likely fine for most deployments, but large-scale deployments should monitor for Additionally, OTel v1.44.0 adds a default 64 MiB OTLP request size limit (configurable via There was a problem hiding this comment. PeerDB's If needed, add There was a problem hiding this comment. OTel v1.44.0 introduces a default cardinality limit of 2000 attribute combinations per instrument. When this limit is hit, new attribute sets are silently dropped and measurements aggregate into an overflow set. PeerDB metrics use high-dimensional attributes (flow name, source/destination peer info, table name, activity type, etc.). For metrics like This is unlikely to be an issue for most deployments, but worth being aware of. If you see metric data points going missing after this upgrade, you can configure There was a problem hiding this comment. [Informational] OTel v1.44.0 introduces a default metric cardinality limit of 2000 per instrument. When exceeded, new attribute sets are silently dropped and aggregated into an overflow bucket. PeerDB metrics use attributes like If this becomes a concern, the limit can be raised with All other bumps in this PR checked out clean:
There was a problem hiding this comment. OTel SDK metric v1.44.0 introduces a default cardinality limit of 2000 per instrument (release notes). PeerDB uses ContextAwareInt64SyncGauge wrappers that inject contextual attributes (flow name, source/dest peer info, flow status, operation type, temporal activity info) on top of explicit attributes. The RecordsSyncedPerTableGauge additionally includes DestinationTableName and RecordOperationType. In deployments with many flows and tables, the unique attribute-set count per instrument could exceed 2000 (e.g. 100 flows x 10 tables x 3 ops = 3000 combinations). When the limit is exceeded, new attribute sets are silently dropped into an overflow bucket (otel.metric.overflow=true), meaning per-table metrics would go missing without any error. Mitigation options (no action required to merge, but worth tracking):
Also note: attribute.Value.Emit() is deprecated in favor of Value.String() -- PeerDB does not appear to call Emit() directly, so no action needed there. There was a problem hiding this comment. PeerDB metrics use per-flow attributes (FlowName, SourcePeerName, DestinationPeerName, sourcePeerHostname, destinationPeerHostname, FlowStatus, FlowOperation, PipeName, etc. — see Currently Upstream reference: OTel Go v1.44.0 release notes There was a problem hiding this comment. OTel v1.44.0 introduces a default cardinality limit of 2000 per instrument. PeerDB emits per-table metrics ( This is unlikely to bite most deployments (e.g. 200 flows × 3 tables × 3 ops = 1800, still under the limit), but worth being aware of. If needed, the limit can be raised via Additionally, OTLP exporters now enforce a 64 MiB default request size limit (non-retryable error if exceeded). Not a blocker — just flagging for awareness. There was a problem hiding this comment. OTel sdk/metric v1.44.0 — new default cardinality limit of 2000 This version introduces a default cardinality limit of 2000 unique attribute sets per instrument. Previously, cardinality was unlimited. PeerDB metrics include high-cardinality attributes (flow name, source/destination peer type+name+hostname, flow status, pipe name, operation type, temporal activity details) and per-table metrics like If this is a concern, you can restore the previous behavior by passing Also notable: this release includes two security fixes — a file descriptor leak in schema There was a problem hiding this comment. [informational] OTel v1.43.0 to v1.44.0 introduces a default cardinality limit of 2000 per metric instrument in the metrics SDK. Attribute sets beyond this limit are aggregated into an overflow bucket (otel.metric.overflow=true). PeerDB attaches per-flow attributes (flow name, source/destination peer names, table names, activity/workflow types) to metrics. For typical deployments this is well within the limit, but very large deployments with hundreds of flows and many tables per flow could hit it -- metrics would silently lose granularity. This release also includes two security fixes: GHSA-995v-fvrw-c78m (schema file descriptor leaks) and GHSA-5wrp-cwcj-q835 (baggage extraction error flooding, now rate-limited). No action required now, but worth keeping in mind. If needed, the limit can be raised with WithCardinalityLimit(0) on individual views. There was a problem hiding this comment. [info] OTel SDK metric v1.44.0 introduces a default cardinality limit of 2000 per metric instrument. When exceeded, new attribute sets are dropped and aggregated into an PeerDB's Workaround if needed: Set env var Also notable in this release:
|
||
| go.opentelemetry.io/otel/trace v1.44.0 | ||
| go.temporal.io/api v1.63.0 | ||
| go.temporal.io/sdk v1.45.0 | ||
|
There was a problem hiding this comment. [informational] Temporal SDK v1.44.0 to v1.45.0 has several behavioral changes:
No action required, but worth monitoring after rollout. |
||
| go.temporal.io/sdk/contrib/opentelemetry v0.7.0 | ||
| go.uber.org/automaxprocs v1.6.0 | ||
| golang.org/x/crypto v0.53.0 | ||
| golang.org/x/exp v0.0.0-20260611194520-c48552f49976 | ||
| golang.org/x/mod v0.37.0 | ||
| golang.org/x/sync v0.21.0 | ||
| golang.org/x/tools v0.46.0 | ||
| google.golang.org/api v0.279.0 | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20260526163538-3dc84a4a5aaa | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20260526163538-3dc84a4a5aaa | ||
| google.golang.org/grpc v1.81.1 | ||
| google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af | ||
| k8s.io/apimachinery v0.36.2 | ||
| k8s.io/client-go v0.35.3 // Note: v0.* are newer than v1.* | ||
| ) | ||
|
|
||
|
|
@@ -109,12 +109,12 @@ require ( | |
| filippo.io/edwards25519 v1.2.0 // indirect | ||
| github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect | ||
| github.com/99designs/keyring v1.2.2 // indirect | ||
| github.com/Azure/azure-sdk-for-go/sdk/azcore v1.22.0 // indirect | ||
| github.com/Azure/azure-sdk-for-go/sdk/internal v1.12.0 // indirect | ||
| github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.6.4 // indirect | ||
| github.com/Azure/go-amqp v1.5.1 // indirect | ||
| github.com/Azure/go-ansiterm v0.0.0-20250102033503-faa5f7b0171c // indirect | ||
| github.com/AzureAD/microsoft-authentication-library-for-go v1.7.2 // indirect | ||
| github.com/BurntSushi/toml v1.6.0 // indirect | ||
| github.com/DataDog/zstd v1.5.7 // indirect | ||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.31.0 // indirect | ||
|
|
@@ -127,18 +127,18 @@ require ( | |
| github.com/andybalholm/brotli v1.2.1 // indirect | ||
| github.com/apache/arrow/go/v15 v15.0.2 // indirect | ||
| github.com/apache/thrift v0.22.0 // indirect | ||
| github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.7.13 // indirect | ||
| github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.29 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.29 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.29 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.30 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.12 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.22 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.29 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.29 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/signin v1.2.0 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sso v1.31.3 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/ssooidc v1.36.6 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/cenkalti/backoff/v4 v4.3.0 // indirect | ||
| github.com/cenkalti/backoff/v5 v5.0.3 // indirect | ||
|
|
@@ -232,7 +232,7 @@ require ( | |
| github.com/minio/minlz v1.1.0 // indirect | ||
| github.com/moby/docker-image-spec v1.3.1 // indirect | ||
| github.com/moby/go-archive v0.2.0 // indirect | ||
| github.com/moby/moby/api v1.54.2 // indirect | ||
| github.com/moby/moby/client v0.4.0 // indirect | ||
| github.com/moby/patternmatcher v0.6.1 // indirect | ||
| github.com/moby/sys/sequential v0.6.0 // indirect | ||
|
|
@@ -248,7 +248,7 @@ require ( | |
| github.com/opentracing/basictracer-go v1.1.0 // indirect | ||
| github.com/opentracing/opentracing-go v1.2.0 // indirect | ||
| github.com/paulmach/orb v0.13.0 // indirect | ||
| github.com/pierrec/lz4/v4 v4.1.27 // indirect | ||
| github.com/pingcap/failpoint v0.0.0-20260406204437-bbc9d102c19e // indirect | ||
| github.com/pingcap/kvproto v0.0.0-20260331120830-0d407c8b3f6e // indirect | ||
| github.com/pingcap/log v1.1.1-0.20260227082333-572e590d08f1 // indirect | ||
|
|
@@ -267,7 +267,7 @@ require ( | |
| github.com/rogpeppe/go-internal v1.14.1 // indirect | ||
| github.com/segmentio/asm v1.2.1 // indirect | ||
| github.com/shirou/gopsutil/v3 v3.24.5 // indirect | ||
| github.com/shirou/gopsutil/v4 v4.26.5 // indirect | ||
| github.com/shoenig/go-m1cpu v0.2.1 // indirect | ||
| github.com/sirupsen/logrus v1.9.4 // indirect | ||
| github.com/spiffe/go-spiffe/v2 v2.6.0 // indirect | ||
|
|
@@ -292,19 +292,19 @@ require ( | |
| go.opentelemetry.io/auto/sdk v1.2.1 // indirect | ||
| go.opentelemetry.io/contrib/detectors/gcp v1.42.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.67.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.44.0 // indirect | ||
| go.opentelemetry.io/proto/otlp v1.10.0 // indirect | ||
| go.uber.org/atomic v1.11.0 // indirect | ||
| go.uber.org/multierr v1.11.0 // indirect | ||
| go.uber.org/zap v1.28.0 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| golang.org/x/net v0.56.0 // indirect | ||
| golang.org/x/oauth2 v0.36.0 // indirect | ||
| golang.org/x/sys v0.46.0 // indirect | ||
| golang.org/x/telemetry v0.0.0-20260610154732-fb80ec83bdd9 // indirect | ||
| golang.org/x/term v0.44.0 // indirect | ||
| golang.org/x/text v0.38.0 | ||
| golang.org/x/time v0.15.0 // indirect | ||
| golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da // indirect | ||
| google.golang.org/genproto v0.0.0-20260319201613-d00831a3d3e7 // indirect | ||
|
|
@@ -322,6 +322,8 @@ require ( | |
| sigs.k8s.io/yaml v1.6.0 // indirect | ||
| ) | ||
|
|
||
| require github.com/nexus-rpc/nexus-proto-annotations v0.1.0 // indirect | ||
|
|
||
| replace github.com/tikv/client-go/v2 => github.com/PeerDB-io/tikv-client-go/v2 v2.0.7 | ||
|
|
||
| replace github.com/tikv/pd/client => github.com/tikv/pd/client v0.0.0-20251229071808-6173d50c004c // PINNED(DBI-444): the underlying dependency changed an interface | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTel v1.43.0 → v1.44.0 — new default cardinality limit of 2000 per metric instrument.
Starting in v1.44.0, the OTel metric SDK enforces a default cardinality limit of 2000 unique attribute sets per instrument. Attribute sets beyond this are dropped into an overflow bucket and silently lost.
PeerDB's metrics use per-flow and per-table attributes (
flowName,sourcePeerName,destinationPeerName,destinationTableName— seeotel_metrics/attributes.go). For deployments with many flows × many tables, the cross-product of these attributes could exceed 2000 per instrument (e.g.RecordsSyncedPerTableCounter), causing silent metric data loss.Currently no
WithCardinalityLimitis configured inotel_metrics/otel_manager.go. If the previous unlimited behavior is desired, addsdkmetric.WithCardinalityLimit(0)to theNewMeterProvidercall, or set an explicit higher limit.Other OTel v1.44.0 changes: OTLP exporters now enforce a 64 MiB request size limit (pre-compression) — unlikely to matter.
Value.Emitdeprecated in favor ofValue.String. Go 1.23 support dropped (not relevant — PeerDB uses Go 1.26).