Skip to content

DBI-829: Expand tested MariaDB version range in CI#4504

Closed
pfcoperez wants to merge 3 commits into
mainfrom
DBI-829/mariadb-extended-versions
Closed

DBI-829: Expand tested MariaDB version range in CI#4504
pfcoperez wants to merge 3 commits into
mainfrom
DBI-829/mariadb-extended-versions

Conversation

@pfcoperez

Copy link
Copy Markdown
Member

This PR expands the pseudo-DSL within flow.yml used to described test matrix cases by allowing an optional row field that overrides the tag described by version-configs when present. e.g:

  • Traditional entry: {pg: 18, mysql-flavor: 'maria-pos', mongo: '8.0', ch: 'latest'},, falling back to using:
              mysql-pos:
                img: 'mysql'
                tag: '5.7'
                env: ['MYSQL_ROOT_PASSWORD=cipass']
                parameters: ['--log_bin=mysql-bin', '--server-id=1', '--bind-address=::']
  • Entry with parametrized tag: {pg: 18, mysql-flavor: 'maria-gtid', mysql-tag: '12-ubi', mongo: '8.0', ch: 'stable'},

Then it uses this mechanism to add the cases for MariaDB 12 and 13:

          {pg: 18, mysql-flavor: 'maria-gtid', mysql-tag: '12-ubi', mongo: '8.0', ch: 'stable'},
          {pg: 18, mysql-flavor: 'maria-gtid', mysql-tag: '13-ubi', mongo: '8.0', ch: 'stable'},

@pfcoperez pfcoperez self-assigned this Jun 26, 2026
@pfcoperez
pfcoperez requested a review from a team as a code owner June 26, 2026 13:56
Comment thread .github/workflows/flow.yml Outdated
{pg: 18, mysql: 'maria-gtid', mongo: '8.0', ch: 'latest'},
{pg: 16, mysql-flavor: 'mysql-gtid', mongo: '6.0', ch: 'lts'},
{pg: 17, mysql-flavor: 'mysql-pos', mongo: '7.0', ch: 'stable'},
{pg: 18, mysql-flavor: 'maria-pos', mongo: '8.0', ch: 'latest'},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm
i think we don't allow mariadb with file pos, do we?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean, i see that we already have it in the code
but i'm not sure why

Comment thread .github/workflows/flow.yml Outdated
@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@claude

claude Bot commented Jun 28, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: The job failed deterministically because the CI matrix references a non-existent Docker image tag (mariadb:13-ubi → "manifest unknown"), a real config bug on the mariadb-extended-versions branch, not a flaky test.
Confidence: 0.97

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@pfcoperez

Copy link
Copy Markdown
Member Author

Superseded by #4510

@pfcoperez pfcoperez closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants