Add memory device option to support shotwise output#178
Conversation
|
Skimmed since this is still draft - just front-loading notes for the next push. Main structural thing: |
|
For the next push: would be good to cover request shape with memory on/off, ideal-sim opt-out, and a round-trip from raw shots into |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 98.80% 90.01% -8.80%
==========================================
Files 6 6
Lines 587 671 +84
==========================================
+ Hits 580 604 +24
- Misses 7 67 +60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…nto add-memory-support
…sent to API in get requests.
Tests:
- New mocked single-circuit shotwise test exercises the LE->BE bit-reversal
path with a fixture matching the live IonQ v0.4 shots response shape
(list of base-10-integer strings). Closes the codecov/patch gap to 100%.
CHANGELOG:
- New-features entry for the shotwise device option under 0.46.0-dev.
Cleanup:
- Collapse the dead 'params = {"shotwise": True}' line in _submit_job into
a single ternary; old version was always overwritten on the next line.
- Simplify ResourceManager.get with (params or {}) and a path ternary,
drop the vestigial '# we need params later' comment and shorten the
duplicated 'shotwise is not an API parameter' comments.
- Drop redundant blank lines inside generate_samples on both devices.
|
Cross-SDK we settled on
Multi-circuit logic stays — qiskit-ionq is copying it. |
|
qiskit-ionq#234 just merged with the same shape — opt-in, per-child fetch, ideal-sim skip. One behavior issue worth blocking on, one shape concern, a few nits inline. |
Summary