Add support for choosing decomposition rules in decompose-lowering#2973
Open
kipawaa wants to merge 10 commits into
Open
Add support for choosing decomposition rules in decompose-lowering#2973kipawaa wants to merge 10 commits into
decompose-lowering#2973kipawaa wants to merge 10 commits into
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 166 166
Lines 19209 19209
Branches 1788 1788
=======================================
Hits 18628 18628
Misses 429 429
Partials 152 152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kipawaa
commented
Jun 25, 2026
| #include <string> | ||
| #include <utility> | ||
|
|
||
| // When we read the decomposition rules module from file, |
Contributor
Author
There was a problem hiding this comment.
moved to the stablehlo include where this is relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
decompose-loweringalways applies all (applicable) decomposition rules in the IR, and removes all decomposition rules on cleanup.Description of the Change:
Introduces a
target-rulesoption to apply only a subset of the rules available in the IR. Rules are now applied by aligning thetarget_op's operands with the decomposition functions body and cloning the function body inline, to avoid the inconsistencies/heuristics of the built-in inliner. Rules are no longer removed after thedecompose-loweringpass to allow use throughout the pipeline ingraph-decompositionpasses. Decomposition functions will be removed by thesymbol-dcepass at the end of the default pipeline.Benefits:
Provides a more versatile
decompose-loweringpass, and will support a more efficientgraph-decompositionpass.Possible Drawbacks:
Related GitHub Issues:
[sc-122013]