Make DataView iterator implementation std::forward_iterator compatible for cpp20#2976
Draft
mlxd wants to merge 1 commit into
Draft
Make DataView iterator implementation std::forward_iterator compatible for cpp20#2976mlxd wants to merge 1 commit into
std::forward_iterator compatible for cpp20#2976mlxd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: The given DataView class has an internal implementation of an iterator that is not compatible with the C++20
std::forward_iteratordue to the use of a reference. A class with a reference member has its implicitly-declared copy-assignment operator deleted (see here). As a result, the constract forstd::forward_iteratoris broken, which causes failures on MSCV due to the iterator missing a copy assignment operator.Description of the Change: The fix is to simply replace the reference with a pointer.
Benefits: Ensure the DataView class for the runtime compilation can proceed with all major toolchains.
Possible Drawbacks:
Related GitHub Issues: PennyLaneAI/pennylane-lightning#1396