Get a proper path to the python shared library for the QPD plugin #3012
Open
maliasadi wants to merge 4 commits into
Open
Get a proper path to the python shared library for the QPD plugin #3012maliasadi wants to merge 4 commits into
maliasadi wants to merge 4 commits into
Conversation
…d of the static archive when both are avaiable
Contributor
|
Hello. You may have forgotten to update the changelog!
|
dime10
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The current
get_libpython_path()trustsLDLIBRARY, and if it finds nothing, then it returns an empty string. This causes the QPD plugin fails on envs whenLDLIBRARYsets to the static archived python library instead of the shared one (e.g., on conda envs:LDLIBRARY = libpython3.14.a).This PR fixes this with a minimal patch to
get_libpython_path()that it now only acceptsLDLIBRARYwhen it's actually a shared object, and otherwise falls back to the conventionallibpython{LDVERSION}.soinLIBDIR, then agloboflibpython*.so*. This fixes the issues on conda envs while preserving the current behaviour on other envs.Benefits:
Possible Drawbacks:
n/a
Related GitHub Issues: