fix: bound AACDecoderStream pendingChunks, optimize _tightBuffer, and

fix DASH stuck loops

Cap AACDecoderStream pendingChunks at 200, drop oldest when full to
prevent unbounded growth
Clear pendingChunks on destroy to release held buffers and callbacks
Optimize _tightBuffer to skip Buffer.from() when buffer is already tight
Clean up audioStream data listener on close/end to prevent leak during
reconnects
DASHHandler: increase prefetch from 1 to 4 and cap segment pace at 5s to
prevent stuck recovery loops

Author: ToddyTheNoobDud

src/playback/dash/DASHHandler.ts

@@ -5,7 +5,7 @@ import type {
 } from '../../typings/playback/dash.types.ts'
 import { logger, makeRequest } from '../../utils.ts'
 
-const PREFETCH_COUNT = 1
+const PREFETCH_COUNT = 4
 const MAX_BUFFERED = 16 * 1024
 
 /**
@@ -185,7 +185,7 @@ export class DASHHandler extends Transform {
         pushIndex++
 
         if (segmentDuration > 0 && pushIndex < totalSegments) {
-          const paceMs = segmentDuration * 1000 * 0.8
+          const paceMs = Math.min(segmentDuration * 1000 * 0.8, 5000)
           await this._sleepOrStop(paceMs)
         }
       }

src/playback/player.ts

@@ -333,11 +333,18 @@ export class Player {
       this._onError(err)
     })
     this.connection.on('audioStream', (audioStream: VoiceAudioStream) => {
-      audioStream.on('data', () => {
+      const dataHandler = () => {
         this._lastStreamDataTime = Date.now()
         if (this.isLyricsSubscribed && !this.isPaused && this.track) {
           this._syncLyrics()
         }
+      }
+      audioStream.on('data', dataHandler)
+      audioStream.once('close', () => {
+        audioStream.off('data', dataHandler)
+      })
+      audioStream.once('end', () => {
+        audioStream.off('data', dataHandler)
       })
     })
 

src/playback/processing/streamProcessor.ts

@@ -264,7 +264,10 @@ const _isWebmFormat = (type: string): boolean =>
   type.includes('webm') || type.includes('weba')
 
 const _isFlvFormat = (type: string): boolean => type.indexOf('flv') !== -1
-const _tightBuffer = (buf: Buffer): Buffer => Buffer.from(buf)
+const _tightBuffer = (buf: Buffer): Buffer =>
+  buf.byteOffset === 0 && buf.byteLength === buf.buffer.byteLength
+    ? buf
+    : Buffer.from(buf)
 const _toTightArrayBuffer = (buf: Buffer): ArrayBuffer => {
   const backing = buf.buffer
   if (
@@ -1270,6 +1273,7 @@ class AACDecoderStream extends Transform {
   private ringBuffer: RingBufferLike
   private resamplingQuality: string
   private resamplerCreationPromise: Promise<ResamplerLike> | null
+  private static readonly MAX_PENDING_CHUNKS = 200
 
   constructor(options: AACDecoderStreamOptions) {
     super({
@@ -1300,6 +1304,7 @@ class AACDecoderStream extends Transform {
     cb: (error?: Error | null) => void
   ): void {
     this.ringBuffer.dispose()
+    this.pendingChunks.length = 0
     if (this.decoder) this.decoder.free?.()
     if (this.resampler) this.resampler.destroy?.()
     super._destroy(err, cb)
@@ -1429,6 +1434,9 @@ class AACDecoderStream extends Transform {
     callback: TransformCallback
   ): void {
     if (!this.isDecoderReady || this.pendingChunks.length > 0) {
+      if (this.pendingChunks.length >= AACDecoderStream.MAX_PENDING_CHUNKS) {
+        this.pendingChunks.shift()
+      }
       this.pendingChunks.push({ chunk, encoding, callback })
       return
     }