Move away from `HTTP::Body`

[xsawyerx]

I've been wanting to do this for a very long time.

Plack did this in plack/Plack#537.

[veryrusty]

Totally agree! @xsawyerx++

The merged PR for Plack is plack/Plack#538

[veryrusty]

I was about to revise my refactor/request_body_parsing branch which removed HTTP::Body from Dancer2::Core::Request.. I'll go check the impact that of using HTTP::Entity::Parser on that work :)

[veryrusty]

Just updated Plack locally to its latest release (1.0039). Plack::Request still uses HTTP::Body even though was released after the above merge.. #weird.

[veryrusty]

D'Oh. Plack 1.0039 was a bugfix release.. No 'new feature' release has been made for Plack since the PR to remove HTTP::Body was merged.

[xsawyerx]

@veryrusty Thank you for looking into this and (hopefully) taking it on. :)

[veryrusty]

Challenge accepted :)

[xsawyerx]

@veryrusty++

[bigpresh]

I'm interested in this one - I'm looking at how much work it would be to swap HTTP::Body out of Dancer1, too, as part of PerlDancer/Dancer#1140. I suspect it'll be too much work to justify on D1, though; if so, I'll come up with some kind of workaround for it instead - HTTP::Body works well enough for us, other than its rather weird body handling (that the body is available via a filehandle for some request types, but not others)

[veryrusty]

@bigpresh D2's request object inherits from Plack::Request, so I'm waiting for a Plack release that has this change (being #lazy). For D1, have a look at the change that went into Plack::Request.

[xsawyerx]

@veryrusty Is such a release of Plack expected?

[veryrusty]

Note for self: Plack 1.0040 TRIAL is out, with HTTP::Body replaced with HTTP::Entity::Parser