Skip to content

Commit 29cd168

Browse files
committed
chore(ci): await-tests budget 90 → 120 min (v0.5.883)
v0.5.882 hit the 90-min wall while waiting for Tests. Tests itself ran ~30 min once started, but the macOS-14 runner was queued for an hour. Release Packages starts at tag-time (same as Tests), so the budget runs out before Tests gets dequeued + executes. Bumping to 120 absorbs typical busy-hour queue + Tests wall-time without exceeding GitHub's 6h workflow cap. Both bash deadline AND job-level timeout-minutes bumped in lockstep per the comment now documented inline.
1 parent 42683a0 commit 29cd168

1 file changed

Lines changed: 17 additions & 12 deletions

File tree

.github/workflows/release-packages.yml

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,15 @@ jobs:
2727
# ---------------------------------------------------------------------------
2828
await-tests:
2929
runs-on: ubuntu-latest
30-
# Job-level timeout must match the bash `deadline=$(( SECONDS + 90 * 60 ))`
31-
# below. v0.5.876 bumped the bash deadline to 90 but missed this — the
32-
# job got cancelled at the 60-min wall on v0.5.878 even though macOS
33-
# doc-tests succeeded 2 minutes later. Both must move together.
34-
timeout-minutes: 90
30+
# Job-level timeout must match the bash `deadline=$(( SECONDS + N * 60 ))`
31+
# below. Both must move together.
32+
# - v0.5.876: 60 → 90 (Tests had grown past 60 min wall)
33+
# - v0.5.883: 90 → 120 (macOS-14 runners queue 30-60+ min during
34+
# busy hours; Tests itself takes ~30 min, but Release Packages
35+
# starts at the same time as Tests and runs out of budget before
36+
# Tests gets dequeued + executes. 120 absorbs typical runner
37+
# queue + Tests wall-time).
38+
timeout-minutes: 120
3539
steps:
3640
- name: Wait for Tests + Simulator Tests (iOS) to pass
3741
env:
@@ -58,13 +62,14 @@ jobs:
5862
# of burning the 45-min budget.
5963
for wf_file in "test.yml" "simctl-tests.yml"; do
6064
echo "::group::Waiting for $wf_file"
61-
# 90-min budget per workflow. v0.5.875 timed out at the 60-min
62-
# wall while Tests was still in its macOS doc-tests leg — Tests
63-
# wall-time has grown past 60 min as the doc-tests suite + cargo
64-
# rebuild costs add up. 90 still well under GitHub's 6h cap, and
65-
# ~20 min headroom over typical Tests finish absorbs cold-cache
66-
# variance.
67-
deadline=$(( SECONDS + 90 * 60 ))
65+
# 120-min budget per workflow.
66+
# - v0.5.876: 60 → 90 (Tests wall-time grew past 60).
67+
# - v0.5.883: 90 → 120. v0.5.882 hit 90-min wall because
68+
# macOS-14 runner queue delayed doc-tests start by an
69+
# hour. Tests itself runs ~30 min, but Release Packages
70+
# starts at tag-time and runs out of budget waiting for
71+
# queue + execution. 120 absorbs typical busy-hour queue.
72+
deadline=$(( SECONDS + 120 * 60 ))
6873
retry_on_error=1
6974
while :; do
7075
set +e

0 commit comments

Comments
 (0)