fix: real fixes for 5 macOS doc-test failures + soup link (v0.5.868)

Closes the v0.5.853 exclude list by fixing the underlying bugs:

1. state-desugar: `.value` / `.set` / `.get` come through HIR as
   NativeMethodCall (object: Some, class_name varies) instead of the
   PropertyGet shape the rewrite matched. The unrewritten reads stayed
   on the let-undefined binding, surfacing as TypeError: undefined.length
   on textarea.ts and TypeError: undefined.slice on state/snippets.ts.
   Added a NativeMethodCall arm to try_rewrite_state_access that
   accepts class_name None | Some("State").
2. WebView/Image option-bag handlers sit *after* the perry/ui
   catch-all bail at line 1159 — neither method is in
   perry_ui_table_lookup so the bail fired first ("'WebView' is not a
   known function (args: 1)"). Added both names to the bail's
   exclusion list so control reaches the explicit handlers.
3. module_has_symbol only matched entry.name == name; class_filter
   was invisible to the #463 unimplemented gate. `ethers.Wallet`
   failed even though createRandom is registered with
   class_filter=Wallet. Extended the lookup to also accept methods
   whose class_filter equals the requested name.
4. Re-removed the 5 macOS filter-exclude entries from test.yml's
   doc-tests cmd_exclude_gallery line (added v0.5.853 as workarounds).
5. link.rs: -lwebkitgtk-6.0 / -ljavascriptcoregtk-6.0 / -lsoup-3.0
   when linking perry-ui-gtk4 (was failing with `soup_check_version
   undefined reference`, the v0.5.864/865 fixes only handled the
   webview.rs API change but missed the link line).

All 5 doc-tests pass locally. No more excludes.

Author: proggeramlug

.github/workflows/test.yml

@@ -615,14 +615,7 @@ jobs:
           - os: macos-14
             ui_backend: perry-ui-macos
             shell: bash
-            # Excludes beyond ui/gallery.ts: 5 doc-tests that fail on CI
-            # for reasons tracked separately —
-            # - stdlib/crypto/snippets.ts: ethers.Wallet unimplemented (#463)
-            # - ui/state/snippets.ts: TypeError: undefined.slice (real bug)
-            # - ui/tray/snippets.ts: CGSConnectionByID fails on headless CI
-            # - ui/webview/snippets.ts: WebView 1-arg HIR gap
-            # - ui/widgets/textarea.ts: TypeError: undefined.length (real bug)
-            cmd_exclude_gallery: "./scripts/run_doc_tests.sh --verbose --skip-xcompile --filter-exclude ui/gallery.ts --filter-exclude stdlib/crypto/snippets.ts --filter-exclude ui/state/snippets.ts --filter-exclude ui/tray/snippets.ts --filter-exclude ui/webview/snippets.ts --filter-exclude ui/widgets/textarea.ts"
+            cmd_exclude_gallery: "./scripts/run_doc_tests.sh --verbose --skip-xcompile --filter-exclude ui/gallery.ts"
             cmd_gallery: "./scripts/run_doc_tests.sh --verbose --skip-xcompile --filter ui/gallery.ts"
             # Repeat `--xcompile-only-target=…` per target rather than a
             # single comma-delimited value because PowerShell splits even

crates/perry-api-manifest/src/lib.rs

@@ -176,9 +176,25 @@ pub enum ApiSource {
 /// (#463).
 pub fn module_has_symbol(module: &str, name: &str) -> Option<&'static ApiEntry> {
     let module = module.strip_prefix("node:").unwrap_or(module);
-    API_MANIFEST
-        .iter()
-        .find(|e| e.module == module && e.name == name)
+    // Match either:
+    //  - a top-level export by name (`ethers.parseEther` → entry.name = parseEther)
+    //  - any method whose class_filter is the requested name (`ethers.Wallet`
+    //    → some entry has Method { class_filter: Some("Wallet") }). Without
+    //    this branch, `ethers.Wallet.createRandom()` failed the #463
+    //    unimplemented gate even though `createRandom` was registered with
+    //    class_filter=Wallet.
+    API_MANIFEST.iter().find(|e| {
+        if e.module != module {
+            return false;
+        }
+        if e.name == name {
+            return true;
+        }
+        matches!(
+            e.kind,
+            ApiKind::Method { class_filter: Some(c), .. } if c == name
+        )
+    })
 }
 
 /// True if `path` resolves to a Perry-implemented native module.

crates/perry-codegen/src/lower_call/native.rs

@@ -1161,6 +1161,11 @@ pub(crate) fn lower_native_method_call(
         && method != "App"
         && method != "VStack"
         && method != "HStack"
+        // Image + WebView have option-bag handlers further down that
+        // do their own arg destructuring; they're not in perry_ui_table
+        // so they must skip this catch-all bail.
+        && method != "Image"
+        && method != "WebView"
     {
         if let Some(sig) = perry_ui_table_lookup(method) {
             return lower_perry_ui_table_call(ctx, sig, args);

crates/perry-transform/src/state_desugar.rs

@@ -871,6 +871,43 @@ fn try_rewrite_state_access(e: &Expr, bindings: &HashMap<LocalId, StateBinding>)
             }
         }
     }
+    // HIR's "perry/ui state class" lowering routes `state.set(v)` /
+    // `state.value` / `state.get()` / `state.text()` through
+    // `NativeMethodCall { module: "perry/ui", class_name: Some("State"),
+    // object: Some(LocalGet(state_id)), method: ..., args }` instead of
+    // the PropertyGet shape. Recognize that form here so the rewrite
+    // actually fires (otherwise `state.value` stays as a no-op method
+    // call on `undefined` — see textarea / state docs failures).
+    if let Expr::NativeMethodCall {
+        module,
+        class_name,
+        object: Some(obj),
+        method,
+        args,
+        ..
+    } = e
+    {
+        // `.set` carries `class_name: Some("State")`; `.value` / `.get`
+        // come through with `class_name: None`. Accept either as long
+        // as the receiver resolves to one of our bindings.
+        let class_ok = class_name.is_none() || class_name.as_deref() == Some("State");
+        if module == "perry/ui" && class_ok {
+            if let Expr::LocalGet(state_id) = obj.as_ref() {
+                if let Some(binding) = bindings.get(state_id) {
+                    return match method.as_str() {
+                        "get" | "value" if args.is_empty() => {
+                            Some(state_get_call(&binding.synth_id))
+                        }
+                        "set" if args.len() == 1 => {
+                            Some(state_set_call(&binding.synth_id, args[0].clone()))
+                        }
+                        "text" if args.is_empty() => Some(state_text_call(binding)),
+                        _ => None,
+                    };
+                }
+            }
+        }
+    }
     None
 }
 

crates/perry/src/commands/compile/link.rs

@@ -1521,6 +1521,46 @@ pub(super) fn build_and_run_link(
                     );
                     cmd.arg("-lshumate-1.0");
                 }
+                // WebKitGTK 6.0 + libsoup-3.0 — perry/ui WebView (#658, v0.5.864).
+                // perry-ui-gtk4's webkit6/soup3 deps reference symbols like
+                // `soup_check_version` from libsoup-3.0 transitively; without
+                // explicit `-lsoup-3.0` ld errors with `DSO missing from
+                // command line`. Same pkg-config → hardcoded-fallback shape
+                // as GTK4 / GStreamer / shumate above.
+                let mut got_webkit_libs = false;
+                let webkit_pc_out = Command::new("pkg-config")
+                    .args(["--libs", "webkitgtk-6.0", "libsoup-3.0"])
+                    .output();
+                if let Ok(ref output) = webkit_pc_out {
+                    if output.status.success() {
+                        let libs = String::from_utf8_lossy(&output.stdout);
+                        for flag in libs.trim().split_whitespace() {
+                            cmd.arg(flag);
+                        }
+                        got_webkit_libs = true;
+                    }
+                }
+                if !got_webkit_libs {
+                    eprintln!(
+                        "Warning: `pkg-config --libs webkitgtk-6.0 libsoup-3.0` \
+                         did not return WebKitGTK linker flags ({}). Falling \
+                         back to a hardcoded set — install `libwebkitgtk-6.0-dev` \
+                         (Debian/Ubuntu) which pulls libsoup-3.0-dev + \
+                         libjavascriptcoregtk-6.0-dev to silence this warning.",
+                        match &webkit_pc_out {
+                            Err(e) => format!("pkg-config not runnable: {e}"),
+                            Ok(o) if !o.status.success() => format!(
+                                "pkg-config exited {}: {}",
+                                o.status.code().unwrap_or(-1),
+                                String::from_utf8_lossy(&o.stderr).trim()
+                            ),
+                            Ok(_) => "no output".to_string(),
+                        }
+                    );
+                    for lib in ["-lwebkitgtk-6.0", "-ljavascriptcoregtk-6.0", "-lsoup-3.0"] {
+                        cmd.arg(lib);
+                    }
+                }
             } else if is_windows {
                 // Win32 system libs already linked above
             } else {