Commit 5f72ba2
committed
fix(perry-ui-gtk4): upcast pango sub-attrs to Attribute (v0.5.889)
PR #716 added crates/perry-ui-gtk4/src/widgets/attributed_text.rs
with pango Attribute construction that doesn't compile against the
pango-rs sub-attribute type hierarchy. `AttrInt::new_weight()` etc.
return concrete subtype (AttrInt, AttrSize, AttrColor); the push
closure expects the parent `pango::Attribute`. Need explicit
.upcast() per the glib type system.
The error didn't surface on #716's CI because the gtk4 doc-tests
matrix entry is disabled (v0.5.874 timeouts), and the release build
matrix is the only path that builds perry-ui-gtk4 cross-arch.
Surfaced on v0.5.888's release run.
5 sites updated. Uses gtk4::glib::object::Cast trait import.1 parent a8991cd commit 5f72ba2
3 files changed
Lines changed: 14 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
98 | 105 | | |
99 | | - | |
| 106 | + | |
100 | 107 | | |
101 | 108 | | |
102 | | - | |
| 109 | + | |
103 | 110 | | |
104 | 111 | | |
105 | | - | |
| 112 | + | |
106 | 113 | | |
107 | 114 | | |
108 | | - | |
109 | | - | |
110 | | - | |
| 115 | + | |
111 | 116 | | |
112 | 117 | | |
113 | 118 | | |
114 | | - | |
| 119 | + | |
115 | 120 | | |
116 | 121 | | |
117 | 122 | | |
| |||
0 commit comments