Skip to content

Commit 76f8427

Browse files
committed
fix(ui): styling-matrix drift — flip 4 GTK4 cells Wired (post-#206)
#206 added 4 GTK4 FFI exports (perry_ui_widget_set_on_click, perry_ui_button_set_content_tint_color, perry_ui_button_set_image_position, perry_ui_stack_set_detaches_hidden) but didn't update crates/perry-ui/src/styling_matrix.rs. The drift test (crates/perry-ui/tests/styling_matrix_drift.rs) has been failing on every PR since #206 merged. Flip the 4 GTK4 cells from Missing to Wired and regenerate docs/src/ui/styling-matrix.md to match.
1 parent 8aa15d3 commit 76f8427

2 files changed

Lines changed: 9 additions & 10 deletions

File tree

crates/perry-ui/src/styling_matrix.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ pub const MATRIX: &[MatrixRow] = &[
269269
MatrixRow {
270270
widget: "*", prop: "on_click",
271271
ffi: "perry_ui_widget_set_on_click",
272-
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Missing, Wired, Wired],
272+
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired],
273273
},
274274
MatrixRow {
275275
widget: "*", prop: "on_double_click",
@@ -360,8 +360,7 @@ pub const MATRIX: &[MatrixRow] = &[
360360
MatrixRow {
361361
widget: "button", prop: "content_tint_color",
362362
ffi: "perry_ui_button_set_content_tint_color",
363-
// GTK4 lacks tint-on-icon-content per audit.
364-
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Missing, Wired, Wired],
363+
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired],
365364
},
366365
MatrixRow {
367366
widget: "button", prop: "bordered",
@@ -371,7 +370,7 @@ pub const MATRIX: &[MatrixRow] = &[
371370
MatrixRow {
372371
widget: "button", prop: "image_position",
373372
ffi: "perry_ui_button_set_image_position",
374-
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Missing, Wired, Wired],
373+
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired],
375374
},
376375

377376
// ---- image widget styling -----------------------------------------
@@ -400,7 +399,7 @@ pub const MATRIX: &[MatrixRow] = &[
400399
MatrixRow {
401400
widget: "stack", prop: "detaches_hidden",
402401
ffi: "perry_ui_stack_set_detaches_hidden",
403-
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Missing, Wired, Wired],
402+
statuses: [Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired, Wired],
404403
},
405404

406405
// ---- Aspirational (Phase B targets) -------------------------------

docs/src/ui/styling-matrix.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Legend: `✓` Wired (real native impl), `~` Stub (symbol exists, no-op), `✗` M
2424
| `height` | `perry_ui_widget_set_height` ||||||||||
2525
| `match_parent_width` | `perry_ui_widget_match_parent_width` ||||||||||
2626
| `match_parent_height` | `perry_ui_widget_match_parent_height` ||||||||||
27-
| `on_click` | `perry_ui_widget_set_on_click` ||||||| |||
27+
| `on_click` | `perry_ui_widget_set_on_click` ||||||| |||
2828
| `on_double_click` | `perry_ui_widget_set_on_double_click` ||||||||||
2929
| `on_hover` | `perry_ui_widget_set_on_hover` ||||||||||
3030
| `animate_opacity` | `perry_ui_widget_animate_opacity` ||||||||||
@@ -37,9 +37,9 @@ Legend: `✓` Wired (real native impl), `~` Stub (symbol exists, no-op), `✗` M
3737
| Prop | FFI symbol | macOS | iOS | tvOS | visionOS | watchOS | Android | GTK4 | Windows | Web |
3838
|---|---|---|---|---|---|---|---|---|---|---|
3939
| `text_color` | `perry_ui_button_set_text_color` ||||||||||
40-
| `content_tint_color` | `perry_ui_button_set_content_tint_color` ||||||| |||
40+
| `content_tint_color` | `perry_ui_button_set_content_tint_color` ||||||| |||
4141
| `bordered` | `perry_ui_button_set_bordered` ||||||||||
42-
| `image_position` | `perry_ui_button_set_image_position` ||||||| |||
42+
| `image_position` | `perry_ui_button_set_image_position` ||||||| |||
4343

4444
## `image` widget
4545

@@ -54,7 +54,7 @@ Legend: `✓` Wired (real native impl), `~` Stub (symbol exists, no-op), `✗` M
5454
|---|---|---|---|---|---|---|---|---|---|---|
5555
| `alignment` | `perry_ui_stack_set_alignment` ||||||||||
5656
| `distribution` | `perry_ui_stack_set_distribution` ||||||||||
57-
| `detaches_hidden` | `perry_ui_stack_set_detaches_hidden` ||||||| |||
57+
| `detaches_hidden` | `perry_ui_stack_set_detaches_hidden` ||||||| |||
5858

5959
## `text` widget
6060

@@ -87,7 +87,7 @@ Legend: `✓` Wired (real native impl), `~` Stub (symbol exists, no-op), `✗` M
8787
| visionOS | 43 | 0 | 0 | 0 |
8888
| watchOS | 43 | 0 | 0 | 0 |
8989
| Android | 43 | 0 | 0 | 0 |
90-
| GTK4 | 39 | 0 | 4 | 0 |
90+
| GTK4 | 43 | 0 | 0 | 0 |
9191
| Windows | 38 | 5 | 0 | 0 |
9292
| Web | 43 | 0 | 0 | 0 |
9393

0 commit comments

Comments
 (0)