Skip to content

ci: run real gosec SARIF instead of hardcoded empty results#112

Merged
sirantd merged 1 commit into
mainfrom
ci/real-gosec-sarif
May 31, 2026
Merged

ci: run real gosec SARIF instead of hardcoded empty results#112
sirantd merged 1 commit into
mainfrom
ci/real-gosec-sarif

Conversation

@sirantd

@sirantd sirantd commented May 31, 2026

Copy link
Copy Markdown
Contributor

The security job in ci.yml and the sast job in security.yml installed staticcheck/govulncheck, discarded their output, then wrote a hardcoded empty SARIF ("results":[]) and uploaded that. gosec was never actually run, so the Security tab always showed clean regardless of real findings.

Both jobs now install and run gosec with native SARIF output (-no-fail -fmt sarif) uploaded under a gosec category. Dropped the discarded staticcheck/govulncheck steps here since golangci-lint and the dedicated vulnerability-scan/dependency-scan jobs already cover them. Semgrep, CodeQL and Grype are unchanged.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@sirantd sirantd merged commit 490ed47 into main May 31, 2026
38 checks passed
@sirantd sirantd deleted the ci/real-gosec-sarif branch May 31, 2026 10:50
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.5.9 🎉

Release Notes:

1.5.9 (2026-06-14)

📦 Dependencies

  • deps: bump k8s.io/api from 0.36.0 to 0.36.1 (#113) (57616a9)

Installation:

helm install deployment-annotator-controller oci://ghcr.io/perun-engineering/deployment-annotator-for-grafana/helm/deployment-annotator-controller --version 1.5.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants