fix(core): strip leaked build-script env from nested eBPF cargo call#53
Merged
Conversation
Cargo sets LD_LIBRARY_PATH/RUSTC/RUSTUP_TOOLCHAIN for build scripts to point at the outer build's own rustc/sysroot. Inherited as-is by the nested `cargo +nightly build --package oom-watcher-ebpf` invocation, LD_LIBRARY_PATH made its rustc load a mismatched librustc_driver, failing `rustc -vV` with an undefined-symbol error on both archs. Verified locally: `docker build --target builder --platform linux/arm64 .` now completes cleanly in ~3 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo +nightly build --package oom-watcher-ebpfcall inbuild.rsinheritsLD_LIBRARY_PATH/RUSTC/RUSTUP_TOOLCHAINfrom the outer build-script environment.LD_LIBRARY_PATHin particular pointed the nestedrustcat a mismatchedlibrustc_driver, failingrustc -vVwith an undefined-symbol error on both amd64 and arm64 in the release workflow.Test plan
docker build --target builder --platform linux/arm64 .locally — completes cleanly in ~3 min, eBPF build succeeds, binary found and copied